opensource/coder
3
0
Fork 0
mirror of https://github.com/coder/coder.git synced 2026-10-29 17:44:33 +08:00
Code Issues Packages Projects Releases Wiki Activity
5,350 Commits 479 Branches 417 Tags
e6aeee2ba24b9860c8a46e59ef3793f1dba80b5f
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Kyle Carberry 5e3bf275da chore: check for valid regex in git auth configs (#10020) 2023-10-03 16:45:07 +00:00
Kyle Carberry f16eb1331f chore: update multiple git providers docs (#10017) 
* chore: update multiple git providers docs

* Improve var name

* Fix fmt
 2023-10-03 15:27:02 +00:00
Kyle Carberry eeab33b1c3 fix: do not require client_secret for external auth providers (#10016) 
Device-based auth does not need a client secret.
 2023-10-03 14:29:34 +00:00
Kyle Carberry 45b53c285f feat: allow external services to be authable (#9996) 
* feat: allow external services to be authable

* Refactor external auth config structure for defaults

* Add support for new config properties

* Change the name of external auth

* Move externalauth -> external-auth

* Run gen

* Fix tests

* Fix MW tests

* Fix git auth redirect

* Fix lint

* Fix name

* Allow any ID

* Fix invalid type test

* Fix e2e tests

* Fix comments

* Fix colors

* Allow accepting any type as string

* Run gen

* Fix href
 2023-10-03 14:04:39 +00:00
Kyle Carberry 5596fb20b5 chore: move /gitauth to /externalauth on the frontend (#9954) 
* chore: move `/gitauth` to `/externalauth` on the frontend

This actually took a lot more jank than anticipated,
so I wanted to split this up before adding the ability
to embed new providers.

* Rename FE

* Fix em' up

* Fix linting error

* Fix e2e tests

* chore: update helm golden files
 2023-09-30 14:30:01 -05:00
Kyle Carberry c1cd93da30 chore: update helm golden files (#9959) 2023-09-30 18:36:34 +00:00
Kyle Carberry 8abca9bea7 chore: rename git_auth to external_auth in our schema (#9935) 
* chore: rename `git_auth` to `external_auth` in our schema

We're changing Git auth to be external auth. It will support
any OAuth2 or OIDC provider.

To split up the larger change I want to contribute the schema
changes first, and I'll add the feature itself in another PR.

* Fix names

* Fix outdated view

* Rename some additional places

* Fix sort order

* Fix template versions auth route

* Fix types

* Fix dbauthz
 2023-09-29 19:13:20 +00:00
Kyle Carberry de6d0b9a1a fix: only specify vscode proxy uri if app subdomains enabled (#9891) 
Otherwise this generates an invalid URI that breaks code-server!
 2023-09-27 15:13:47 +00:00
Kyle Carberry 726a4dadf2 feat: allow magic string to generate session token for external apps (#9878) 
* fix: make non-http external app links open in the current window

* Allow magic string to be replaced with a session token for external apps

* Improve readibility
 2023-09-26 16:04:24 -05:00
Kyle Carberry c4718fd747 fix: remove pinned version for dogfood (#9872) 2023-09-26 02:23:42 +00:00
Kyle Carberry f7c89082d2 chore: swap dogfood to use modules (#9870) 2023-09-25 19:41:45 -05:00
Kyle Carberry 442fb105c9 chore: add git svg icon (#9869) 2023-09-26 00:15:55 +00:00
Kyle Carberry 20bfe6e9e5 fix: allow expansion from log_path for coder_script (#9868) 2023-09-25 23:45:55 +00:00
Kyle Carberry 6e6b808143 fix: add case for logs without a source (#9866) 
This is to support legacy logs!
 2023-09-25 22:19:51 +00:00
Kyle Carberry d3220c5db9 fix: resolve flake in log sender by checking context (#9865) 
See: https://github.com/coder/coder/actions/runs/6305051172/job/17117693579
 2023-09-25 22:19:27 +00:00
Kyle CarberryandMuhammad Atif Ali 1262eef2c0 feat: add support for coder_script (#9584) 
* Add basic migrations

* Improve schema

* Refactor agent scripts into it's own package

* Support legacy start and stop script format

* Pipe the scripts!

* Finish the piping

* Fix context usage

* It works!

* Fix sql query

* Fix SQL query

* Rename `LogSourceID` -> `SourceID`

* Fix the FE

* fmt

* Rename migrations

* Fix log tests

* Fix lint err

* Fix gen

* Fix story type

* Rename source to script

* Fix schema jank

* Uncomment test

* Rename proto to TimeoutSeconds

* Fix comments

* Fix comments

* Fix legacy endpoint without specified log_source

* Fix non-blocking by default in agent

* Fix resources tests

* Fix dbfake

* Fix resources

* Fix linting I think

* Add fixtures

* fmt

* Fix startup script behavior

* Fix comments

* Fix context

* Fix cancel

* Fix SQL tests

* Fix e2e tests

* Interrupt on Windows

* Fix agent leaking script process

* Fix migrations

* Fix stories

* Fix duplicate logs appearing

* Gen

* Fix log location

* Fix tests

* Fix tests

* Fix log output

* Show display name in output

* Fix print

* Return timeout on start context

* Gen

* Fix fixture

* Fix the agent status

* Fix startup timeout msg

* Fix command using shared context

* Fix timeout draining

* Change signal type

* Add deterministic colors to startup script logs

---------

Co-authored-by: Muhammad Atif Ali <atif@coder.com>
 2023-09-25 16:47:17 -05:00
Kyle Carberry 82e238b0c6 chore: exclude generated files from vscode search by default (#9530) 
Anyone can feel free to revert some of these, but they were constantly
annoying when searching for symbols in our code.
 2023-09-05 15:05:46 +00:00
Kyle Carberry da0ef92f77 Revert "feat: add boringcrypto builds for linux (#9528)" (#9529) 
This reverts commit 79cd6047dc.
 2023-09-05 08:37:07 -05:00
Kyle Carberry 05439d2c1b fix: generate username with uuid to prevent collision (#9496) 
See https://github.com/coder/coder/actions/runs/6052801777/job/16426982174
 2023-09-03 18:02:28 +00:00
Kyle Carberry 61634d482f fix: truncate websocket close error (#9360) 
Related #9324
 2023-08-27 16:26:31 +00:00
Kyle Carberry c3ac55ff42 feat: add template_active_version_id to workspaces (#9226) 
* feat: add `template_active_version_id` to workspaces

This reduces a fetch in the VS Code extension when getting the
active version update message!

* Fix entities.ts

* Fix golden gen
 2023-08-27 16:26:20 +00:00
Kyle Carberry 707a0a2d95 fix: resolve deadlock when fetching everyone group for in-memory db (#9277) 2023-08-23 16:54:16 +00:00
Kyle Carberry 2a04d15c6d chore: downgrade dogfood image to postgres 13 (#9228) 2023-08-21 19:26:31 +00:00
Kyle Carberry 07188b123a chore: add dependencies for js-test to our nix flake (#9224) 2023-08-21 15:03:33 +00:00
Kyle Carberry 7404ee9b21 chore: add name to top-level package.json to allow importing (#9209) 2023-08-20 00:35:38 +00:00
Kyle Carberry 4d85d56327 chore: add version to top-level package.json to allow importing (#9208) 2023-08-20 00:10:53 +00:00
Kyle Carberry 2c83bfdfa5 fix: set the location of locale_archive (#9207) 
See https://nixos.wiki/wiki/Locales
 2023-08-19 22:37:44 +00:00
Kyle Carberry 40ef9ff779 fix: add sapling to the nix flake (#9202) 2023-08-18 16:41:03 -05:00
Kyle Carberry 22e781eced chore: add /v2 to import module path (#9072) 
* chore: add /v2 to import module path

go mod requires semantic versioning with versions greater than 1.x

This was a mechanical update by running:
```
go install github.com/marwan-at-work/mod/cmd/mod@latest
mod upgrade
```

Migrate generated files to import /v2

* Fix gen
 2023-08-18 18:55:43 +00:00
Kyle Carberry 9e9c79dbd3 fix: remove nix bash from the dogfood image (#9195) 
This was unnecessary.
 2023-08-18 17:59:25 +00:00
Kyle Carberry 4c133e7058 fix: add yarn to the dogfood image (#9193) 2023-08-18 17:15:33 +00:00
Kyle Carberry c93782aba6 fix: allow chsh in dev image (#9191) 2023-08-18 16:15:05 +00:00
Kyle Carberry 9725ec0713 fix: separate dev shell and dev image nix deps (#9189) 
* fix: separate dev shell and dev image nix deps

* Add less
 2023-08-18 15:58:52 +00:00
Kyle Carberry e94ebea5e9 fix: add gh cli to the dogfood image (#9184) 2023-08-18 14:49:54 +00:00
Kyle CarberryandMathias Fredriksson 88de63f891 fix: add locale to dogfood image (#9181) 
* fix: add locale to dogfood image

* Update flake.nix

Co-authored-by: Mathias Fredriksson <mafredri@gmail.com>

* Add gcc

---------

Co-authored-by: Mathias Fredriksson <mafredri@gmail.com>
 2023-08-18 09:16:16 -05:00
Kyle Carberry c0a78533bf chore: reduce build time by converting docker image to build with nix (#9099) 
* Add Docker image

* Try building the container in CI

* Uncomment testing lines

* Trim image step

* Hit 'em with a Docker load

* Oopsie!

* Add a tag and push!

* Fix image name 🤦

* Fix sudo

* Fix target name

* Build and push

* Fix login to docker hub

* Revert to Docker push

* Fix PATH

* Fix SHA

* Fix ca certs

* Fix ca certs

* Fix coping files in

* Fix docker init

* Fix Docker group and init

* Add comments to our Nix

* Fix build stage

* Add some more comments

* Remove old dogfood image files

* Tag and push with branch name

* Fix tag passing

* Fix tag passing

* Remove old pull triggers

* Convert gen to use Nix

* Add protobuf to the flake

* Add prettier to the dev shell

* Swap to the faster Nix cache action

* Add the correct yq

* Fix gen

* Add make to the flake

* Update extensions
 2023-08-17 21:19:36 -05:00
Kyle Carberry 594b9797dd fix: change dashboard route /settings/deployment to /deployment (#9070) 
It felt unnecessary to nest this.
 2023-08-13 16:58:04 +00:00
Kyle Carberry 0d01d022f7 fix: remove unnecessary newlines from the end of cli output (#9068) 
`Infof` already adds a newline, so we don't need to as well!
 2023-08-13 11:48:11 -05:00
Kyle Carberry 9a13814b46 fix: remove duplication from language of query param error (#9069) 2023-08-13 11:47:44 -05:00
Kyle Carberry abe17b1164 chore: update speakeasy to fix stty path bug on nixos (#9022) 
Prompts failed on NixOS due to /bin/stty being hardcoded for turning
off echo in the terminal prompt. See:
https://github.com/bgentry/speakeasy/commit/760eaf8b681647364e7a400b856e0921248728a5
 2023-08-13 15:10:58 +00:00
Kyle Carberry 4d3230c9ad fix: default to executing e2e ssh without args (#8975) 
This was causing the test to fail consistently!
 2023-08-08 14:35:34 +00:00
Kyle Carberry bac3a588b3 chore: add e2e test for backwards client ssh compatibility (#8958) 
* chore: add e2e test for backwards client ssh compatibility

This was discussed as part of our regression review for outdated
agents, so here is the reverse with an extremely old client.

* fmt
 2023-08-08 05:36:46 +00:00
Kyle Carberry 73b136e3f0 fix: add exp backoff to validate fresh git auth tokens (#8956) 
A customer using GitHub in Australia reported that validating immediately
after refreshing the token would intermittently fail with a 401. Waiting
a few milliseconds with the exact same token on the exact same request
would resolve the issue. It seems likely that the write is not propagating
to the read replica in time.
 2023-08-08 04:29:35 +00:00
Kyle Carberry bd944e0d21 chore: rename startup logs to agent logs (#8649) 
* chore: rename startup logs to agent logs

This also adds a `source` property to every agent log. It
should allow us to group logs and display them nicer in
the UI as they stream in.

* Fix migration order

* Fix naming

* Rename the frontend

* Fix tests

* Fix down migration

* Match enums for workspace agent logs

* Fix inserting log source

* Fix migration order

* Fix logs tests

* Fix psql insert
 2023-07-28 15:57:23 +00:00
Kyle Carberry 91a0c7abe0 fix: improve the language of the template insights page (#8777) 2023-07-27 21:04:28 +00:00
Kyle Carberry ff794e4b23 chore: add e2e test for backwards ssh compatibility (#8761) 
* chore: add e2e test for backwards ssh compatibility

* Use the SSH client directly

* fmt
 2023-07-27 10:42:11 -05:00
Kyle Carberry 131babfb00 fix: request trial after password is validated (#8750) 2023-07-26 22:04:15 +00:00
Kyle CarberryandMathias Fredriksson 98164f687e fix!: remove startup logs eof for streaming (#8528) 
* fix: remove startup logs eof for streaming

We have external utilities like logstream-kube that may send
logs after an agent shuts down unexpectedly to report additional
information. In a recent change we stopped accepting these logs,
which broke these utilities.

In the future we'll rename startup logs to agent logs or something
more generalized so this is less confusing in the future.

* fix(cli/cliui): handle never ending startup log stream in Agent

---------

Co-authored-by: Mathias Fredriksson <mafredri@gmail.com>
 2023-07-18 09:57:29 -06:00
Kyle Carberry b4a7fe3221 fix: use expires_in field for git device refresh (#8411) 
This was causing git auth to never refresh after the token
became expired after 8hrs.
 2023-07-11 09:28:52 +00:00
Kyle Carberry 34467a3289 feat: add github device flow for authentication (#8232) 
* feat: add github device flow for authentication

This will allow us to add a GitHub OAuth provider out-of-the-box
to reduce setup requirements.

* Improve askpass view

* Add routes to improve clarity of git auth

* Redesign the git auth page

* Refactor to add a page view

* Fix sideways layout

* Remove legacy notify

* Fix git auth redirects

* Add E2E tests

* Fix route documentation

* Fix imports

* Remove unused imports

* Fix E2E web test

* Fix friendly message appearance

* Fix layout shifting for full-screen sign-in

* Fix height going to 100%

* Fix comments
 2023-06-29 18:58:01 +00:00
Kyle Carberry f40865bc2f chore: use mutex around blockEndpoints (#8209) 
https://github.com/coder/coder/actions/runs/5378950122/jobs/9759972142
 2023-06-26 10:01:50 -05:00
Kyle Carberry d434181941 feat: add cohesive e2e tests for the web terminal, apps, and workspaces (#8140) 
* feat: add cohesive e2e tests for the web terminal, apps, and workspaces

* Fix web terminal flake
 2023-06-22 00:21:40 +00:00
Kyle Carberry 2a492b7008 chore: improve the setup experience with various fixes (#8130) 
* Move updatecheck logs to debug mode

This was causing logs to be emitted immediately after
initial setup, which seemed odd for the user.

* Fix setup page text to say "Create" instead of "Setup" account

* Improve copy on the empty workspaces page

- This view can be seen after the user creates their first workspace, so saying first is bad.
- It should describe what a workspace is, so I modified the description.
- The create from template button wasn't helpful!

* Improve the copy for the empty templates view

- This didn't describe what a template actually is.
- The title had the same problem as workspaces, where first makes no sense.

* Improve text consistency on the Create Template page

* Fix "View activity" displaying for non-Enterprise users

This was causing an exception to be thrown.

* Improve messaging of empty groups view

* Appropriately capitalize Workspace and Template

* Improve Docker template taglines

* Fix types
 2023-06-21 18:23:59 -05:00
Kyle Carberry 69f911dfd5 feat: add queue_position and queue_size to provisioner jobs (#8074) 2023-06-20 15:07:18 -05:00
Kyle Carberry bbb0fab1de chore: merge database gen scripts (#8073) 
* chore: merge database gen scripts

* Fix type params gen

* Merge enum into dbgen
 2023-06-20 16:24:33 +00:00
Kyle Carberry f3b2009499 chore: reorder helm chart to improve ux (#8108) 
It makes no sense that the primary option `env` was so far
below infrequently used options.
 2023-06-20 16:23:56 +00:00
Kyle Carberry 467b0a1004 chore: restyle provisioner job output format (#8106) 
Reduce colors and formatting to reduce bugs and increase UNIX-feel.
 2023-06-20 16:16:27 +00:00
Kyle Carberry f444100aa6 feat: add region querying to pre-fetched html (#8077) 2023-06-19 11:23:26 -05:00
Kyle CarberryandMuhammad Atif Ali 5b9c3784bc docs: add steps for registering a github app with coder (#7976) 
Co-authored-by: Muhammad Atif Ali <atif@coder.com>
 2023-06-18 14:01:37 -05:00
Kyle Carberry 9df9ad4503 feat: embed common client requests into the template html (#8076) 
This should reduce the number of API requests a client makes
when loading the dashboard dramatically!
 2023-06-18 13:57:27 -05:00
Kyle Carberry 2a10c9127f fix: show git provider id instead of type (#8075) 
Fixes #6343.
 2023-06-18 17:01:44 +00:00
Kyle Carberry 8ac68c95a4 chore: lazily initialize find commands in makefile (#8030) 
Improves make performance for small targets!
 2023-06-14 13:17:16 -05:00
Kyle Carberry e4b6f5695b chore: separate pubsub into a new package (#8017) 
* chore: rename store to dbmock for consistency

* chore: remove redundant dbtype package

This wasn't necessary and forked how we do DB types.

* chore: separate pubsub into a new package

This didn't need to be in database and was bloating it.
 2023-06-14 15:34:54 +00:00
Kyle Carberry 8c4b7c01e2 chore: remove redundant dbtype package (#8014) 
* chore: rename store to dbmock for consistency

* chore: remove redundant dbtype package

This wasn't necessary and forked how we do DB types.
 2023-06-13 19:14:55 +00:00
Kyle Carberry 7d54fd5e0d chore: rename store to dbmock for consistency (#8013) 2023-06-13 13:57:43 -05:00
Kyle Carberry a658c94a67 chore: automatically generate dbauthz when new queries are added (#8007) 
* chore: automatically generate dbauthz when new queries are added

* Merge system functions
 2023-06-13 13:40:46 -05:00
Kyle Carberry 794a551176 chore: generate dbmetrics automatically when adding new queries (#7999) 
* chore: rename dbgen package files and remove small file

* chore: automatically generate dbmetrics when new queries are added
 2023-06-13 12:35:12 -05:00
Kyle Carberry 2e7e99b135 fix: scope errors to subtests for flake (#8004) 
See: https://github.com/coder/coder/actions/runs/5257676837/jobs/9500882394
 2023-06-13 11:52:17 -05:00
Kyle Carberry 24953869a6 chore: remove key comparison check to fix gitsshkey flake (#8002) 
In tests we use weak randomness and the same key was generated which
caused a test flake here.
 2023-06-13 15:51:45 +00:00
Kyle Carberry 75078fafa2 chore: try removing cache from fmt and lint (#8001) 2023-06-13 10:48:53 -05:00
Kyle Carberry 9440b3da66 chore: rename dbgen package files and remove small file (#7997) 2023-06-13 09:21:12 -05:00
Kyle Carberry 28f35393e7 chore: generate and order dbfake funcs automatically (#7986) 
* chore: rename `databasefake` to `dbfake`

* Remove unused method

* chore: add generation to dbfake

* Auto gen on make gen

* Fix preserving imports

* gen dbfake

* Add goimports

* Fix the makefile

* Make it panic instead of a comment
 2023-06-12 17:40:58 -05:00
Kyle Carberry 685abfc6d7 chore: rename databasefake to dbfake (#7979) 
* chore: rename `databasefake` to `dbfake`

* Remove unused method
 2023-06-12 16:05:37 -05:00
Kyle Carberry 6ac7d86c93 chore: prevent gen from rerunning every time (#7985) 2023-06-12 14:45:17 -05:00
Kyle Carberry 6e7175b589 chore: fix lengthy tests in psql (#7545) 
* chore: fix lengthy tests in psql

This was adding at a minimum 3mins to our psql tests!

* fix: automatically cancel tests on cleanup
 2023-05-17 11:26:53 -05:00
Kyle Carberry c6055c64be chore: improve input hover color (#7534) 2023-05-16 09:00:20 -03:00
Kyle Carberry 424f954b91 fix: use password style for session token auth (#7533) 2023-05-15 11:27:39 -05:00
Kyle Carberry a08e8a16ab chore: switch make test to use the standard go format (#7519) 
I find it easier to read.
 2023-05-14 21:20:19 -05:00
Kyle Carberry 70d2203b9e chore: reduce the log output of skipped tests (#7520) 
With the introduction of the workspace proxy tests there was a lot
of output if a test was eventually skipped.
 2023-05-14 19:37:00 -05:00
Kyle Carberry 26490aecca chore: improve postgres test time by removing cleanup (#7522) 
We don't need to delete databases on cleanup... and we don't need to
always run without a cache either!
 2023-05-14 15:32:44 -05:00
Kyle Carberry 778cb7494a chore: adjust the style and wording of the license page (#7396) 
- Reduce the size of the card to improve the use of space
- Adjust the language of the add page to remove word redundancy
- Change from using background colors to text colors
 2023-05-14 15:31:54 -05:00
Kyle Carberry 8e1da5e628 chore: run yarn-deduplicate to speed up yarn install (#7523) 2023-05-14 15:28:07 -05:00
Kyle Carberry 50f2d0c7e9 fix: add a mutex around reading logs from scaletests (#7521) 2023-05-14 12:16:00 -05:00
Kyle Carberry 11ac3be4d8 fix: redirect to login on gitauth invalid session (#7416) 2023-05-04 17:19:44 +00:00
Kyle Carberry 90c57a538c fix: make telemetry source a string not an enum (#7390) 2023-05-03 14:33:51 +00:00
Kyle CarberryandMathias Fredriksson fd84df769d fix: add DISPLAY env var for X11 connections (#7248) 
* fix: add `DISPLAY` env var for X11 connections

* Update agent/agentssh/agentssh.go

Co-authored-by: Mathias Fredriksson <mafredri@gmail.com>

---------

Co-authored-by: Mathias Fredriksson <mafredri@gmail.com>
 2023-04-21 16:43:49 +00:00
Kyle Carberry f39e6a79de feat: add support for X11 forwarding (#7205) 
* feat: add support for X11 forwarding

* Only run X forwarding on Linux

* Fix piping

* Fix comments
 2023-04-21 15:52:40 +00:00
Kyle Carberry 888eb238ec fix: use CODER_HTTP_ADDRESS in docker-compose.yml (#7185) 
Fixes #7184.
 2023-04-18 11:44:41 -05:00
Kyle Carberry 693e5d94bc fix: add global headers to vscodessh command (#7181) 2023-04-18 08:07:10 -05:00
Kyle Carberry 26cfc18b74 fix: use proper deployment access setting name (#7162) 2023-04-17 10:01:51 -05:00
Kyle Carberry d3356fa48e fix: upgrade terraform in apk (#7146) 2023-04-14 20:10:17 -05:00
Kyle Carberry 7f12020229 fix: remove irrelevant help info from coder tokens create (#7135) 
The additional text didn't help much, and made it much harder to script around.
 2023-04-14 12:18:01 -05:00
Kyle Carberry 0bbe1562f3 fix: adjust manifest for networking doc (#7136) 2023-04-14 09:36:23 -05:00
Kyle Carberry 81e2b2500a feat: add level support for startup logs (#7067) 
This allows external services like our devcontainer support to display
errors and warnings with custom styles to indicate failures to users.
 2023-04-10 14:29:59 -05:00
Kyle Carberry e1149992d8 feat: support ansi colors in startup script logs (#7037) 
This will help with beautiful output for devcontainers!
 2023-04-06 12:39:09 -05:00
Kyle Carberry c68ab7d9a8 fix: support X-Forwarded-Host with CODER_REDIRECT_TO_ACCESS_URL (#7035) 
Fixes #7026.
 2023-04-06 12:07:24 -05:00
Kyle Carberry 3ff2ae1b1a fix: output askpass to stderr (#7034) 
This fixes askpass not outputting a prompt.
 2023-04-06 11:32:43 -05:00
Kyle CarberryandColin Adler 385a4262e2 fix: remove audit-logging flag from the server (#6991) 
Co-authored-by: Colin Adler <colin1adler@gmail.com>
 2023-04-04 12:11:10 -05:00
Kyle Carberry c12bc39821 fix: always show a newly created workspace at the top of the list (#6984) 
Fixes #5795.
 2023-04-04 08:24:04 -05:00
Kyle Carberry 861d4afdd8 fix: update tailscale to remove websocket logs (#6981) 2023-04-03 16:28:49 +00:00