Commit Graph

7383 Commits

Author SHA1 Message Date
TheR1sing3un de7cd0df10 [ISSUE#4959] Fix the logic when deal with a write event with empty events
* fix(controller): fix the logic when deal with a write event with empty events

1. fix the logic when deal with a write event with empty events

* style(controller): remove unused import

1. remove unused import
2022-09-01 19:48:05 +08:00
khl 51b5cd1947 using take replace poll (#4754)
* using take replace poll

* Remove unused import

Co-authored-by: Zhanhui Li <lizhanhui@apache.org>
2022-09-01 19:47:53 +08:00
lizhiboo 00780abb99 [ISSUE #4963] Prepare to release RocketMQ 5.0.0 version 2022-09-01 17:53:29 +08:00
CoedPig 74bae190d5 fix code style in MQClientInstance (#4961)
* optimize the memory usage in DefaultMappedFile:
use AtomicIntegerFieldUpdater instead of AtomicInteger

* fix code bug:
if the initial cursor of listIterator equals zero,
the previous element will always null.

* modify constant name

* fix excessive nesting

* Update client/src/main/java/org/apache/rocketmq/client/impl/factory/MQClientInstance.java

* update maven-surefire-plugin.version from 2.19.1 to 2.22.1

* Revert "update maven-surefire-plugin.version from 2.19.1 to 2.22.1"

This reverts commit 37fabe6e78.

* Code Style: fix warn info from the code detector.

* fix checkstyle: not use '*' for import.

Co-authored-by: shanpengyu <shanpengyu@bytedance.com>
Co-authored-by: Aaron Ai <yangkun.ayk@gmail.com>
2022-09-01 11:20:24 +08:00
lk cafb319612 [ISSUE #4938, ISSUE #4939] fix the concurrency problems when renew and ack/changeInvisibleTime at the same time; retry renew for a limited times when some error occurred (#4940) 2022-09-01 10:11:46 +08:00
zhaows c6820f23eb send async,time calculation rules Multiple method patches (#4881)
* Clear out meaningless changes

* merge upstream/dev

* merge upstream/dev

* send async,time calculation rules Multiple method patches

* Clear out meaningless changes

* merge upstream/dev

* merge upstream/dev

* send async,time calculation rules Multiple method patches
2022-09-01 09:44:27 +08:00
lk c11ed78eeb [ISSUE #4955] validate userProperties contain control character or not (#4956) 2022-09-01 09:41:28 +08:00
lk f77377f364 [ISSUE #4953] return INVALID_RECEIPT_HANDLE when cannot find the broker of handle (#4954) 2022-09-01 09:39:13 +08:00
lk 528b102a30 [ISSUE #4947] write client settings in lock and optimize the process of error handle (#4948) 2022-09-01 09:38:31 +08:00
TheR1sing3un f043ca8c18 [ISSUE#4950] fix wrong typo about DLedger (#4951)
* style(controller): fix the wrong typo about DLedger

1. fix the wrong typo about DLedger

* style(controller): fix the wrong typo about DLedger

1. fix the wrong typo about DLedger
2022-08-31 20:11:17 +08:00
lk b6191b8f5a [ISSUE #4943] not to assert time cost in test case (#4946) 2022-08-31 16:32:30 +08:00
CoedPig a940d96af0 Fix excessive nesting in MQClientInstance#sendHeartbeatToAllBroker (#4932)
* fix excessive nesting

Co-authored-by: shanpengyu <shanpengyu@bytedance.com>
Co-authored-by: Aaron Ai <yangkun.ayk@gmail.com>
2022-08-31 16:20:12 +08:00
rongtong 516e0d727b [ISSUE #4936] Remove useless log output after the master and slave broker are started on the empty disk in controller mode (#4944)
* Fix invalid log output after the master and slave broker are started on the empty disk in controller mode

* Remove useless log output after the master and slave broker are started on the empty disk in controller mode
2022-08-31 16:07:12 +08:00
rongtong f1f8bcbc8b [ISSUE#4936] Fix invalid log output after the master and slave broker are started on the empty disk in controller mode
[ISSUE#4936] Fix invalid log output after the master and slave broker are started on the empty disk in controller mode
2022-08-31 11:38:46 +08:00
Aaron Ai 4661e58ebe [ISSUE #4934] Checking for violations as part of build (#4935)
* Checking for violations as part of build

* Extend await time for FileWatchServiceTest#watchTwoFiles_ModifyOne
2022-08-31 10:55:04 +08:00
Aaron Ai f23fdbe016 Replace findbugs by spotbugs (#4931) 2022-08-30 17:45:56 +08:00
Zhanhui Li a488a0c22d [ISSUE 4926]Fix FileWatchServiceTest (#4927)
* Fix FileWatchService

* Fix all warnings and optimize FileWatchService implementation

* Take spurious wakeup into account
2022-08-30 14:24:46 +08:00
TheR1sing3un 7f25e453cd style(controller): fix the wrong typo about DLedger (#4930)
1. fix the wrong typo about DLedger
2022-08-30 13:38:26 +08:00
Zhanhui Li 5206354399 Restore use of pull request target for bazel github action pipeline (#4924) 2022-08-30 10:06:26 +08:00
mxsm 21fb9084ac [ISSUE #4920]Fix comment word typo (#4928) 2022-08-30 09:31:36 +08:00
TheR1sing3un 6a8b1aa96b [ISSUE#4917] Optimize the retry logic in appending a no-op request when controller change to leader (#4918) 2022-08-30 08:43:03 +08:00
mxsm cf74c3cd8b [ISSUE #4913] ReplicasManager#schedulingSyncControllerMetadata update controller metadata again after a while (#4914) 2022-08-29 20:42:28 +08:00
rongtong 9db648c5d9 [ISSUE #4921] Fix wrong log output in TimerMessageStore (#4922)
* Fix wrong log output in TimerMessageStore

* Modify the output level of log to debug
2022-08-29 20:05:45 +08:00
Zhanhui Li 62b383ae57 Make bazel check optional till all flaky tests are properly handled 2022-08-29 19:55:56 +08:00
Zhanhui Li aae7b37d04 [ISSUE 4915] Identify flaky tests (#4919)
* Rule out tests that are flaky. Aka they failed to pass 64 sequential  and concurrent runs

* Change default log root directory for tests

* Follow test encyclopedia

* Fix test cases, allowing OS pick up available port to listen to

* Add sha256

* Use pull_request
2022-08-29 19:52:53 +08:00
mxsm c1c960bb40 [ISSUE #4904]Optimize store module test cases to reduce execution time (#4908) 2022-08-29 08:41:34 +08:00
Shengmin Wang 244959ca51 set requestHeader setZeroIfNotFound false (#4910) 2022-08-28 20:31:39 +08:00
rongtong 36a5a5dedd Make all admin command descriptions begin with capital letters (#4912) 2022-08-28 20:30:27 +08:00
rongtong 2a46dbed19 Add required pull request reviews rule for develop branch (#4907) 2022-08-27 20:30:52 +08:00
mxsm a961d1b44a [ISSUE #4817] Add a command to clear broker data from controller for CLI (#4823) 2022-08-27 19:42:55 +08:00
echooymxq f7c2072a27 [ISSUE #4841] Fix the reply message is the original request msg. (#4896) 2022-08-27 11:00:20 +08:00
rongtong 1cc7afd6af Increase initial delay time to fix scheduledTask refresh metadata exception when broker start (#4901) 2022-08-26 18:04:09 +08:00
Zhouxiang Zhan 03f3a4e63a Optimize DefaultTopicMessageTypeValidator error information (#4900) 2022-08-26 17:49:15 +08:00
rongtong 16369e200c [ISSUE #4897] Increase the retry interval of registration failure to prevent frequent log output 2022-08-26 17:16:02 +08:00
rongtong c411713836 [ISSUE #4894] Fix NPE in CommandUtil
[ISSUE #4894] Fix NPE in CommandUtil
2022-08-26 15:31:08 +08:00
mxsm 64c18fb0db [ISSUE #4889]Fix controller test:DLedgerControllerTest#testChangeControllerLeader (#4892) 2022-08-26 09:06:02 +08:00
mxsm 5578808b44 [ISSUE #4873]Optimize controller module test cases execution time (#4882) 2022-08-25 14:43:44 +08:00
Zhanhui Li 0bd8bdf7f9 [ISSUE #4568]Improve performance of consume queue (#4569)
* Two improvements are made. 1, Search from previous minLogicOffset if possible; 2, Binary search instead of linear scan

* Add unit test cases, covering the changes

* Optimize terminal condition

* Adapt to latest code
2022-08-25 13:49:41 +08:00
Zhanhui Li ee1c9b31ce Refine test size of test module (#4886) 2022-08-25 13:05:03 +08:00
Jack Tsai 9ff8a312cb Fix Indentation Reported by Checkstyle (#4884)
Co-authored-by: tsaitsung-han.tht <tsaitsung-han.tht@alibaba-inc.com>
2022-08-25 12:07:32 +08:00
Zhanhui Li 4fad5007f8 Update required status check (#4883) 2022-08-25 11:24:46 +08:00
mxsm 0909aa91a2 [ISSUE #4857] Fix broker can't auto register to controller again (#4862) 2022-08-25 10:03:57 +08:00
xiaoyi a1d2a73255 [ISSUE #4805]In the subscribe mode, user-defined MessageQueueListener is supported. At the same time, you can specify the offset that the MessageQueue will commit (#4820) 2022-08-25 09:08:23 +08:00
Aaron Ai 451c963fd5 Enable dependency caching for coverage (#4880) 2022-08-25 08:42:16 +08:00
Zhanhui Li 3da7ea9c1b [Infra Improvement] Build And Run Unit Tests in Parallel (#4878)
* Support build with Bazel (#4865)

* Support build with Bazel, fixing tests to make them capable of running in concurrency and hermetic.

* Make test cases capable of running in parallel. (#4874)
2022-08-24 20:53:30 +08:00
caigy 10d291846e [ISSUE #4832] Remove innerProducer and innerConsumer in EscapeBridge (#4834)
* remove innerProducer and innerConsumer in Escape
 #4832

* format code to pass code-style check

* Move topic route management logic to TopicRouteInfoManager

* Use ThreadPoolExecutor instead of creating a new ForkJoinPool

* remove retry logic

* remove unnecessary name server list

* remove unnecessary invokeId

* remove AssignmentManager and make maintenance of topic subscribe data lazy-initialized

* simply code

* remove unnecessary code
2022-08-24 15:18:51 +08:00
Aaron Ai cf3c1ef57f Enhance the mergeability: add status checker about the protected branch (#4871) 2022-08-23 22:55:25 +08:00
Jun 0eca69bf25 fix #1942 push consumer doc error (#1944) 2022-08-23 19:32:04 +08:00
zhaows 9e4c624ea1 send async,time is not counted until the task is executed (#4839) 2022-08-23 19:00:58 +08:00
YangJodie a5b6a5d4a8 [ISSUE apache#4858] fix ci fialed 2022-08-23 18:52:10 +08:00