opensource/rocketmq
3
0
Fork 0
mirror of https://github.com/apache/rocketmq.git synced 2026-08-30 18:10:44 +08:00
Code Issues Packages Projects Releases Wiki Activity

[ISSUE#4959] Fix the logic when deal with a write event with empty events

Browse Source 
* fix(controller): fix the logic when deal with a write event with empty events

1. fix the logic when deal with a write event with empty events

* style(controller): remove unused import

1. remove unused import
This commit is contained in:
TheR1sing3un
2022-09-01 19:48:05 +08:00
committed by GitHub
parent 51b5cd1947
commit de7cd0df10
1 changed files with 14 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
controller/src/main/java/org/apache/rocketmq/controller/impl/DLedgerController.java
+14 -9
View File
@@ -343,7 +343,18 @@ public class DLedgerController implements Controller {
final ControllerResult<T> result = this.supplier.get();
log.info("Event queue run event {}, get the result {}", this.name, result);
boolean appendSuccess = true;
if (this.isWriteEvent) {
if (!this.isWriteEvent || result.getEvents() == null || result.getEvents().isEmpty()) {
// read event, or write event with empty events in response which also equals to read event
if (DLedgerController.this.controllerConfig.isProcessReadEvent()) {
// Now the dledger don't have the function of Read-Index or Lease-Read,
// So we still need to propose an empty request to dledger.
final AppendEntryRequest request = new AppendEntryRequest();
request.setBody(new byte[0]);
appendSuccess = appendToDLedgerAndWait(request);
}
} else {
// write event
final List<EventMessage> events = result.getEvents();
final List<byte[]> eventBytes = new ArrayList<>(events.size());
for (final EventMessage event : events) {
@@ -356,19 +367,13 @@ public class DLedgerController implements Controller {
}
// Append events to dledger
if (!eventBytes.isEmpty()) {
// batch append events
final BatchAppendEntryRequest request = new BatchAppendEntryRequest();
request.setBatchMsgs(eventBytes);
appendSuccess = appendToDLedgerAndWait(request);
}
} else {
if (DLedgerController.this.controllerConfig.isProcessReadEvent()) {
// Now the dledger don't have the function of Read-Index or Lease-Read,
// So we still need to propose an empty request to dledger.
final AppendEntryRequest request = new AppendEntryRequest();
request.setBody(new byte[0]);
appendSuccess = appendToDLedgerAndWait(request);
}
}
if (appendSuccess) {
final RemotingCommand response = RemotingCommand.createResponseCommandWithHeader(result.getResponseCode(), (CommandCustomHeader) result.getResponse());
if (result.getBody() != null) {