Commit Graph
42157 Commits
Author SHA1 Message Date
John Chilton cc93eddc3d Merge pull request #8536 from ic4f/dev_misc_fix3
Fix/cleanup a few minor things
2019-08-30 16:12:18 -04:00
Martin Cech fb72089739 Merge pull request #8530 from abretaud/library_tags
Add API to tag library datasets
2019-08-30 14:20:57 -04:00
John Chilton d6cf908153 Merge pull request #8544 from martenson/sql-text
explicitly declare expression as sql.text
2019-08-30 14:13:55 -04:00
John Chilton 9a289e25ad Merge pull request #8541 from martenson/somedocs
improve API docs
2019-08-30 14:04:12 -04:00
John Chilton 8519bdb172 Merge pull request #8521 from jmchilton/fix_container_kill
Fix killing containers error-ing out jobs.
2019-08-30 14:02:51 -04:00
John Chilton 2c8de89aed Merge pull request #8359 from bernt-matthias/topic/expression-try-except
catch exceptions occuring in expression validators
2019-08-30 14:00:51 -04:00
Martin Cech 21c7764875 Merge pull request #8543 from jmchilton/invocation_reports_4
Implement workflow invocation reports (🎉 syntax)
2019-08-30 13:52:21 -04:00
Martin Cech f0b30e997c Merge pull request #8549 from guerler/format_client
Format client
2019-08-30 13:48:35 -04:00
guerler 38ec505875 Format client 2019-08-30 12:10:16 -04:00
Martin Cech 9249521a07 Merge pull request #8542 from martenson/issues
update repo issue handling
2019-08-30 11:44:34 -04:00
Martin CechandNicola Soranzo 16ebbadb99 add space
Co-Authored-By: Nicola Soranzo <nicola.soranzo@gmail.com>
2019-08-30 11:44:27 -04:00
Martin Cech 9ea9e89fd6 Merge branch 'issues' of github.com:martenson/galaxy into issues 2019-08-30 11:11:32 -04:00
Martin Cech 96077d385c clarify labeling structure without mandatory status label 2019-08-30 11:10:59 -04:00
Martin CechandNicola Soranzo 945dda360c Apply suggestions from @nsoranzo
Co-Authored-By: Nicola Soranzo <nicola.soranzo@gmail.com>
2019-08-30 10:50:00 -04:00
Nate Coraor cba55f0177 Merge pull request #8538 from nsoranzo/cleanup_local
Improve and refactor process group handling in the local job runners.
2019-08-30 10:04:34 -04:00
John Chilton 411fd0578f Merge pull request #8539 from blankenberg/geda-cors
Enable GEDA parameters to declare allow_cors="true"
2019-08-30 10:04:05 -04:00
John Chilton fa637518e8 Implement yet another syntax for Galaxy Markdown.
The community took a vote (https://github.com/galaxyproject/galaxy/pull/8511#issuecomment-525886525) and the overwhelming favorite was this programming style declaration of a vaguely C-ish language embedded in quote fenced blocks.
2019-08-30 09:46:14 -04:00
John Chilton 664ab71653 Rework toward more RMarkdown-y syntax for Galaxy Markdown. 2019-08-30 09:43:15 -04:00
John Chilton ad650897d6 Implement workflow invocation reports.
Implement markdown backend and frontend components as well generator plugin framework to allow customizable workflow invocation reports.

Architectural Choices on the Client

Old-style embedded objects vs components

In theory, this could make really nice use of excellent VueJS components for dataset display, dataset collection display, workflow display, etc.. These aren't available yet, we don't even really have Backbone stuff that exist very well outside history panels, so this re-uses "components" from Galaxy Pages for datasets and reuses the collection display for history panels as a stand-alone display for collections (I got this trick from DIsplayStructured.vue). This isn't ideal and I know that but at least reusing things this way will provide a path forward for migrating both pages and this new Markdown language (which could easily replace or co-exist with pages HTML someday) together seamlessly as the real modern components become available and doesn't increase the overall work needed to integrate newer style components. In fact, this might even be the impetus for creating and polishing more of these components.

markdown-it vs markdown-it-vue

I tried this with markdown-it-vue also but it added very little in terms of reducing client code, obscured entirely how to attach plugins to the markdown rendering process, and brought in many, many more extra packages that we don't need or want.

Given there is no representation of invocations in the GUI and not editor for reports config this is a bit challenging still. But here is goes:

- Source Galaxy's virtualenv.
- Login to a user and grab an API key, set in the following command:
- ``GALAXY_TEST_EXTERNAL=http://localhost:8080 GALAXY_TEST_USER_API_KEY=38175dfc69d9009992b69efcca8b209b pytest test/api/test_workflows.py::WorkflowsApiTestCase::test_workflow_invocation_report_custom``
- In the web browser go to http://localhost:8080/api/invocations and grab the latest invocation ID. Replace it in the follow query string.
- Navigate to http://localhost:8080/workflows/invocations/report?id=c887f1d0da42bdfe
2019-08-30 09:43:01 -04:00
John Chilton 10aeb57ca4 rebuild yarn lock for markdown... 2019-08-30 09:37:18 -04:00
Nicola Soranzo 4e15c46879 Kill process group if orphans are still alive
after `proc.wait()`.

Thanks @natefoo for the suggestion.
2019-08-30 12:08:10 +01:00
Anthony Bretaudeau 8dfbb372bf fix tagging for all kinds of lib upload 2019-08-30 09:37:11 +02:00
Anthony Bretaudeau 6640a665a7 fix tag update 2019-08-30 09:35:21 +02:00
John Chilton ec561a4f12 Merge pull request #8537 from blankenberg/it
Make InteractiveTools compatible with Let's Encrypt certificates.
2019-08-29 16:07:55 -04:00
Martin Cech d0a52b655f explicitly declare expression as sql.text
fixes `ArgumentError: Textual SQL expression 'repository_metadata.repos...' should be explicitly declared as text('repository_metadata.repos...')`
failure during startup
2019-08-29 16:05:07 -04:00
Martin CechandNicola Soranzo 611288fe3d Update doc/source/project/issues.rst
Co-Authored-By: Nicola Soranzo <nicola.soranzo@gmail.com>
2019-08-29 15:38:18 -04:00
Martin CechandNicola Soranzo 7e0f78fe9b Update doc/source/project/issues.rst
Co-Authored-By: Nicola Soranzo <nicola.soranzo@gmail.com>
2019-08-29 15:38:12 -04:00
Martin CechandNicola Soranzo 46ec8c7a80 Update doc/source/project/issues.rst
Co-Authored-By: Nicola Soranzo <nicola.soranzo@gmail.com>
2019-08-29 15:38:05 -04:00
Nate Coraor f9f0001a81 Merge pull request #8489 from mvdbeek/pyuwsgi
Update requirements and use pyuwsgi
2019-08-29 14:41:11 -04:00
Martin Cech a486090686 update autoamtion rules 2019-08-29 13:58:45 -04:00
Martin Cech 9145a6bac5 revise roadmap 2019-08-29 13:58:32 -04:00
Martin Cech 2965edb896 drop status/review and make it a default 2019-08-29 13:52:50 -04:00
Martin Cech ef187ad37e restyle docstring for consistency 2019-08-29 13:30:27 -04:00
Martin Cech 2d6cb9c5e9 clarify when to use what workflow invoke endpoint 2019-08-29 13:30:04 -04:00
Anthony Bretaudeau 32a2e7caad Revert "remove the extra checks"
This reverts commit a3922cf91f.
2019-08-29 18:02:46 +02:00
Martin Cech a3922cf91f remove the extra checks
I made a mistake while testing, this does not cause problems
2019-08-29 11:21:15 -04:00
Martin Cech 8df1cc7e31 remove wrong title 2019-08-29 11:16:57 -04:00
Daniel Blankenberg 1d92625f2d Remove extraneous debug statement. 2019-08-29 09:30:53 -04:00
Daniel Blankenberg c8219b96da Update geda.xsd with allow_cors. 2019-08-29 09:27:31 -04:00
Daniel Blankenberg ad4734e0fc Merge branch 'dev' of https://github.com/galaxyproject/galaxy into geda-cors 2019-08-29 09:15:53 -04:00
Anthony Bretaudeau ef95d6678e disable sorting on tags (doesn't make sense) 2019-08-29 12:39:38 +02:00
Anthony Bretaudeau 37d49462df fix tags display when modifying/sorting 2019-08-29 12:39:25 +02:00
Anthony Bretaudeau c0d6189f60 check we only try to split strings 2019-08-29 10:02:16 +02:00
Nicola Soranzo dfa732aff2 Merge pull request #8532 from martenson/devmerge
merge in 19.05
2019-08-29 02:11:36 +01:00
Nicola Soranzo 0d7133349e Improve and refactor process group handling in the local job runners.
Fix traceback seen in

https://jenkins.galaxyproject.org/job/docker-api/16801/testReport/junit/test.api.test_datasets/DatasetsApiTestCase/test_show/
2019-08-29 00:23:00 +01:00
Daniel Blankenberg 58da2380f5 Make InteractiveTools compatible with letsencrypt certificates. 2019-08-28 17:39:27 -04:00
Sergey Golitsynskiy 2270dace26 Run make config-rebuild to reflect latest edits 2019-08-28 15:49:09 -04:00
Sergey Golitsynskiy b451974d1b Surround true/false default str values w/quotes
To make consistent across file + not to confuse w/boolean values.
2019-08-28 15:27:56 -04:00
Sergey Golitsynskiy 1b08bcf5f4 Move config_manage unit tests to config/
config_manage.py was moved from webapps/ to config/. This edit makes the
unit tests location consistent with the module they test.
2019-08-28 15:27:56 -04:00
Sergey Golitsynskiy 59f74e3d1a Reverse previous edit
Addresses this: https://github.com/galaxyproject/galaxy/pull/8475#discussion_r315966257
(None is the default)
2019-08-28 15:27:56 -04:00