opensource/galaxy
3
0
Fork 0
mirror of https://github.com/galaxyproject/galaxy.git synced 2026-09-24 16:30:27 +08:00
Code Issues Packages Projects Releases Wiki Activity

Change empty href tags to javascript:void(0)

Browse Source
This commit is contained in:
will
2019-08-07 12:56:55 -04:00
parent 591e9d85fd
commit e1da4360f7
5 changed files with 10 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
client/galaxy/scripts/legacy/grid/grid-template.js
+2 -2
View File
@@ -387,7 +387,7 @@ export default {
// show advanced search link in standard display
if (show_advanced_search_link) {
tmpl += '<a href="" class="advanced-search-toggle">Advanced Search</a>';
tmpl += '<a href="javascript:void(0)" class="advanced-search-toggle">Advanced Search</a>';
}
// finalize standard search display
@@ -396,7 +396,7 @@ export default {
//
// advanced search
//
tmpl += `<div id="advanced-search" style="display: ${advanced_search_display}; margin-top: 5px; border: 1px solid #ccc;"><table><tr><td style="text-align: left" colspan="100"><a href="" class="advanced-search-toggle">Close Advanced Search</a></td></tr>`;
tmpl += `<div id="advanced-search" style="display: ${advanced_search_display}; margin-top: 5px; border: 1px solid #ccc;"><table><tr><td style="text-align: left" colspan="100"><a href="javascript:void(0)" class="advanced-search-toggle">Close Advanced Search</a></td></tr>`;
// add advanced filters
for (let column of options.columns) {
client/galaxy/scripts/mvc/grid/grid-template.js
+2 -2
View File
@@ -403,7 +403,7 @@ export default {
// show advanced search link in standard display
if (show_advanced_search_link) {
tmpl += '<a href="" class="advanced-search-toggle">Advanced Search</a>';
tmpl += '<a href="javascript:void(0)" class="advanced-search-toggle">Advanced Search</a>';
}
// finalize standard search display
@@ -412,7 +412,7 @@ export default {
//
// advanced search
//
tmpl += `<div id="advanced-search" style="display: ${advanced_search_display}; margin-top: 5px;"><table><tr><td style="text-align: left" colspan="100"><a href="" class="advanced-search-toggle">Close Advanced Search</a></td></tr>`;
tmpl += `<div id="advanced-search" style="display: ${advanced_search_display}; margin-top: 5px;"><table><tr><td style="text-align: left" colspan="100"><a href="javascript:void(0)" class="advanced-search-toggle">Close Advanced Search</a></td></tr>`;
// add advanced filters
for (const column of options.columns) {
client/galaxy/scripts/mvc/library/library-dataset-view.js
+3 -3
View File
@@ -671,7 +671,7 @@ var LibraryDatasetView = Backbone.View.extend({
<% if (item.get("is_unrestricted")) { %>
<div>
This dataset is unrestricted so everybody with the link can access it.
Just share <span class="copy-link-to-clipboard"><a href=""a>this page</a></span>.
Just share <span class="copy-link-to-clipboard"><a href="javascript:void(0)">this page</a></span>.
</div>
<% } %>
@@ -1159,12 +1159,12 @@ var LibraryDatasetView = Backbone.View.extend({
<% if (!item.get("is_unrestricted")) { %>
<p>
You can <span class="remove-restrictions">
<a href="">remove all access restrictions</a></span> on this dataset.
<a href="javascript:void(0)">remove all access restrictions</a></span> on this dataset.
</p>
<% } else { %>
<p>
You can <span class="make-private">
<a href="">make this dataset private</a></span> to you.</p>
<a href="javascript:void(0)">make this dataset private</a></span> to you.</p>
<% } %>
<h4>Roles that can access the dataset</h4>
<div id="access_perm" class="access_perm roles-selection"></div>
client/galaxy/scripts/viz/trackster.js
+2 -2
View File
@@ -197,7 +197,7 @@ export class TracksterUI extends Backbone.Model {
.appendTo(new_bookmark);
//position_link
$("<a href=''/>")
$("<a href='javascript:void(0)'/>")
.text(position)
.appendTo(position_div)
.click(() => {
@@ -223,7 +223,7 @@ export class TracksterUI extends Backbone.Model {
});
// delete_icon
$("<a href=''/>")
$("<a href='javascript:void(0)'/>")
.addClass("icon-button delete")
.appendTo(delete_icon_container);
client/galaxy/style/scss/toastr.scss
+1 -1
View File
@@ -76,7 +76,7 @@ $orange: #f89406;
/*Additional properties for button version
iOS requires the button element instead of an anchor tag.
If you want the anchor version, it requires `href="javascript:void(0)"`.*/
If you want the anchor version, it requires `href="#"`.*/
button.toast-close-button {
padding: 0;
cursor: pointer;