From e1da4360f78e9b4db023cd12eae04b482096f2ed Mon Sep 17 00:00:00 2001
From: will <theappdev@protonmail.com>
Date: Wed, 17 Jul 2019 16:50:27 -0400
Subject: [PATCH] Change empty href tags to javascript:void(0)

---
 client/galaxy/scripts/legacy/grid/grid-template.js        | 4 ++--
 client/galaxy/scripts/mvc/grid/grid-template.js           | 4 ++--
 client/galaxy/scripts/mvc/library/library-dataset-view.js | 6 +++---
 client/galaxy/scripts/viz/trackster.js                    | 4 ++--
 client/galaxy/style/scss/toastr.scss                      | 2 +-
 5 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/client/galaxy/scripts/legacy/grid/grid-template.js b/client/galaxy/scripts/legacy/grid/grid-template.js
index e5fda7d790f..ea12c2ab369 100644
--- a/client/galaxy/scripts/legacy/grid/grid-template.js
+++ b/client/galaxy/scripts/legacy/grid/grid-template.js
@@ -387,7 +387,7 @@ export default {
 
         // show advanced search link in standard display
         if (show_advanced_search_link) {
-            tmpl += '<a href="" class="advanced-search-toggle">Advanced Search</a>';
+            tmpl += '<a href="javascript:void(0)" class="advanced-search-toggle">Advanced Search</a>';
         }
 
         // finalize standard search display
@@ -396,7 +396,7 @@ export default {
         //
         // advanced search
         //
-        tmpl += `<div id="advanced-search" style="display: ${advanced_search_display}; margin-top: 5px; border: 1px solid #ccc;"><table><tr><td style="text-align: left" colspan="100"><a href="" class="advanced-search-toggle">Close Advanced Search</a></td></tr>`;
+        tmpl += `<div id="advanced-search" style="display: ${advanced_search_display}; margin-top: 5px; border: 1px solid #ccc;"><table><tr><td style="text-align: left" colspan="100"><a href="javascript:void(0)" class="advanced-search-toggle">Close Advanced Search</a></td></tr>`;
 
         // add advanced filters
         for (let column of options.columns) {
diff --git a/client/galaxy/scripts/mvc/grid/grid-template.js b/client/galaxy/scripts/mvc/grid/grid-template.js
index a9975babc93..6852d68d8dc 100644
--- a/client/galaxy/scripts/mvc/grid/grid-template.js
+++ b/client/galaxy/scripts/mvc/grid/grid-template.js
@@ -403,7 +403,7 @@ export default {
 
         // show advanced search link in standard display
         if (show_advanced_search_link) {
-            tmpl += '<a href="" class="advanced-search-toggle">Advanced Search</a>';
+            tmpl += '<a href="javascript:void(0)" class="advanced-search-toggle">Advanced Search</a>';
         }
 
         // finalize standard search display
@@ -412,7 +412,7 @@ export default {
         //
         // advanced search
         //
-        tmpl += `<div id="advanced-search" style="display: ${advanced_search_display}; margin-top: 5px;"><table><tr><td style="text-align: left" colspan="100"><a href="" class="advanced-search-toggle">Close Advanced Search</a></td></tr>`;
+        tmpl += `<div id="advanced-search" style="display: ${advanced_search_display}; margin-top: 5px;"><table><tr><td style="text-align: left" colspan="100"><a href="javascript:void(0)" class="advanced-search-toggle">Close Advanced Search</a></td></tr>`;
 
         // add advanced filters
         for (const column of options.columns) {
diff --git a/client/galaxy/scripts/mvc/library/library-dataset-view.js b/client/galaxy/scripts/mvc/library/library-dataset-view.js
index 8137376b77f..d6173b306e7 100644
--- a/client/galaxy/scripts/mvc/library/library-dataset-view.js
+++ b/client/galaxy/scripts/mvc/library/library-dataset-view.js
@@ -671,7 +671,7 @@ var LibraryDatasetView = Backbone.View.extend({
                 <% if (item.get("is_unrestricted")) { %>
                     <div>
                         This dataset is unrestricted so everybody with the link can access it.
-                        Just share <span class="copy-link-to-clipboard"><a href=""a>this page</a></span>.
+                        Just share <span class="copy-link-to-clipboard"><a href="javascript:void(0)">this page</a></span>.
                     </div>
                 <% } %>
 
@@ -1159,12 +1159,12 @@ var LibraryDatasetView = Backbone.View.extend({
                     <% if (!item.get("is_unrestricted")) { %>
                         <p>
                             You can <span class="remove-restrictions">
-                            <a href="">remove all access restrictions</a></span> on this dataset.
+                            <a href="javascript:void(0)">remove all access restrictions</a></span> on this dataset.
                         </p>
                     <% } else { %>
                         <p>
                             You can <span class="make-private">
-                            <a href="">make this dataset private</a></span> to you.</p>
+                            <a href="javascript:void(0)">make this dataset private</a></span> to you.</p>
                     <% } %>
                     <h4>Roles that can access the dataset</h4>
                     <div id="access_perm" class="access_perm roles-selection"></div>
diff --git a/client/galaxy/scripts/viz/trackster.js b/client/galaxy/scripts/viz/trackster.js
index 66891e4b0f8..fb79cd0313f 100644
--- a/client/galaxy/scripts/viz/trackster.js
+++ b/client/galaxy/scripts/viz/trackster.js
@@ -197,7 +197,7 @@ export class TracksterUI extends Backbone.Model {
             .appendTo(new_bookmark);
 
         //position_link
-        $("<a href=''/>")
+        $("<a href='javascript:void(0)'/>")
             .text(position)
             .appendTo(position_div)
             .click(() => {
@@ -223,7 +223,7 @@ export class TracksterUI extends Backbone.Model {
                 });
 
             // delete_icon
-            $("<a href=''/>")
+            $("<a href='javascript:void(0)'/>")
                 .addClass("icon-button delete")
                 .appendTo(delete_icon_container);
 
diff --git a/client/galaxy/style/scss/toastr.scss b/client/galaxy/style/scss/toastr.scss
index fd6fe3c0213..1364201a143 100644
--- a/client/galaxy/style/scss/toastr.scss
+++ b/client/galaxy/style/scss/toastr.scss
@@ -76,7 +76,7 @@ $orange: #f89406;
 
 /*Additional properties for button version
  iOS requires the button element instead of an anchor tag.
- If you want the anchor version, it requires `href="javascript:void(0)"`.*/
+ If you want the anchor version, it requires `href="#"`.*/
 button.toast-close-button {
     padding: 0;
     cursor: pointer;