Use default function params, dot notation for attribute access. Fix module comment.

This commit is contained in:
Dannon Baker
2019-05-24 07:57:24 -04:00
parent b80cf2744b
commit 8efaf565a0
2 changed files with 10 additions and 12 deletions
@@ -5,16 +5,15 @@ import $ from "jquery";
import Vue from "vue";
import JobMetrics from "./JobMetrics.vue";
export const mountJobMetrics = propsData => {
export const mountJobMetrics = (propsData = {}) => {
$(".job-metrics").each((index, el) => {
const jobId = $(el).attr("job_id");
const datasetId = $(el).attr("dataset_id");
const datasetType = $(el).attr("dataset_type") || "hda";
const component = Vue.extend(JobMetrics);
propsData = propsData || {};
propsData["jobId"] = jobId;
propsData["datasetId"] = datasetId;
propsData["datasetType"] = datasetType;
propsData.jobId = jobId;
propsData.datasetId = datasetId;
propsData.datasetType = datasetType;
return new component({ propsData: propsData }).$mount(el);
});
};
@@ -1,20 +1,19 @@
/**
* Endpoint for mounting job metrics from non-Vue environment.
* Endpoint for mounting job parameters from non-Vue environment.
*/
import $ from "jquery";
import Vue from "vue";
import JobParameters from "./JobParameters.vue";
export const mountJobParameters = propsData => {
export const mountJobParameters = (propsData = {}) => {
$(".job-parameters").each((index, el) => {
const component = Vue.extend(JobParameters);
const jobId = $(el).attr("job_id");
const datasetId = $(el).attr("dataset_id");
const datasetType = $(el).attr("dataset_type") || "hda";
propsData = propsData || {};
propsData["jobId"] = jobId;
propsData["datasetId"] = datasetId;
propsData["datasetType"] = datasetType;
const component = Vue.extend(JobParameters);
propsData.jobId = jobId;
propsData.datasetId = datasetId;
propsData.datasetType = datasetType;
return new component({ propsData: propsData }).$mount(el);
});
};