From 8efaf565a04cd05a382664454c3bf964fdaf16ac Mon Sep 17 00:00:00 2001
From: Dannon Baker <dannon.baker@gmail.com>
Date: Fri, 24 May 2019 07:57:24 -0400
Subject: [PATCH] Use default function params, dot notation for attribute
 access.  Fix module comment.

---
 .../galaxy/scripts/components/JobMetrics/mount.js   |  9 ++++-----
 .../scripts/components/JobParameters/mount.js       | 13 ++++++-------
 2 files changed, 10 insertions(+), 12 deletions(-)

diff --git a/client/galaxy/scripts/components/JobMetrics/mount.js b/client/galaxy/scripts/components/JobMetrics/mount.js
index e9fa95b350a..52206d987fe 100644
--- a/client/galaxy/scripts/components/JobMetrics/mount.js
+++ b/client/galaxy/scripts/components/JobMetrics/mount.js
@@ -5,16 +5,15 @@ import $ from "jquery";
 import Vue from "vue";
 import JobMetrics from "./JobMetrics.vue";
 
-export const mountJobMetrics = propsData => {
+export const mountJobMetrics = (propsData = {}) => {
     $(".job-metrics").each((index, el) => {
         const jobId = $(el).attr("job_id");
         const datasetId = $(el).attr("dataset_id");
         const datasetType = $(el).attr("dataset_type") || "hda";
         const component = Vue.extend(JobMetrics);
-        propsData = propsData || {};
-        propsData["jobId"] = jobId;
-        propsData["datasetId"] = datasetId;
-        propsData["datasetType"] = datasetType;
+        propsData.jobId = jobId;
+        propsData.datasetId = datasetId;
+        propsData.datasetType = datasetType;
         return new component({ propsData: propsData }).$mount(el);
     });
 };
diff --git a/client/galaxy/scripts/components/JobParameters/mount.js b/client/galaxy/scripts/components/JobParameters/mount.js
index 6c49609db92..4e7e9f67fb6 100644
--- a/client/galaxy/scripts/components/JobParameters/mount.js
+++ b/client/galaxy/scripts/components/JobParameters/mount.js
@@ -1,20 +1,19 @@
 /**
- * Endpoint for mounting job metrics from non-Vue environment.
+ * Endpoint for mounting job parameters from non-Vue environment.
  */
 import $ from "jquery";
 import Vue from "vue";
 import JobParameters from "./JobParameters.vue";
 
-export const mountJobParameters = propsData => {
+export const mountJobParameters = (propsData = {}) => {
     $(".job-parameters").each((index, el) => {
-        const component = Vue.extend(JobParameters);
         const jobId = $(el).attr("job_id");
         const datasetId = $(el).attr("dataset_id");
         const datasetType = $(el).attr("dataset_type") || "hda";
-        propsData = propsData || {};
-        propsData["jobId"] = jobId;
-        propsData["datasetId"] = datasetId;
-        propsData["datasetType"] = datasetType;
+        const component = Vue.extend(JobParameters);
+        propsData.jobId = jobId;
+        propsData.datasetId = datasetId;
+        propsData.datasetType = datasetType;
         return new component({ propsData: propsData }).$mount(el);
     });
 };