Merge pull request #6388 from qiagu/data_column_1

change a file read to use with statement
2026-09-24 16:30:27 +08:00 · 2018-06-22 16:50:26 -04:00
parent d64bae6458 6815ad69f4
commit 704f956306
1 changed files with 2 additions and 1 deletions
@@ -1162,7 +1162,8 @@ class ColumnListParameter(SelectToolParameter):
        if self.usecolnames:  # read first row - assume is a header with metadata useful for making good choices
            dataset = other_values.get(self.data_ref, None)
            try:
-                head = open(dataset.get_file_name(), 'r').readline()
+                with open(dataset.get_file_name(), 'r') as f:
+                    head = f.readline()
                cnames = head.rstrip().split('\t')
                column_list = [('%d' % (i + 1), 'c%d: %s' % (i + 1, x)) for i, x in enumerate(cnames)]
                if self.numerical:  # If numerical was requested, filter columns based on metadata