From 6815ad69f4e5e7cf5ce8456d60a2325a682e52f6 Mon Sep 17 00:00:00 2001 From: Qiang Gu Date: Fri, 22 Jun 2018 12:35:36 -0700 Subject: [PATCH] change a file read to use with statement --- lib/galaxy/tools/parameters/basic.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/galaxy/tools/parameters/basic.py b/lib/galaxy/tools/parameters/basic.py index 33d78e24288..3e23c5fe5b9 100644 --- a/lib/galaxy/tools/parameters/basic.py +++ b/lib/galaxy/tools/parameters/basic.py @@ -1162,7 +1162,8 @@ class ColumnListParameter(SelectToolParameter): if self.usecolnames: # read first row - assume is a header with metadata useful for making good choices dataset = other_values.get(self.data_ref, None) try: - head = open(dataset.get_file_name(), 'r').readline() + with open(dataset.get_file_name(), 'r') as f: + head = f.readline() cnames = head.rstrip().split('\t') column_list = [('%d' % (i + 1), 'c%d: %s' % (i + 1, x)) for i, x in enumerate(cnames)] if self.numerical: # If numerical was requested, filter columns based on metadata