Fix ISC004 errors reported by ruff 0.16.0

This commit is contained in:
Nicola Soranzo
2026-07-25 17:36:10 +01:00
parent 424b1024de
commit 537f447a06
2 changed files with 5 additions and 7 deletions
@@ -38,7 +38,7 @@ VALID_XML_VALIDATORS = [
"""<validator type="dataset_metadata_equal" metadata_name="foobar" value="moocow" />""",
"""<validator type="dataset_metadata_equal" metadata_name="foobar" value_json="null" />""",
"""<validator type="dataset_metadata_in_range" metadata_name="foobar" min="4.5" max="7.8" />""",
"""<validator type="dataset_metadata_in_range" metadata_name="foobar" min="4.5" max="7.8" include_min="true" />""",
"""<validator type="dataset_metadata_in_range" metadata_name="foobar" min="4.5" max="7.8" exclude_min="true" />""",
"""<validator type="dataset_metadata_in_data_table" metadata_name="foobar" metadata_column="3" table_name="mycooltable" />""",
"""<validator type="dataset_metadata_not_in_data_table" metadata_name="foobar" metadata_column="3" table_name="mycooltable" />""",
"""<validator type="value_in_data_table" metadata_column="3" table_name="mycooltable" />""",
@@ -61,8 +61,8 @@ INVALID_XML_VALIDATORS = [
"""<validator type="dataset_metadata_equal" />""",
"""<validator type="dataset_metadata_equal" metadaata_name="foobar" />""",
"""<validator type="dataset_metadata_equal" metadaata_name="foobar" value_json="undefined" />""",
"""<validator type="dataset_metadata_in_range" metadata_name="foobar" min="4.5" max="7.8" include_min="notabool" />"""
"""<validator type="dataset_metadata_in_range" min="4.5" max="7.8" />"""
"""<validator type="dataset_metadata_in_range" metadata_name="foobar" min="4.5" max="7.8" exclude_min="notabool" />""",
"""<validator type="dataset_metadata_in_range" min="4.5" max="7.8" />""",
"""<validator type="dataset_metadata_in_data_table" metadata_name="foobar" metadata_column="3" />""",
"""<validator type="dataset_metadata_in_data_table" metadata_column="3" table_name="mycooltable" />""",
"""<validator type="dataset_metadata_not_in_data_table" metadata_name="foobar" metadata_column="3" />""",
+2 -4
View File
@@ -1270,8 +1270,7 @@ def test_citations_legacy_doi_prefix(lint_ctx):
tool_source = get_xml_tool_source(CITATIONS_LEGACY_DOI_PREFIX)
run_lint_module(lint_ctx, citations, tool_source)
assert lint_ctx.warn_messages == [
"Citation 'doi:10.1186/1471-2105-11-485' uses the legacy 'doi:' prefix; "
"use the bare DOI '10.1186/1471-2105-11-485' instead."
"Citation 'doi:10.1186/1471-2105-11-485' uses the legacy 'doi:' prefix; use the bare DOI '10.1186/1471-2105-11-485' instead."
]
assert not lint_ctx.error_messages
@@ -1288,8 +1287,7 @@ def test_citations_legacy_doi_prefix_error_on_modern_profile(lint_ctx):
tool_source = get_xml_tool_source(CITATIONS_LEGACY_DOI_PREFIX_MODERN)
run_lint_module(lint_ctx, citations, tool_source)
assert lint_ctx.error_messages == [
"Citation 'doi:10.1186/1471-2105-11-485' uses the legacy 'doi:' prefix; "
"use the bare DOI '10.1186/1471-2105-11-485' instead."
"Citation 'doi:10.1186/1471-2105-11-485' uses the legacy 'doi:' prefix; use the bare DOI '10.1186/1471-2105-11-485' instead."
]
assert not lint_ctx.warn_messages