Remove unused attribute from grid config, fix failing test

This commit is contained in:
guerler
2023-11-15 17:37:43 +03:00
parent 4788f8fc2d
commit 1abea75fb9
5 changed files with 3 additions and 5 deletions
+1 -1
View File
@@ -21,7 +21,7 @@ describe("GridList", () => {
id: "visualizations",
});
const findInput = wrapper.find("[data-description='filter text input']");
expect(findInput.attributes().placeholder).toBe("search visualization");
expect(findInput.attributes().placeholder).toBe("search visualizations");
expect(wrapper.find(".loading-message").text()).toBe("Loading...");
const findAction = wrapper.find("[data-description='grid action create']");
expect(findAction.text()).toBe("Create");
+1 -1
View File
@@ -171,7 +171,7 @@ watch(operationMessage, () => {
<FilterMenu
class="py-2"
:name="gridConfig.plural"
:placeholder="`search ${gridConfig.item}`"
:placeholder="`search ${gridConfig.plural.toLowerCase()}`"
:filter-class="gridConfig.filtering"
:filter-text.sync="filterText"
:loading="loading"
+1 -1
View File
@@ -10,6 +10,7 @@ type Field = FieldKey | FieldOperations;
interface FieldKey {
key: string;
disabled?: boolean;
type: string;
handler?: FieldKeyHandler;
}
@@ -32,7 +33,6 @@ export interface Config {
fields: Array<Field>;
filtering: Filtering<any>;
getData: (offset: number, limit: number, search: string, sort_by: string, sort_desc: boolean) => Promise<any>;
item: string;
plural: string;
sortBy: string;
sortKeys: Array<string>;
@@ -237,7 +237,6 @@ export const VisualizationsGrid = {
fields: fields,
filtering: new Filtering(validFilters, undefined, false, false),
getData: getData,
item: "visualization",
plural: "Visualizations",
sortBy: "update_time",
sortDesc: true,
@@ -88,7 +88,6 @@ export const VisualizationsPublishedGrid = {
fields: fields,
filtering: new Filtering(validFilters, undefined, false, false),
getData: getData,
item: "visualization",
plural: "Visualizations",
sortBy: "update_time",
sortDesc: true,