From 1abea75fb90bfecaa160d548f50ef0a25894aef7 Mon Sep 17 00:00:00 2001
From: guerler <aysam.guerler@gmail.com>
Date: Thu, 9 Nov 2023 09:46:44 +0300
Subject: [PATCH] Remove unused attribute from grid config, fix failing test

---
 client/src/components/Grid/GridList.test.js                   | 2 +-
 client/src/components/Grid/GridList.vue                       | 2 +-
 client/src/components/Grid/configs/types.ts                   | 2 +-
 client/src/components/Grid/configs/visualizations.ts          | 1 -
 client/src/components/Grid/configs/visualizationsPublished.ts | 1 -
 5 files changed, 3 insertions(+), 5 deletions(-)

diff --git a/client/src/components/Grid/GridList.test.js b/client/src/components/Grid/GridList.test.js
index 4b70d7528d6..a1ac0727abd 100644
--- a/client/src/components/Grid/GridList.test.js
+++ b/client/src/components/Grid/GridList.test.js
@@ -21,7 +21,7 @@ describe("GridList", () => {
             id: "visualizations",
         });
         const findInput = wrapper.find("[data-description='filter text input']");
-        expect(findInput.attributes().placeholder).toBe("search visualization");
+        expect(findInput.attributes().placeholder).toBe("search visualizations");
         expect(wrapper.find(".loading-message").text()).toBe("Loading...");
         const findAction = wrapper.find("[data-description='grid action create']");
         expect(findAction.text()).toBe("Create");
diff --git a/client/src/components/Grid/GridList.vue b/client/src/components/Grid/GridList.vue
index 25106307c19..e675db6de23 100644
--- a/client/src/components/Grid/GridList.vue
+++ b/client/src/components/Grid/GridList.vue
@@ -171,7 +171,7 @@ watch(operationMessage, () => {
                 <FilterMenu
                     class="py-2"
                     :name="gridConfig.plural"
-                    :placeholder="`search ${gridConfig.item}`"
+                    :placeholder="`search ${gridConfig.plural.toLowerCase()}`"
                     :filter-class="gridConfig.filtering"
                     :filter-text.sync="filterText"
                     :loading="loading"
diff --git a/client/src/components/Grid/configs/types.ts b/client/src/components/Grid/configs/types.ts
index c2801be2684..7ae3073448b 100644
--- a/client/src/components/Grid/configs/types.ts
+++ b/client/src/components/Grid/configs/types.ts
@@ -10,6 +10,7 @@ type Field = FieldKey | FieldOperations;
 
 interface FieldKey {
     key: string;
+    disabled?: boolean;
     type: string;
     handler?: FieldKeyHandler;
 }
@@ -32,7 +33,6 @@ export interface Config {
     fields: Array<Field>;
     filtering: Filtering<any>;
     getData: (offset: number, limit: number, search: string, sort_by: string, sort_desc: boolean) => Promise<any>;
-    item: string;
     plural: string;
     sortBy: string;
     sortKeys: Array<string>;
diff --git a/client/src/components/Grid/configs/visualizations.ts b/client/src/components/Grid/configs/visualizations.ts
index 6f66870ff46..30458c08f63 100644
--- a/client/src/components/Grid/configs/visualizations.ts
+++ b/client/src/components/Grid/configs/visualizations.ts
@@ -237,7 +237,6 @@ export const VisualizationsGrid = {
     fields: fields,
     filtering: new Filtering(validFilters, undefined, false, false),
     getData: getData,
-    item: "visualization",
     plural: "Visualizations",
     sortBy: "update_time",
     sortDesc: true,
diff --git a/client/src/components/Grid/configs/visualizationsPublished.ts b/client/src/components/Grid/configs/visualizationsPublished.ts
index 90e3c2f5599..83b78e943e1 100644
--- a/client/src/components/Grid/configs/visualizationsPublished.ts
+++ b/client/src/components/Grid/configs/visualizationsPublished.ts
@@ -88,7 +88,6 @@ export const VisualizationsPublishedGrid = {
     fields: fields,
     filtering: new Filtering(validFilters, undefined, false, false),
     getData: getData,
-    item: "visualization",
     plural: "Visualizations",
     sortBy: "update_time",
     sortDesc: true,