Commit Graph
4800 Commits
Author SHA1 Message Date
Asher a08f7b8fb9 fix: catch missing output with reconnecting PTY (#9094)
I forgot that waiting on the cond releases the lock so it was possible
to get pty output after writing the buffer but before adding the pty to
the map.  To fix, add the pty to the map while under the same lock where
we read from the buffer.

The rest does not need to be behind the lock so I moved it out of
doAttach, and that also means we no longer need
waitForStateOrContextLocked.

Also, this can hit a logger error saying the attach failed which fails
the tests however it is not that the attach failed, just that the
process already ran and exited, so when the process exits do not
set an error, instead for now assume this is an expected close.
2023-08-14 15:54:23 -08:00
Steven Masley 6ea82c5ae7 chore: add oidc sequence diagram image to docs (#9089)
* chore: add oidc sequence diagram image to docs

* Change wording

* Direct link to the sequence diagram
2023-08-14 17:35:43 -05:00
Steven Masley 25ce30df36 feat: add azure oidc PKI auth instead of client secret (#9054)
* feat: add azure oidc PKI auth instead of client secret
* add client cert and key as deployment options
* Custom token refresher to handle pki auth
2023-08-14 17:33:13 -05:00
dependabot[bot] 4e36f91ea2 chore: bump the golang-x group with 1 update (#9083)
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-08-14 16:59:28 -05:00
Dean Sheather 47b8bf6585 feat: update workspace deadline when template policy changes (#8964) 2023-08-14 21:16:47 +00:00
Asher 37f9d4b783 feat: add --header-command flag (#9059)
This allows specifying a command to run that can output headers for
cases where users require dynamic headers (like to authenticate to their
VPN).

The primary use case is to add this flag in SSH configs created by the
VS Code plugin, although maybe config-ssh should do the same.
2023-08-14 12:12:17 -08:00
Asher b993cab49a fix: use screen for reconnecting terminal sessions on Linux if available (#8640)
* Add screen backend for reconnecting ptys

The screen portion is a port from wsep.  There is an interface that lets
you choose between screen and the previous method.  By default it will
choose screen if it is installed but this can be overidden (mostly for
tests).

The tests use a scanner instead of a reader now because the reader will
loop infinitely at the end of a stream.

Replace /bin/bash with bash since bash is not always in /bin.

* Remove connection_id from reconnecting PTY logger

This serves multiple connections so it makes no sense to scope it to a
single connection.

Also lets us use "connection_id" when logging write errors instead of
"other_conn_id".

* Use PATH to test buffered reconnecting pty
2023-08-14 11:19:13 -08:00
Muhammad Atif Ali 878315dcaf fix: fix CI concurrency (#9088) 2023-08-14 18:48:14 +03:00
Cian Johnston ef9d84c723 fix(scaletest): cleanup: attempt to cancel in-progress jobs (#9080)
This change modifies the cleanup behaviour to make a best-effort attempt to cancel the in-progress scaletest workspace build jobs before deleting them.
2023-08-14 12:43:45 +01:00
Cian Johnston 72575cc462 chore(docs): fix indentation in install/kubernetes.md (#8906)
* chore(docs): fix indentation in install/kubernetes.md

* fmt
2023-08-14 09:41:00 +01:00
Kyle Carberry 594b9797dd fix: change dashboard route /settings/deployment to /deployment (#9070)
It felt unnecessary to nest this.
2023-08-13 16:58:04 +00:00
Kyle Carberry 0d01d022f7 fix: remove unnecessary newlines from the end of cli output (#9068)
`Infof` already adds a newline, so we don't need to as well!
2023-08-13 11:48:11 -05:00
Kyle Carberry 9a13814b46 fix: remove duplication from language of query param error (#9069) 2023-08-13 11:47:44 -05:00
Muhammad Atif Ali 1629a2a4ee chore: sort DERP regions by latencies on workspace page (#9063) 2023-08-13 18:52:14 +03:00
Kyle Carberry abe17b1164 chore: update speakeasy to fix stty path bug on nixos (#9022)
Prompts failed on NixOS due to /bin/stty being hardcoded for turning
off echo in the terminal prompt. See:
https://github.com/bgentry/speakeasy/commit/760eaf8b681647364e7a400b856e0921248728a5
2023-08-13 15:10:58 +00:00
Muhammad Atif Ali 984f7ce045 fix: update BUILD condition in pr-deploy.yaml (#9064)
This makes the build condition more understandable and fixes an issue where we could not deploy a new PR as the build condition was constantly evaluating false.
2023-08-13 11:18:17 +03:00
Eric Paulsen 6af6e85fe3 docs: add coder login to CI docs (#9038)
* docs: add coder login to CI docs

* add CODER_URL

* add --url flag to login cmd
2023-08-11 20:55:55 +00:00
Eric Paulsen d2a9049fd7 docs: add offline docs for JetBrains Gateway (#9039) 2023-08-11 14:56:35 -05:00
Steven Masley 320de18be7 fix: correct github oauth2 callback url (#9052)
* fix: correct github oauth2 callback url
2023-08-11 09:25:05 -05:00
Steven Masley 47ca84be47 chore: return queried user on failure to help debug (#9051) 2023-08-11 14:02:19 +00:00
Steven MasleyandKyle Carberry 1c7bd57da8 chore: clarify region selection behavior (#9021)
* chore: clarify region selection behavior

* Update site/src/components/Navbar/NavbarView.tsx

Co-authored-by: Kyle Carberry <kyle@coder.com>

---------

Co-authored-by: Kyle Carberry <kyle@coder.com>
2023-08-11 08:26:01 -05:00
Muhammad Atif Ali 59fd4e86c9 ci: remove deleting comments section from pr-cleanup.yaml (#9047) 2023-08-11 15:43:37 +03:00
Muhammad Atif Ali a13c8c88d5 fix: prevent unrequested PR deployments (#9049) 2023-08-11 12:32:42 +00:00
Muhammad Atif Ali 7fb9197860 ci: do not run deploy-pr on main (#9046) 2023-08-11 10:54:55 +00:00
Muhammad Atif Ali 114ad4624e ci: upgrade pr deployments workflow (#8924) 2023-08-11 13:49:23 +03:00
Muhammad Atif Ali 4d8152d543 ci: run tests intelligently based on changes between consecutive commits (#9017) 2023-08-11 13:48:24 +03:00
Steven Masley 40f3fc3a1c feat: allow creating manual oidc/github based users (#9000)
* feat: allow creating manual oidc/github based users
* Add unit test for oidc and no login type create
2023-08-10 20:04:35 -05:00
ffaisandEric 6fd5344d0a feat: add support for NodePort service type in Helm chart (#8993)
* add support for NodePort service type in Helm chart

* fix nodeport values

* formatting & make update-golden-files

* update-golden-files

---------

Co-authored-by: Eric <ericpaulsen@coder.com>
2023-08-10 20:57:59 -04:00
timquinlan a2d64c08c1 docs: update helm values.yaml code snippet, put quote around boolean value (#9026)
* updated helm values.yaml code snippet, put quote around boolean values and added comments showing that CODER_OAUTH2_GITHUB_ALLOW_EVERYONE and CODER_OAUTH2_GITHUB_ALLOW_EVERYONE are mutually exclusive

* Update auth.md

spotted and fixed minor typo
2023-08-10 17:06:10 -04:00
Dean Sheather d2f22b063a fix: move STUN servers into their own regions (#9030) 2023-08-11 05:04:17 +10:00
Dean Sheather 25c6832772 chore: update tailscale (#9027) 2023-08-11 04:26:28 +10:00
Bruno Quaresma 175aed1685 feat(site): add tooltip showing the error in the failure badge (#9029) 2023-08-10 15:23:31 -03:00
Bruno Quaresma 83061bef7e refactor(site): add minor improvements to the port button (#9028) 2023-08-10 14:47:56 -03:00
Ben Potter 76ad116e12 docs: write 2.0.2 changelog (#9025)
* mention provisioner authentication

* add changelog for 2.1.0

* rename to 2.0.2
v2.0.2
2023-08-10 17:02:02 +00:00
Marcin Tojek 967a4b0c7c feat: add example template using rich parameters (#9020) 2023-08-10 16:36:18 +02:00
Muhammad Atif Ali 091c00bd70 fix: make preferred region the first in list (#9014) 2023-08-10 12:59:39 +00:00
Bruno Quaresma 834ce41013 refactor(site): add default background color to html and body (#9009) 2023-08-10 09:41:35 -03:00
Marcin Tojek 9d9814c6b0 refactor(cli): adjust parameter resolver (#9019) 2023-08-10 12:08:00 +02:00
Spike Curtis 21af020386 feat: add external provisioner daemon helm chart (#8939)
* Refactor helm to extract common templates to libcoder

Signed-off-by: Spike Curtis <spike@coder.com>

* Remove comment from libcoder Chart.yaml

Signed-off-by: Spike Curtis <spike@coder.com>

* Add provisioner helm chart

* Fix prettier, linting, docs

Signed-off-by: Spike Curtis <spike@coder.com>

* Log at INFO when provisionerd connects to coderd

Signed-off-by: Spike Curtis <spike@coder.com>

* remove unnecessary exports in helm tests

Signed-off-by: Spike Curtis <spike@coder.com>

---------

Signed-off-by: Spike Curtis <spike@coder.com>
2023-08-10 13:59:43 +04:00
Steven Masley cdb089049e chore: add docs for creating missing groups on oidc sync (#8983) 2023-08-09 22:43:44 -05:00
Colin Adler 370bdd6a03 fix(cli): only init clistat.Client when calling coder stat (#9013) 2023-08-09 19:17:57 -05:00
Bruno Quaresma c0d1cacc49 fix(site): fix storybook error and inconsistent snapshots (#9010) 2023-08-09 21:22:13 +00:00
Eric Paulsen fb5e0c4bba docs: add TLS config steps for K8s (#9011)
* docs: add TLS config steps for K8s

* add note on wildcard cert
2023-08-09 17:00:22 -04:00
Bruno Quaresma 3245e91a32 fix(site): set default color and display error on appearance form (#9004) 2023-08-09 16:53:32 -03:00
Colin Adler bc862fa493 chore: upgrade tailscale to v1.46.1 (#8913) 2023-08-09 19:50:26 +00:00
Bruno Quaresma 5b9dc2ee8b fix(site): add search params to auth redirect (#9005) 2023-08-09 16:31:12 -03:00
phorcys420andMathias Fredriksson 53f26b313d fix(scripts): check if PR list is empty (#8805)
Co-authored-by: Mathias Fredriksson <mafredri@gmail.com>
2023-08-09 19:22:46 +00:00
Colin Adler 612f1c6a55 chore: use echo provisioners in logging tests (#9008) 2023-08-09 19:03:02 +00:00
Steven Masley f334b66178 chore: do not allow resetting password of non password users (#9003) 2023-08-09 13:56:13 -05:00
Colin Adler 919f5c6fe9 chore: increase e2e timeout to 60s (#9007) 2023-08-09 18:50:27 +00:00