opensource/coder
3
0
Fork 0
mirror of https://github.com/coder/coder.git synced 2026-09-21 20:51:01 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(agent): handle ignored filepath.Walk error in filefinder (#22853)

Browse Source 
Log a warning when filepath.Walk fails during recursive directory
watching instead of silently discarding the error.
This commit is contained in:
Mathias Fredriksson
2026-03-10 15:43:24 +02:00
committed by GitHub
parent 2948400aef
commit beed379b1d
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
agent/filefinder/watcher_fs.go
+5 -2
View File
@@ -156,7 +156,7 @@ func (fw *fsWatcher) loop(ctx context.Context) {
func (fw *fsWatcher) addRecursive(dir string) []FSEvent {
var events []FSEvent
_ = filepath.Walk(dir, func(path string, info os.FileInfo, err error) error {
if walkErr := filepath.Walk(dir, func(path string, info os.FileInfo, err error) error {
if err != nil {
return nil //nolint:nilerr // best-effort
}
@@ -176,7 +176,10 @@ func (fw *fsWatcher) addRecursive(dir string) []FSEvent {
}
events = append(events, FSEvent{Op: OpCreate, Path: path, IsDir: false})
return nil
})
}); walkErr != nil {
fw.logger.Warn(context.Background(), "failed to walk directory",
slog.F("dir", dir), slog.Error(walkErr))
}
return events
}