From beed379b1dd4be29f1d2f628f01dc9dfb641ee5b Mon Sep 17 00:00:00 2001 From: Mathias Fredriksson Date: Tue, 10 Mar 2026 15:43:24 +0200 Subject: [PATCH] fix(agent): handle ignored filepath.Walk error in filefinder (#22853) Log a warning when filepath.Walk fails during recursive directory watching instead of silently discarding the error. --- agent/filefinder/watcher_fs.go | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/agent/filefinder/watcher_fs.go b/agent/filefinder/watcher_fs.go index 6d6a309d58..431c1dd4e7 100644 --- a/agent/filefinder/watcher_fs.go +++ b/agent/filefinder/watcher_fs.go @@ -156,7 +156,7 @@ func (fw *fsWatcher) loop(ctx context.Context) { func (fw *fsWatcher) addRecursive(dir string) []FSEvent { var events []FSEvent - _ = filepath.Walk(dir, func(path string, info os.FileInfo, err error) error { + if walkErr := filepath.Walk(dir, func(path string, info os.FileInfo, err error) error { if err != nil { return nil //nolint:nilerr // best-effort } @@ -176,7 +176,10 @@ func (fw *fsWatcher) addRecursive(dir string) []FSEvent { } events = append(events, FSEvent{Op: OpCreate, Path: path, IsDir: false}) return nil - }) + }); walkErr != nil { + fw.logger.Warn(context.Background(), "failed to walk directory", + slog.F("dir", dir), slog.Error(walkErr)) + } return events }