opensource/coder
3
0
Fork 0
mirror of https://github.com/coder/coder.git synced 2026-09-22 05:05:20 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix: relabel advisor max uses setting from per run to per turn (#27046)

Browse Source
This commit is contained in:
Thomas Kosiewski
2026-07-10 09:36:12 +02:00
committed by GitHub
parent 3d8ffd34b3
commit 9af3d31036
3 changed files with 9 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
docs/ai-coder/agents/platform-controls/advisor.md
+2 -2
View File
@@ -34,12 +34,12 @@ Once the experiment is enabled, configure the advisor under **AI Settings** >
| Field | Default | Notes |
|-------------------|----------------------|-------------------------------------------------------------------------------------------------------------------------|
| Max uses per run | `0` (unlimited) | Caps how many times the root agent can call the advisor in a single chat run. Must be a non-negative integer. |
| Max uses per turn | `0` (unlimited) | Caps how many times the root agent can call the advisor in a single chat turn. Must be a non-negative integer. |
| Max output tokens | `0` (server default) | Caps the advisor model's response length. `0` uses the server default of 16,384 tokens. Must be a non-negative integer. |
| Advisor model | Use chat model | Optional dedicated chat model config for the advisor. When unset, the advisor reuses the root agent's model. |
The advisor is not available in plan mode or to subagents. Failed advisor
invocations refund the per-run budget, and advisor calls are not metered
invocations refund the per-turn budget, and advisor calls are not metered
against the root chat's usage limit.
The same configuration is available at:
site/src/pages/AISettingsPage/CoderAgentsPage/CoderAgentsPageView.stories.tsx
+3 -3
View File
@@ -505,7 +505,7 @@ export const AdvisorSettingsVisible: Story = {
const section = await getSection(canvasElement, "Advisor");
expect(
within(section).getByRole("spinbutton", {
name: "Max uses per run",
name: "Max uses per turn",
}),
).toHaveValue(3);
expect(
@@ -519,7 +519,7 @@ export const AdvisorSettingsVisible: Story = {
// Changing a value exposes the Save button.
const maxUses = within(section).getByRole("spinbutton", {
name: "Max uses per run",
name: "Max uses per turn",
});
await userEvent.clear(maxUses);
await userEvent.type(maxUses, "5");
@@ -553,7 +553,7 @@ export const AdvisorClearButton: Story = {
await userEvent.click(clearButton);
expect(
within(section).getByRole("spinbutton", {
name: "Max uses per run",
name: "Max uses per turn",
}),
).toHaveValue(0);
expect(
site/src/pages/AgentsPage/components/AdvisorSettings.tsx
+4 -4
View File
@@ -104,7 +104,7 @@ const validateAdvisorConfig = (values: AdvisorSettingsFormValues) => {
if (!isNonNegativeIntegerString(values.max_uses_per_run)) {
errors.max_uses_per_run =
"Max uses per run must be a non-negative integer.";
"Max uses per turn must be a non-negative integer.";
}
if (!isNonNegativeIntegerString(values.max_output_tokens)) {
@@ -203,7 +203,7 @@ export const AdvisorSettings: FC<AdvisorSettingsProps> = ({
return (
<AgentSettingLayout
title="Advisor"
description="Cap advisor usage per run and optionally use an override model. The advisor provides strategic guidance to root agent chats. Set limits to 0 for unlimited."
description="Cap advisor usage per turn and optionally use an override model. The advisor provides strategic guidance to root agent chats. Set limits to 0 for unlimited."
showSave={canSave}
isSaving={isSavingAdvisorConfig}
isSavedVisible={isSavedVisible}
@@ -225,8 +225,8 @@ export const AdvisorSettings: FC<AdvisorSettingsProps> = ({
<CompactIntegerField
id={maxUsesId}
name="max_uses_per_run"
label="Uses / run"
ariaLabel="Max uses per run"
label="Uses / turn"
ariaLabel="Max uses per turn"
value={form.values.max_uses_per_run}
onChange={(value) => void form.setFieldValue("max_uses_per_run", value)}
onBlur={form.handleBlur}