opensource/coder
3
0
Fork 0
mirror of https://github.com/coder/coder.git synced 2026-09-24 15:04:27 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix: do not block form control rendering for dynamic parameters on parsing error (#18185)

Browse Source 
Defer to backend diagnostics when the values cannot be parsed and allow
the form control to render so the user can select a different option.
This commit is contained in:
Jaayden Halko
2025-06-02 13:40:06 -04:00
committed by GitHub
parent 2a0a268946
commit 87c4948c1d
1 changed files with 6 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
site/src/modules/workspaces/DynamicParameter/DynamicParameter.tsx
+6 -10
View File
@@ -387,11 +387,9 @@ const ParameterField: FC<ParameterFieldProps> = ({
const parsedValues = parseStringArrayValue(value ?? "");
if (parsedValues.error) {
return (
<p className="text-sm text-content-destructive">
{parsedValues.error}
</p>
);
// Diagnostics on parameter already handle this case, do not duplicate error message
// Reset user's values to an empty array. This would overwrite any default values
parsedValues.values = [];
}
// Map parameter options to MultiSelectCombobox options format
@@ -440,11 +438,9 @@ const ParameterField: FC<ParameterFieldProps> = ({
const parsedValues = parseStringArrayValue(value ?? "");
if (parsedValues.error) {
return (
<p className="text-sm text-content-destructive">
{parsedValues.error}
</p>
);
// Diagnostics on parameter already handle this case, do not duplicate error message
// Reset user's values to an empty array. This would overwrite any default values
parsedValues.values = [];
}
return (