From 87c4948c1d13cc84486b571d23d8640ad422c4f9 Mon Sep 17 00:00:00 2001
From: Jaayden Halko <jaayden.halko@gmail.com>
Date: Mon, 2 Jun 2025 12:40:06 -0500
Subject: [PATCH] fix: do not block form control rendering for dynamic
 parameters on parsing error (#18185)

Defer to backend diagnostics when the values cannot be parsed and allow
the form control to render so the user can select a different option.
---
 .../DynamicParameter/DynamicParameter.tsx        | 16 ++++++----------
 1 file changed, 6 insertions(+), 10 deletions(-)

diff --git a/site/src/modules/workspaces/DynamicParameter/DynamicParameter.tsx b/site/src/modules/workspaces/DynamicParameter/DynamicParameter.tsx
index 35c5763c23..c3448ac7d7 100644
--- a/site/src/modules/workspaces/DynamicParameter/DynamicParameter.tsx
+++ b/site/src/modules/workspaces/DynamicParameter/DynamicParameter.tsx
@@ -387,11 +387,9 @@ const ParameterField: FC<ParameterFieldProps> = ({
 			const parsedValues = parseStringArrayValue(value ?? "");
 
 			if (parsedValues.error) {
-				return (
-					<p className="text-sm text-content-destructive">
-						{parsedValues.error}
-					</p>
-				);
+				// Diagnostics on parameter already handle this case, do not duplicate error message
+				// Reset user's values to an empty array. This would overwrite any default values
+				parsedValues.values = [];
 			}
 
 			// Map parameter options to MultiSelectCombobox options format
@@ -440,11 +438,9 @@ const ParameterField: FC<ParameterFieldProps> = ({
 			const parsedValues = parseStringArrayValue(value ?? "");
 
 			if (parsedValues.error) {
-				return (
-					<p className="text-sm text-content-destructive">
-						{parsedValues.error}
-					</p>
-				);
+				// Diagnostics on parameter already handle this case, do not duplicate error message
+				// Reset user's values to an empty array. This would overwrite any default values
+				parsedValues.values = [];
 			}
 
 			return (