opensource/univer
3
0
Fork 0
mirror of https://github.com/dream-num/univer.git synced 2026-10-24 12:04:33 +08:00
Code Issues Packages Projects Releases Wiki Activity

chore: always report regardless of expects (#4782)

Browse Source
This commit is contained in:
Wenzhao Hu
2025-03-06 19:03:28 +08:00
committed by GitHub
parent 58a24b5c3b
commit e1ba4a0d6f
2 changed files with 25 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files
e2e/memory/memory.spec.ts
+18 -28
View File
@@ -21,14 +21,12 @@ import { reportToPosthog, shutdownPosthog } from '../utils/report-performance';
import { getMetrics } from './util';
const MAX_UNIT_MEMORY_OVERFLOW = 1_000_000; // 1MB
const MAX_SECOND_INSTANCE_OVERFLOW = 200_000; // 200 KB
// There are some compiled code and global cache, so we make some room
// for this. But we need to make sure that a Univer object cannot fit
// in this size.
const MAX_UNIVER_MEMORY_OVERFLOW = 6_000_000; // TODO@wzhudev: temporarily added 300KB
// there is a memory leak in the univer object, so we need to make sure that
const MAX_SECOND_INSTANCE_OVERFLOW = 110_000; // Only 100 KB
const MAX_UNIVER_MEMORY_OVERFLOW = 6_000_000;
interface IHeapSnapshotChunk {
chunk: string;
@@ -124,45 +122,37 @@ test('memory', async ({ page }) => {
const client = await page.context().newCDPSession(page);
await page.goto('http://localhost:3000/sheets/');
await page.waitForTimeout(2000);
await page.waitForTimeout(5000);
const memoryAfterFirstInstance = (await getMetrics(page)).JSHeapUsedSize;
await page.evaluate(() => window.E2EControllerAPI.loadAndRelease(1));
await page.waitForTimeout(2000);
await page.waitForTimeout(5000);
const memoryAfterFirstLoad = (await getMetrics(page)).JSHeapUsedSize;
await page.evaluate(() => window.E2EControllerAPI.loadAndRelease(2));
await page.waitForTimeout(2000);
await page.waitForTimeout(5000);
const memoryAfterSecondLoad = (await getMetrics(page)).JSHeapUsedSize;
await reportToPosthog('unit_memory_overflow', { value: memoryAfterSecondLoad - memoryAfterFirstLoad });
expect(memoryAfterSecondLoad - memoryAfterFirstLoad)
.toBeLessThanOrEqual(MAX_UNIT_MEMORY_OVERFLOW);
const unitMemoryOverflow = memoryAfterSecondLoad - memoryAfterFirstLoad;
await reportToPosthog('unit_memory_overflow', { value: unitMemoryOverflow });
await page.evaluate(() => window.univer.dispose());
await page.waitForTimeout(2000);
await page.waitForTimeout(5000);
await takeHeapSnapshot(client, 'memory-first.heapsnapshot');
const memoryAfterDisposingFirstInstance = (await getMetrics(page)).JSHeapUsedSize;
await page.evaluate(() => window.createNewInstance());
await page.waitForTimeout(2000);
await page.waitForTimeout(5000);
await page.evaluate(() => window.univer.dispose());
await page.waitForTimeout(2000);
await page.waitForTimeout(5000);
await takeHeapSnapshot(client, 'memory-second.heapsnapshot');
const memoryAfterDisposingSecondUniver = (await getMetrics(page)).JSHeapUsedSize;
await reportToPosthog('instance_memory_overflow', { value: memoryAfterDisposingSecondUniver - memoryAfterDisposingFirstInstance });
expect(memoryAfterDisposingSecondUniver - memoryAfterDisposingFirstInstance)
.toBeLessThanOrEqual(MAX_SECOND_INSTANCE_OVERFLOW);
await reportToPosthog('univer_memory_overflow', { value: memoryAfterDisposingSecondUniver - memoryAfterFirstInstance });
expect(memoryAfterDisposingSecondUniver - memoryAfterFirstInstance)
.toBeLessThanOrEqual(MAX_UNIVER_MEMORY_OVERFLOW);
const instanceMemoryOverflow = memoryAfterDisposingSecondUniver - memoryAfterDisposingFirstInstance;
const univerMemoryOverflow = memoryAfterDisposingSecondUniver - memoryAfterFirstInstance;
await reportToPosthog('instance_memory_overflow', { value: instanceMemoryOverflow });
await reportToPosthog('univer_memory_overflow', { value: univerMemoryOverflow });
await shutdownPosthog();
expect(unitMemoryOverflow).toBeLessThanOrEqual(MAX_UNIT_MEMORY_OVERFLOW);
expect(instanceMemoryOverflow).toBeLessThanOrEqual(MAX_SECOND_INSTANCE_OVERFLOW);
expect(univerMemoryOverflow).toBeLessThanOrEqual(MAX_UNIVER_MEMORY_OVERFLOW);
});
declare global {
e2e/utils/report-performance.ts
+7
View File
@@ -23,6 +23,13 @@ const GIT_HASH = process.env.GITHUB_SHA;
let client: PostHog | null = null;
/**
* Report an event to PostHog. For Univer members, you can visit https://us.posthog.com/project/133116/dashboard/332238
* for the dashboard.
* @param event
* @param properties
* @returns {Promise<void>} A promise that resolves when the event is reported.
*/
// eslint-disable-next-line ts/no-explicit-any
export async function reportToPosthog(event: string, properties: Record<string | number, any>) {
if (!SHOULD_REPORT_TO_POSTHOG) {