ci: support eslint & type checking (#142)

.github/workflows/ci-test.yml

@@ -45,8 +45,23 @@ jobs:
           restore-keys: |
             ${{ runner.os }}-pnpm-store-
 
+      - name: Setup ESLint cache
+        uses: actions/cache@v3
+        with:
+          path: .eslintcache
+          key: |
+            ${{ runner.os }}-eslint-${{ hashFiles('.eslintrc.js') }}
+          restore-keys: |
+            ${{ runner.os }}-eslint-
+
       - name: Install dependencies
         run: pnpm install
 
-      - name: Testing
+      - name: 🩺 Run Test
         run: pnpm run test
+
+      - name: 🌡️ Run ESLint
+        run: pnpm run lint
+
+      - name: 🧼 Type checking
+        run: npx tsc --noEmit

examples/univer-doc-ts/tsconfig.json

@@ -3,7 +3,6 @@
     "compilerOptions": {
         "rootDir": "./",
         "outDir": "lib",
-        "moduleResolution": "Node", //This value is needed for Node.js.
         "downlevelIteration": true,
         "baseUrl": "./",
         "esModuleInterop": true, // auto allowSyntheticDefaultImports true

examples/univer-sheet-ts/tsconfig.json

@@ -4,7 +4,6 @@
         "rootDir": "./",
         "outDir": "lib",
         "module": "commonjs",
-        "moduleResolution": "Node", //This value is needed for Node.js.
         "downlevelIteration": true,
         "baseUrl": "./",
         "esModuleInterop": true, // auto allowSyntheticDefaultImports true

examples/univer-slide-ts/tsconfig.json

@@ -3,7 +3,6 @@
     "compilerOptions": {
         "rootDir": "./",
         "outDir": "lib",
-        "moduleResolution": "Node", //This value is needed for Node.js.
         "downlevelIteration": true,
         "baseUrl": "./",
         "esModuleInterop": true, // auto allowSyntheticDefaultImports true

examples/univer-vanilla-ts/tsconfig.json

@@ -3,7 +3,6 @@
     "compilerOptions": {
         "rootDir": "./",
         "outDir": "lib",
-        "moduleResolution": "Node", //This value is needed for Node.js.
         "downlevelIteration": true,
         "baseUrl": "./",
         "esModuleInterop": true, // auto allowSyntheticDefaultImports true

packages/base-docs/tsconfig.json

@@ -3,7 +3,6 @@
     "compilerOptions": {
         "rootDir": "./",
         "outDir": "lib",
-        "moduleResolution": "Node", //This value is needed for Node.js.
         "baseUrl": "./",
         "esModuleInterop": true, // auto allowSyntheticDefaultImports true
         "strictPropertyInitialization": false

packages/base-formula-engine/tsconfig.json

@@ -3,7 +3,6 @@
     "compilerOptions": {
         "rootDir": "./",
         "outDir": "lib",
-        "moduleResolution": "Node", //This value is needed for Node.js.
         "baseUrl": "./",
         "esModuleInterop": true, // auto allowSyntheticDefaultImports true
         "strictPropertyInitialization": false

packages/base-numfmt-engine/tsconfig.json

@@ -3,7 +3,6 @@
     "compilerOptions": {
         "rootDir": "./",
         "outDir": "lib",
-        "moduleResolution": "Node",
         "baseUrl": "./",
         "esModuleInterop": true,
     },

packages/base-render/tsconfig.json

@@ -3,7 +3,6 @@
     "compilerOptions": {
         "rootDir": "./",
         "outDir": "lib",
-        "moduleResolution": "Node", //This value is needed for Node.js.
         "baseUrl": "./",
         // "paths": {
         //     "@*": ["src/*"]

packages/base-sheets/tsconfig.json

@@ -3,7 +3,6 @@
     "compilerOptions": {
         "rootDir": "./",
         "outDir": "lib",
-        "moduleResolution": "Node", //This value is needed for Node.js.
         "baseUrl": "./",
         "paths": {
             "@*": [

packages/base-slides/tsconfig.json

@@ -3,7 +3,6 @@
     "compilerOptions": {
         "rootDir": "./",
         "outDir": "lib",
-        "moduleResolution": "Node", //This value is needed for Node.js.
         "baseUrl": "./",
         "esModuleInterop": true, // auto allowSyntheticDefaultImports true
         "strictPropertyInitialization": false

packages/base-ui/tsconfig.json

@@ -3,7 +3,6 @@
     "compilerOptions": {
         "rootDir": "./",
         "outDir": "lib",
-        "moduleResolution": "Node", //This value is needed for Node.js.
         "baseUrl": "./",
         "esModuleInterop": true, // auto allowSyntheticDefaultImports true
         "strictPropertyInitialization": false,

packages/common-plugin-data/tsconfig.json

@@ -3,7 +3,6 @@
     "compilerOptions": {
         "rootDir": "./",
         "outDir": "lib",
-        "moduleResolution": "Node", //This value is needed for Node.js.
         "baseUrl": "./",
         "esModuleInterop": true, // auto allowSyntheticDefaultImports true
         "jsx": "preserve",

packages/core/tsconfig.json

@@ -3,7 +3,6 @@
     "compilerOptions": {
         "rootDir": "./",
         "outDir": "lib",
-        "moduleResolution": "Node", //This value is needed for Node.js.
         "downlevelIteration": true,
         "baseUrl": "./",
         "esModuleInterop": true, // auto allowSyntheticDefaultImports true

packages/sheets-plugin-filter/tsconfig.json

@@ -3,7 +3,6 @@
     "compilerOptions": {
         "rootDir": "./",
         "outDir": "lib",
-        "moduleResolution": "Node", //This value is needed for Node.js.
         "baseUrl": "./",
         "esModuleInterop": true, // auto allowSyntheticDefaultImports true
         "strictPropertyInitialization": false

packages/sheets-plugin-find/tsconfig.json

@@ -3,7 +3,6 @@
     "compilerOptions": {
         "rootDir": "./",
         "outDir": "lib",
-        "moduleResolution": "Node", //This value is needed for Node.js.
         "baseUrl": "./",
         "esModuleInterop": true, // auto allowSyntheticDefaultImports true
         "strictPropertyInitialization": false

packages/sheets-plugin-formula/tsconfig.json

@@ -3,7 +3,6 @@
     "compilerOptions": {
         "rootDir": "./",
         "outDir": "lib",
-        "moduleResolution": "Node", //This value is needed for Node.js.
         "baseUrl": "./",
         "esModuleInterop": true, // auto allowSyntheticDefaultImports true
         "strictPropertyInitialization": false

packages/sheets-plugin-image/tsconfig.json

@@ -3,7 +3,6 @@
     "compilerOptions": {
         "rootDir": "./",
         "outDir": "lib",
-        "moduleResolution": "Node",
         "baseUrl": "./",
         "esModuleInterop": true,
         "strictPropertyInitialization": false

packages/sheets-plugin-import-xlsx/tsconfig.json

@@ -3,7 +3,6 @@
     "compilerOptions": {
         "rootDir": "./",
         "outDir": "lib",
-        "moduleResolution": "Node", //This value is needed for Node.js.
         "baseUrl": "./",
         "esModuleInterop": true, // auto allowSyntheticDefaultImports true
         "strictPropertyInitialization": false

packages/sheets-plugin-numfmt/tsconfig.json

@@ -3,7 +3,6 @@
     "compilerOptions": {
         "rootDir": "./",
         "outDir": "lib",
-        "moduleResolution": "Node",
         "baseUrl": "./",
         "esModuleInterop": true,
         "strictPropertyInitialization": false

packages/sheets-plugin-operation/tsconfig.json

@@ -3,7 +3,6 @@
     "compilerOptions": {
         "rootDir": "./",
         "outDir": "lib",
-        "moduleResolution": "Node", //This value is needed for Node.js.
         "baseUrl": "./",
         "esModuleInterop": true, // auto allowSyntheticDefaultImports true
         "strictPropertyInitialization": false

packages/ui-plugin-docs/tsconfig.json

@@ -3,7 +3,6 @@
     "compilerOptions": {
         "rootDir": "./",
         "outDir": "lib",
-        "moduleResolution": "Node", //This value is needed for Node.js.
         "baseUrl": "./",
         "esModuleInterop": true, // auto allowSyntheticDefaultImports true
         "strictPropertyInitialization": false

packages/ui-plugin-sheets/tsconfig.json

@@ -3,7 +3,6 @@
     "compilerOptions": {
         "rootDir": "./",
         "outDir": "lib",
-        "moduleResolution": "Node", //This value is needed for Node.js.
         "baseUrl": "./",
         "esModuleInterop": true, // auto allowSyntheticDefaultImports true
         "strictPropertyInitialization": false

packages/ui-plugin-slides/tsconfig.json

@@ -3,7 +3,6 @@
     "compilerOptions": {
         "rootDir": "./",
         "outDir": "lib",
-        "moduleResolution": "Node", //This value is needed for Node.js.
         "baseUrl": "./",
         "esModuleInterop": true, // auto allowSyntheticDefaultImports true
         "strictPropertyInitialization": false

tsconfig.json

@@ -10,6 +10,7 @@
         "jsx": "react-jsx",
         "jsxImportSource": "react",
         "sourceMap": true,
+        "moduleResolution": "Bundler",
         "resolveJsonModule": true,
         "strict": true,
         "strictPropertyInitialization": true,