Files
teleport/lib/gitlab/token_validator.go
T
Noah Stride acb255cd88 GitLab Delegated Joining (#22705)
* Add type for GitLab ProvisionToken

* Add default behaviour for domain

* Add IDTokenClaims for GitLab

* Add gitlab token source and token validator

* Thread GitLab support through auth and tbot packages

* Adjust cluster name fetching in token validator

* Initialize GitLab token validator in auth

* Improve comment on `sub`

* Working GitLab CI delegated joining

* Add additional token rule fields

* Add checking for new configuration fields

* add additional test cases for validation of gitlab config struct

* Add TestAuth_RegisterUsingToken_GitLab

* Add tests for IDTokenSource

* Fix imports

* Add tests for GitLab Token Validator

* Fix some comments that were incomplete

* Add license headers
2023-03-16 16:19:11 +00:00

170 lines
4.0 KiB
Go

/*
Copyright 2023 Gravitational, Inc.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
package gitlab
import (
"context"
"encoding/json"
"fmt"
"time"
"github.com/coreos/go-oidc"
"github.com/gravitational/trace"
"github.com/jonboulle/clockwork"
"github.com/gravitational/teleport/api/types"
"github.com/gravitational/teleport/lib/services"
)
type clusterNameGetter interface {
GetClusterName(opts ...services.MarshalOption) (types.ClusterName, error)
}
type IDTokenValidatorConfig struct {
// Clock is used by the validator when checking expiry and issuer times of
// tokens. If omitted, a real clock will be used.
Clock clockwork.Clock
// ClusterNameGetter is used to get the cluster name in order to identify
// the correct audience for the token.
ClusterNameGetter clusterNameGetter
// insecure configures the validator to use HTTP rather than HTTPS. This
// is not exported as this is only used in the test for now.
insecure bool
}
type IDTokenValidator struct {
IDTokenValidatorConfig
}
func NewIDTokenValidator(
cfg IDTokenValidatorConfig,
) (*IDTokenValidator, error) {
if cfg.Clock == nil {
cfg.Clock = clockwork.NewRealClock()
}
if cfg.ClusterNameGetter == nil {
return nil, trace.BadParameter(
"ClusterNameGetter must be configured",
)
}
return &IDTokenValidator{
IDTokenValidatorConfig: cfg,
}, nil
}
func (id *IDTokenValidator) issuerURL(domain string) string {
scheme := "https"
if id.insecure {
scheme = "http"
}
return fmt.Sprintf("%s://%s", scheme, domain)
}
func (id *IDTokenValidator) Validate(
ctx context.Context, domain string, token string,
) (*IDTokenClaims, error) {
p, err := oidc.NewProvider(
ctx,
id.issuerURL(domain),
)
if err != nil {
return nil, trace.Wrap(err)
}
clusterNameResource, err := id.ClusterNameGetter.GetClusterName()
if err != nil {
return nil, err
}
verifier := p.Verifier(&oidc.Config{
ClientID: clusterNameResource.GetClusterName(),
Now: id.Clock.Now,
})
idToken, err := verifier.Verify(ctx, token)
if err != nil {
return nil, trace.Wrap(err)
}
// `go-oidc` does not implement not before check, so we need to manually
// perform this
if err := checkNotBefore(
id.Clock.Now(), time.Minute*2, idToken,
); err != nil {
return nil, trace.Wrap(err)
}
claims := IDTokenClaims{}
if err := idToken.Claims(&claims); err != nil {
return nil, trace.Wrap(err)
}
return &claims, nil
}
// checkNotBefore ensures the token was not issued in the future.
// https://www.rfc-editor.org/rfc/rfc7519#section-4.1.5
// 4.1.5. "nbf" (Not Before) Claim
// TODO(strideynet): upstream support for `nbf` into the go-oidc lib.
func checkNotBefore(
now time.Time, leeway time.Duration, token *oidc.IDToken,
) error {
claims := struct {
NotBefore *jsonTime `json:"nbf"`
}{}
if err := token.Claims(&claims); err != nil {
return trace.Wrap(err)
}
if claims.NotBefore != nil {
adjustedNow := now.Add(leeway)
nbf := time.Time(*claims.NotBefore)
if adjustedNow.Before(nbf) {
return trace.AccessDenied("token not before in future")
}
}
return nil
}
// jsonTime unmarshaling sourced from
// https://github.com/gravitational/go-oidc/blob/master/oidc.go#L295
// TODO(strideynet): upstream support for `nbf` into the go-oidc lib.
type jsonTime time.Time
func (j *jsonTime) UnmarshalJSON(b []byte) error {
var n json.Number
if err := json.Unmarshal(b, &n); err != nil {
return err
}
var unix int64
if t, err := n.Int64(); err == nil {
unix = t
} else {
f, err := n.Float64()
if err != nil {
return err
}
unix = int64(f)
}
*j = jsonTime(time.Unix(unix, 0))
return nil
}