opensource/teleport
3
0
Fork 0
mirror of https://github.com/gravitational/teleport.git synced 2026-09-24 16:17:11 +08:00
Code Issues Packages Projects Releases Wiki Activity

removeSecure() should close the file before removing it on Windows (#32948)

Browse Source 
* `removeSecure()` should close the file before removing it on Windows

* Do not return early if `Close()` returns an error
This commit is contained in:
Grzegorz Zdunek
2023-10-04 15:31:52 +00:00
committed by GitHub
parent c31e07841a
commit dffb5620b3
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/utils/fs.go
+4 -1
View File
@@ -323,7 +323,10 @@ func removeSecure(filePath string, fi os.FileInfo) error {
}
}
}
return trace.ConvertSystemError(os.Remove(filePath))
// The file should be closed before removing it on Windows.
closeErr := trace.ConvertSystemError(f.Close())
removeErr := trace.ConvertSystemError(os.Remove(filePath))
return trace.NewAggregate(closeErr, removeErr)
} else {
removeErr := os.Remove(filePath)
if f != nil {