opensource/sim
3
0
Fork 0
mirror of https://github.com/simstudioai/sim.git synced 2026-09-24 15:45:35 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(ui): support Tab key to select items in tag, env-var, and resource dropdowns (#4096)

Browse Source 
* fix(ui): support Tab key to select items in tag, env-var, and resource dropdowns

* fix(ui): support Tab key to select items in tag, env-var, and resource dropdowns

* fix(ui): guard Tab selection against Shift+Tab and undefined index
This commit is contained in:
Waleed
2026-04-10 14:30:09 -07:00
committed by GitHub
parent 2e85361ed6
commit fb5ebd3bed
3 changed files with 13 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
apps/sim/app/workspace/[workspaceId]/home/components/mothership-view/components/add-resource-dropdown/add-resource-dropdown.tsx
+2 -2
View File
@@ -167,9 +167,9 @@ export function AddResourceDropdown({
} else if (e.key === 'ArrowUp') {
e.preventDefault()
setActiveIndex((prev) => Math.max(prev - 1, 0))
} else if (e.key === 'Enter') {
e.preventDefault()
} else if (e.key === 'Enter' || (e.key === 'Tab' && !e.shiftKey)) {
if (filtered.length > 0 && filtered[activeIndex]) {
e.preventDefault()
const { type, item } = filtered[activeIndex]
select({ type, id: item.id, title: item.name }, item.isOpen)
}
apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/panel/components/editor/components/sub-block/components/env-var-dropdown.tsx
+7 -3
View File
@@ -242,9 +242,13 @@ export const EnvVarDropdown: React.FC<EnvVarDropdownProps> = ({
})
break
case 'Enter':
e.preventDefault()
e.stopPropagation()
handleEnvVarSelect(filteredEnvVars[selectedIndex])
case 'Tab':
if (e.key === 'Tab' && e.shiftKey) break
if (filteredEnvVars[selectedIndex]) {
e.preventDefault()
e.stopPropagation()
handleEnvVarSelect(filteredEnvVars[selectedIndex])
}
break
case 'Escape':
e.preventDefault()
apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/panel/components/editor/components/sub-block/components/tag-dropdown/components/keyboard-navigation-handler.tsx
+4 -2
View File
@@ -279,9 +279,11 @@ export const KeyboardNavigationHandler: React.FC<KeyboardNavigationHandlerProps>
}
break
case 'Enter':
e.preventDefault()
e.stopPropagation()
case 'Tab':
if (e.key === 'Tab' && e.shiftKey) break
if (selected && selectedIndex >= 0 && selectedIndex < flatTagList.length) {
e.preventDefault()
e.stopPropagation()
handleTagSelect(selected.tag, selected.group)
}
break