opensource/sim
3
0
Fork 0
mirror of https://github.com/simstudioai/sim.git synced 2026-10-24 11:36:37 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(sidebar): pass showDelete to hide delete menu for non-admin members (#4697)

Browse Source 
The ContextMenu component already has a showDelete prop with conditional
rendering, but workflow-item and folder-item never pass it, leaving it
at the default value of true. This causes write members to see an active
Delete option that always fails with 403, since the DELETE API requires
admin permission.

Pass showDelete={userPermissions.canAdmin} from both workflow-item and
folder-item so that non-admin users no longer see the Delete menu.
Simplify disableDelete to only check canDeleteSelection and
effectiveLocked, since permission gating is now handled by showDelete.
This commit is contained in:
mini
2026-05-21 14:27:42 -07:00
committed by GitHub
parent 89695de81d
commit d7ed3c24c0
2 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
apps/sim/app/workspace/[workspaceId]/w/components/sidebar/components/workflow-list/components/folder-item/folder-item.tsx
+2 -1
View File
@@ -612,7 +612,8 @@ export function FolderItem({
!userPermissions.canEdit || isDuplicatingSelection || !hasExportableContent
}
disableExport={!userPermissions.canEdit || isExporting || !hasExportableContent}
disableDelete={!userPermissions.canEdit || effectiveLocked || !canDeleteSelection}
showDelete={userPermissions.canAdmin}
disableDelete={effectiveLocked || !canDeleteSelection}
onToggleLock={handleToggleLock}
showLock={!isMixedSelection && selectedFolders.size <= 1}
disableLock={!userPermissions.canAdmin || inheritedFolderLocked}
apps/sim/app/workspace/[workspaceId]/w/components/sidebar/components/workflow-list/components/workflow-item/workflow-item.tsx
+2 -1
View File
@@ -524,7 +524,8 @@ export function WorkflowItem({
disableDuplicate={!userPermissions.canEdit || isDuplicatingSelection}
disableExport={!userPermissions.canEdit}
disableColorChange={!userPermissions.canEdit || effectiveLocked}
disableDelete={!userPermissions.canEdit || !canDeleteSelection || effectiveLocked}
showDelete={userPermissions.canAdmin}
disableDelete={!canDeleteSelection || effectiveLocked}
onToggleLock={handleToggleLock}
showLock={!isMixedSelection && selectedWorkflows.size <= 1}
disableLock={!userPermissions.canAdmin || inheritedFolderLocked}