opensource/sim
3
0
Fork 0
mirror of https://github.com/simstudioai/sim.git synced 2026-09-24 15:45:35 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(event-buffer): re-compact the event with preserveUserFileBase64: false (#4579)

Browse Source 
* preserveUserFileBase64 is on and the event still exceeds the threshold, re-compact the event with preserveUserFileBase64: false

* address comments
This commit is contained in:
Vikhyath Mondreti
2026-05-12 21:16:22 -07:00
committed by GitHub
parent 689e1f76d1
commit bdf9ffc798
1 changed files with 37 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
apps/sim/lib/execution/event-buffer.ts
+37 -4
View File
@@ -293,15 +293,48 @@ async function compactEventForBuffer(
return event
}
const compactedData = await compactExecutionPayload(event.data, {
const baseOptions = {
...context,
executionId: context.executionId ?? event.executionId,
requireDurable: context.requireDurablePayloads,
preserveUserFileBase64: context.preserveUserFileBase64,
preserveRoot: true,
}
let compactedData = await compactExecutionPayload(event.data, {
...baseOptions,
preserveUserFileBase64: context.preserveUserFileBase64,
})
const eventData = trimFinalBlockLogsForEventData(compactedData)
const eventDataSize = getJsonSize(eventData)
let eventData = trimFinalBlockLogsForEventData(compactedData)
let eventDataSize = getJsonSize(eventData)
// SSE/replay events are size-bounded by LARGE_VALUE_THRESHOLD_BYTES. When a
// payload that preserved UserFile base64 (e.g., for chat/streaming) exceeds
// the cap, recompact the already-compacted result with base64 stripped so
// consumers can lazily re-hydrate via sim.files.readBase64. Recompacting the
// *compacted* value (not the raw event.data) lets existing LargeValueRefs
// pass through unchanged and avoids minting fresh storage objects for the
// same large fields.
if (
context.preserveUserFileBase64 &&
eventDataSize !== null &&
eventDataSize > LARGE_VALUE_THRESHOLD_BYTES
) {
const oversizedBytes = eventDataSize
compactedData = await compactExecutionPayload(compactedData, {
...baseOptions,
preserveUserFileBase64: false,
})
eventData = trimFinalBlockLogsForEventData(compactedData)
eventDataSize = getJsonSize(eventData)
logger.warn('Stripped inline UserFile base64 from execution event to fit size limit', {
executionId: baseOptions.executionId,
eventType: 'type' in event ? event.type : undefined,
thresholdBytes: LARGE_VALUE_THRESHOLD_BYTES,
originalBytes: oversizedBytes,
strippedBytes: eventDataSize,
})
}
if (eventDataSize !== null && eventDataSize > LARGE_VALUE_THRESHOLD_BYTES) {
throw new Error(
`Execution event data remains too large after compaction (${eventDataSize} bytes)`