opensource/sim
3
0
Fork 0
mirror of https://github.com/simstudioai/sim.git synced 2026-09-24 15:45:35 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(webhooks): non-polling webhook executions silently dropped after BullMQ removal (#4153)

Browse Source
This commit is contained in:
Waleed
2026-04-14 08:43:17 -07:00
committed by GitHub
parent 8a8bc1b0e6
commit a51333aa2f
1 changed files with 40 additions and 44 deletions
Download Patch File Download Diff File Expand all files Collapse all files
apps/sim/lib/webhooks/processor.ts
+40 -44
View File
@@ -591,32 +591,30 @@ export async function queueWebhookExecution(
`[${options.requestId}] Queued ${foundWebhook.provider} webhook execution ${jobId} via inline backend`
)
if (shouldExecuteInline()) {
void (async () => {
void (async () => {
try {
await jobQueue.startJob(jobId)
const output = await executeWebhookJob(payload)
await jobQueue.completeJob(jobId, output)
} catch (error) {
const errorMessage = error instanceof Error ? error.message : String(error)
logger.error(`[${options.requestId}] Webhook execution failed`, {
jobId,
error: errorMessage,
})
try {
await jobQueue.startJob(jobId)
const output = await executeWebhookJob(payload)
await jobQueue.completeJob(jobId, output)
} catch (error) {
const errorMessage = error instanceof Error ? error.message : String(error)
logger.error(`[${options.requestId}] Webhook execution failed`, {
await jobQueue.markJobFailed(jobId, errorMessage)
} catch (markFailedError) {
logger.error(`[${options.requestId}] Failed to mark job as failed`, {
jobId,
error: errorMessage,
error:
markFailedError instanceof Error
? markFailedError.message
: String(markFailedError),
})
try {
await jobQueue.markJobFailed(jobId, errorMessage)
} catch (markFailedError) {
logger.error(`[${options.requestId}] Failed to mark job as failed`, {
jobId,
error:
markFailedError instanceof Error
? markFailedError.message
: String(markFailedError),
})
}
}
})()
}
}
})()
}
const successResponse = handler.formatSuccessResponse?.(providerConfig) ?? null
@@ -780,32 +778,30 @@ export async function processPolledWebhookEvent(
})
logger.info(`[${requestId}] Queued ${provider} webhook execution ${jobId} via inline backend`)
if (shouldExecuteInline()) {
void (async () => {
void (async () => {
try {
await jobQueue.startJob(jobId)
const output = await executeWebhookJob(payload)
await jobQueue.completeJob(jobId, output)
} catch (error) {
const errorMessage = error instanceof Error ? error.message : String(error)
logger.error(`[${requestId}] Webhook execution failed`, {
jobId,
error: errorMessage,
})
try {
await jobQueue.startJob(jobId)
const output = await executeWebhookJob(payload)
await jobQueue.completeJob(jobId, output)
} catch (error) {
const errorMessage = error instanceof Error ? error.message : String(error)
logger.error(`[${requestId}] Webhook execution failed`, {
await jobQueue.markJobFailed(jobId, errorMessage)
} catch (markFailedError) {
logger.error(`[${requestId}] Failed to mark job as failed`, {
jobId,
error: errorMessage,
error:
markFailedError instanceof Error
? markFailedError.message
: String(markFailedError),
})
try {
await jobQueue.markJobFailed(jobId, errorMessage)
} catch (markFailedError) {
logger.error(`[${requestId}] Failed to mark job as failed`, {
jobId,
error:
markFailedError instanceof Error
? markFailedError.message
: String(markFailedError),
})
}
}
})()
}
}
})()
}
return { success: true }