opensource/sim
3
0
Fork 0
mirror of https://github.com/simstudioai/sim.git synced 2026-09-24 15:45:35 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(file-upload): fixed file upload URL required (#875)

Browse Source 
* fix(file-upload): fixed file upload URL required

* cleanup
This commit is contained in:
Waleed Latif
2025-08-04 21:40:18 -07:00
committed by GitHub
parent 64cd60d63a
commit 2bba20129f
2 changed files with 73 additions and 117 deletions
Download Patch File Download Diff File Expand all files Collapse all files
apps/sim/blocks/blocks/file.ts
+33 -53
View File
@@ -1,68 +1,54 @@
import { DocumentIcon } from '@/components/icons'
import { isProd } from '@/lib/environment'
import { createLogger } from '@/lib/logs/console/logger'
import type { BlockConfig, SubBlockConfig, SubBlockLayout, SubBlockType } from '@/blocks/types'
import type { BlockConfig, SubBlockLayout, SubBlockType } from '@/blocks/types'
import type { FileParserOutput } from '@/tools/file/types'
const logger = createLogger('FileBlock')
const shouldEnableURLInput = isProd
const inputMethodBlock: SubBlockConfig = {
id: 'inputMethod',
title: 'Select Input Method',
type: 'dropdown' as SubBlockType,
layout: 'full' as SubBlockLayout,
options: [
{ id: 'url', label: 'File URL' },
{ id: 'upload', label: 'Upload Files' },
],
}
const fileUploadBlock: SubBlockConfig = {
id: 'file',
title: 'Upload Files',
type: 'file-upload' as SubBlockType,
layout: 'full' as SubBlockLayout,
acceptedTypes: '.pdf,.csv,.docx',
multiple: true,
maxSize: 100, // 100MB max via direct upload
}
export const FileBlock: BlockConfig<FileParserOutput> = {
type: 'file',
name: 'File',
description: 'Read and parse multiple files',
longDescription: `Upload and extract contents from structured file formats including PDFs, CSV spreadsheets, and Word documents (DOCX). ${
shouldEnableURLInput
? 'You can either provide a URL to a file or upload files directly. '
: 'Upload files directly. '
}Specialized parsers extract text and metadata from each format. You can upload multiple files at once and access them individually or as a combined document.`,
longDescription: `Upload and extract contents from structured file formats including PDFs, CSV spreadsheets, and Word documents (DOCX). You can either provide a URL to a file or upload files directly. Specialized parsers extract text and metadata from each format. You can upload multiple files at once and access them individually or as a combined document.`,
docsLink: 'https://docs.sim.ai/tools/file',
category: 'tools',
bgColor: '#40916C',
icon: DocumentIcon,
subBlocks: [
...(shouldEnableURLInput ? [inputMethodBlock] : []),
{
id: 'inputMethod',
title: 'Select Input Method',
type: 'dropdown' as SubBlockType,
layout: 'full' as SubBlockLayout,
options: [
{ id: 'url', label: 'File URL' },
{ id: 'upload', label: 'Upload Files' },
],
},
{
id: 'filePath',
title: 'File URL',
type: 'short-input' as SubBlockType,
layout: 'full' as SubBlockLayout,
placeholder: 'Enter URL to a file (https://example.com/document.pdf)',
...(shouldEnableURLInput
? {
condition: {
field: 'inputMethod',
value: 'url',
},
}
: {}),
condition: {
field: 'inputMethod',
value: 'url',
},
},
{
...fileUploadBlock,
...(shouldEnableURLInput ? { condition: { field: 'inputMethod', value: 'upload' } } : {}),
id: 'file',
title: 'Upload Files',
type: 'file-upload' as SubBlockType,
layout: 'full' as SubBlockLayout,
acceptedTypes: '.pdf,.csv,.docx',
multiple: true,
condition: {
field: 'inputMethod',
value: 'upload',
},
maxSize: 100, // 100MB max via direct upload
},
],
tools: {
@@ -70,8 +56,8 @@ export const FileBlock: BlockConfig<FileParserOutput> = {
config: {
tool: () => 'file_parser',
params: (params) => {
// Determine input method based on whether URL input is enabled
const inputMethod = shouldEnableURLInput ? params.inputMethod || 'url' : 'upload'
// Determine input method - default to 'url' if not specified
const inputMethod = params.inputMethod || 'url'
if (inputMethod === 'url') {
if (!params.filePath || params.filePath.trim() === '') {
@@ -87,7 +73,7 @@ export const FileBlock: BlockConfig<FileParserOutput> = {
}
}
// Handle file upload input (always possible, default if URL input disabled)
// Handle file upload input
if (inputMethod === 'upload') {
// Handle case where 'file' is an array (multiple files)
if (params.file && Array.isArray(params.file) && params.file.length > 0) {
@@ -109,7 +95,7 @@ export const FileBlock: BlockConfig<FileParserOutput> = {
// If no files, return error
logger.error('No files provided for upload method')
throw new Error('Please upload a file') // Changed error message slightly
throw new Error('Please upload a file')
}
// This part should ideally not be reached if logic above is correct
@@ -119,15 +105,9 @@ export const FileBlock: BlockConfig<FileParserOutput> = {
},
},
inputs: {
// Conditionally require inputMethod and filePath only if URL input is enabled
...(shouldEnableURLInput
? {
inputMethod: { type: 'string', description: 'Input method selection' }, // Not strictly required as it defaults
filePath: { type: 'string', description: 'File URL path' }, // Required only if inputMethod is 'url' (validated in params)
}
: {}),
inputMethod: { type: 'string', description: 'Input method selection' },
filePath: { type: 'string', description: 'File URL path' },
fileType: { type: 'string', description: 'File type' },
// File input is always potentially needed, but only required if method is 'upload' (validated in params)
file: { type: 'json', description: 'Uploaded file data' },
},
outputs: {
apps/sim/blocks/blocks/mistral_parse.ts
+40 -64
View File
@@ -1,71 +1,55 @@
import { MistralIcon } from '@/components/icons'
import { isProd } from '@/lib/environment'
import type { BlockConfig, SubBlockConfig, SubBlockLayout, SubBlockType } from '@/blocks/types'
import type { BlockConfig, SubBlockLayout, SubBlockType } from '@/blocks/types'
import type { MistralParserOutput } from '@/tools/mistral/types'
const shouldEnableFileUpload = isProd
const inputMethodBlock: SubBlockConfig = {
id: 'inputMethod',
title: 'Select Input Method',
type: 'dropdown' as SubBlockType,
layout: 'full' as SubBlockLayout,
options: [
{ id: 'url', label: 'PDF Document URL' },
{ id: 'upload', label: 'Upload PDF Document' },
],
}
const fileUploadBlock: SubBlockConfig = {
id: 'fileUpload',
title: 'Upload PDF',
type: 'file-upload' as SubBlockType,
layout: 'full' as SubBlockLayout,
acceptedTypes: 'application/pdf',
condition: {
field: 'inputMethod',
value: 'upload',
},
maxSize: 50, // 50MB max via direct upload
}
export const MistralParseBlock: BlockConfig<MistralParserOutput> = {
type: 'mistral_parse',
name: 'Mistral Parser',
description: 'Extract text from PDF documents',
longDescription: `Extract text and structure from PDF documents using Mistral's OCR API.${
shouldEnableFileUpload
? ' Either enter a URL to a PDF document or upload a PDF file directly.'
: ' Enter a URL to a PDF document (.pdf extension required).'
} Configure processing options and get the content in your preferred format. For URLs, they must be publicly accessible and point to a valid PDF file. Note: Google Drive, Dropbox, and other cloud storage links are not supported; use a direct download URL from a web server instead.`,
longDescription: `Extract text and structure from PDF documents using Mistral's OCR API. Either enter a URL to a PDF document or upload a PDF file directly. Configure processing options and get the content in your preferred format. For URLs, they must be publicly accessible and point to a valid PDF file. Note: Google Drive, Dropbox, and other cloud storage links are not supported; use a direct download URL from a web server instead.`,
docsLink: 'https://docs.sim.ai/tools/mistral_parse',
category: 'tools',
bgColor: '#000000',
icon: MistralIcon,
subBlocks: [
// Show input method selection only if file upload is available
...(shouldEnableFileUpload ? [inputMethodBlock] : []),
// Show input method selection
{
id: 'inputMethod',
title: 'Select Input Method',
type: 'dropdown' as SubBlockType,
layout: 'full' as SubBlockLayout,
options: [
{ id: 'url', label: 'PDF Document URL' },
{ id: 'upload', label: 'Upload PDF Document' },
],
},
// URL input - always shown, but conditional on inputMethod in production
// URL input - conditional on inputMethod
{
id: 'filePath',
title: 'PDF Document URL',
type: 'short-input' as SubBlockType,
layout: 'full' as SubBlockLayout,
placeholder: 'Enter full URL to a PDF document (https://example.com/document.pdf)',
required: !shouldEnableFileUpload,
...(shouldEnableFileUpload
? {
condition: {
field: 'inputMethod',
value: 'url',
},
}
: {}),
condition: {
field: 'inputMethod',
value: 'url',
},
},
// File upload option - only shown in production environments
...(shouldEnableFileUpload ? [fileUploadBlock] : []),
// File upload option
{
id: 'fileUpload',
title: 'Upload PDF',
type: 'file-upload' as SubBlockType,
layout: 'full' as SubBlockLayout,
acceptedTypes: 'application/pdf',
condition: {
field: 'inputMethod',
value: 'upload',
},
maxSize: 50, // 50MB max via direct upload
},
{
id: 'resultType',
@@ -136,27 +120,19 @@ export const MistralParseBlock: BlockConfig<MistralParserOutput> = {
resultType: params.resultType || 'markdown',
}
// Set filePath or fileUpload based on input method (or directly use filePath if no method selector)
if (shouldEnableFileUpload) {
const inputMethod = params.inputMethod || 'url'
if (inputMethod === 'url') {
if (!params.filePath || params.filePath.trim() === '') {
throw new Error('PDF Document URL is required')
}
parameters.filePath = params.filePath.trim()
} else if (inputMethod === 'upload') {
if (!params.fileUpload) {
throw new Error('Please upload a PDF document')
}
// Pass the entire fileUpload object to the tool
parameters.fileUpload = params.fileUpload
}
} else {
// In local development, only URL input is available
// Set filePath or fileUpload based on input method
const inputMethod = params.inputMethod || 'url'
if (inputMethod === 'url') {
if (!params.filePath || params.filePath.trim() === '') {
throw new Error('PDF Document URL is required')
}
parameters.filePath = params.filePath.trim()
} else if (inputMethod === 'upload') {
if (!params.fileUpload) {
throw new Error('Please upload a PDF document')
}
// Pass the entire fileUpload object to the tool
parameters.fileUpload = params.fileUpload
}
// Convert pages input from string to array of numbers if provided