Commit Graph
63 Commits
Author SHA1 Message Date
agoodjuice 01d0b0ce10 [ISSUE #6085] Fix a typo 2023-02-16 08:47:34 +08:00
rongtong b0a454130e [ISSUE #5971] Make the internal logs related to the dledger in the controller print to a file separately (#5972)
* Make the internal logs related to the dledger in the controller print to a file separately

* Make the internal logs related to the dledger in the controller print to a file separately
2023-02-06 09:21:58 +08:00
rongtong 0ea930182c GetSyncStateSetSubCommand can also print that the broker is not in syncStateSet (#5935) 2023-01-28 10:08:51 +08:00
Aaron Ai e048c0f987 Fix logback warning in rmq.controller.logback.xml 2023-01-20 11:52:11 +08:00
rongtong 646d04f425 [ISSUE #5712] Fix the invalid of heartbeat detection after controller switch (#5711)
* Fix the invalid of heartbeat detection after controller switch

* Pass the checkstyle

* Format ReplicasInfoManagerTest code style
2022-12-21 10:36:57 +08:00
mxsm c4e581cf9e [ISSUE #5686] Polish ReplicasInfoManager comment and static log attribute (#5687) 2022-12-12 09:27:04 +08:00
mxsm e197297d30 [ISSUE #5676] Support for dynamic Logging in proxy and controller modules (#5677) 2022-12-11 16:13:55 +08:00
mxsm e5c3f21277 [ISSUE #5631]optimize ReplicasInfoManager#registerBroker logic (#5633)
* [ISSUE #5631]optimize ReplicasInfoManager#registerBroker logic

* fix code style
2022-12-10 22:11:59 +08:00
hzh0425 93e82c8205 [ISSUE #5569]Support broker priority election for controller mode (#5548)
* Support broker priority election for controller mode

* fix comment of brokerElectionPriority

* Set "The lower the value of brokerElectionPriority, the higher the priority of the broker being selected as the master."
2022-11-24 12:59:34 +08:00
hzh0425 bfa02529cb [ISSUE #5572]Remove useless introduction in BrokerInfo 2022-11-23 10:53:13 +08:00
hzh0425 139dad04c7 [ISSUE #5558] Fix typos in DLedgerController 2022-11-22 11:39:09 +08:00
Aaron Ai a68078fef8 [ISSUE #5484] Replace logging module with the shaded logback (#5540)
* Replace logging module with the shaded logback

* Add license header

* Fix bazel compile issue
2022-11-21 16:30:15 +08:00
rongtong d781271654 Move the header of the controller to the upper layer (#5550) 2022-11-20 21:51:32 +08:00
mxsm 5293eba547 [ISSUE #5544] Replace DLedgerServer#getdLedgerLeaderElector deprecated method (#5545) 2022-11-20 10:03:24 +08:00
hzh0425 44072e62bd [Issue #4330]Fix some comments in DefaultElectPolicy 2022-11-19 21:28:28 +08:00
yukon 506b563f55 Revert "[ISSUE #5484] Replace Logging Module with Shaded Logback (#5524)" (#5537)
This reverts commit 809ff6b3e0.
2022-11-17 20:04:17 +08:00
Aaron AiandLi Zhanhui 809ff6b3e0 [ISSUE #5484] Replace Logging Module with Shaded Logback (#5524)
* Remove ClientLogger

* WIP

* WIP

* Rename logger to log

* Make it compile

* WIP

* Fix bazel to use shaded slf4j

* Fix DeleteExpiredCommitLogSubCommandTest

* Fix pom.xml duplication

* Fix maven deps

* Add test logback configuration file

* Fix unit test output

* Fix logback configuration file

* All logging are made on top of slf4j

* Fix test log configuration file name

* Fix test log configuration file name for test module

* All logging are shaded slf4j targeted

* DLedger has an explicit dependency on slf4j

* Fix DLedger

* Fix DLeader issue

* Move logback configuration files to each module

Co-authored-by: Li Zhanhui <lizhanhui@gmail.com>
2022-11-17 00:38:28 +08:00
SSpiritsandLi Zhanhui ec5d3236f6 invert dependency between remoting and common module (#5503)
* invert dependency between remoting and common module

* fix bazel

* Fix Bazel warning of indirect dependency

* remove duplicate class ServiceThread

* fix conflict

* revert delete class ServiceThread because of introduced by dledger

Co-authored-by: Li Zhanhui <lizhanhui@gmail.com>
2022-11-11 13:34:31 +08:00
mxsm 06a5496933 [ISSUE #5324]Replace deprecated class PosixParser with DefaultParser for CLI (#5325)
* [ISSUE #5324]Replace deprecated class PosixParser with DefaultParser for CLI

* fix bazel compile UpdateAccessConfigSubCommandTest testExecute failures

* Fixed bazel compile UpdateAccessConfigSubCommandTest testExecute failures
2022-10-19 22:43:06 +08:00
mxsm db1f1839b9 [ISSUE #5298]Polish code style for jdk8+ (#5308) 2022-10-14 11:44:21 +08:00
Nowinkey 0ad7db6956 [ISSUE #5216] Enable checkstyle for test code (rocketmq-controller, rocketmq-remoting and rocketmq-proxy) (#5218)
* style(remoting):Enable checkstyle for test code

* style(controller):Enable checkstyle for test code

* style(proxy):Enable checkstyle for test code
2022-09-29 11:46:00 +08:00
Aaron Ai c185c60b0f [ISSUE #5108] Bump checkstyle to 3.2.0 (#5109)
* Bump checkstyle to 3.2.0

* Fix checkstyle
2022-09-18 11:17:36 +08:00
mxsm 7067305aa6 [ISSUE #5036] Optimize controller module Response code (#5037) 2022-09-13 20:18:58 +08:00
rongtong d97dc78bab [ISSUE #5056] Bump DLedger to 0.3.0 (#5058)
* Bump DLedger to 0.3.0

* Add new @Override function
2022-09-13 18:36:06 +08:00
TheR1sing3un de7cd0df10 [ISSUE#4959] Fix the logic when deal with a write event with empty events
* fix(controller): fix the logic when deal with a write event with empty events

1. fix the logic when deal with a write event with empty events

* style(controller): remove unused import

1. remove unused import
2022-09-01 19:48:05 +08:00
TheR1sing3un f043ca8c18 [ISSUE#4950] fix wrong typo about DLedger (#4951)
* style(controller): fix the wrong typo about DLedger

1. fix the wrong typo about DLedger

* style(controller): fix the wrong typo about DLedger

1. fix the wrong typo about DLedger
2022-08-31 20:11:17 +08:00
TheR1sing3un 7f25e453cd style(controller): fix the wrong typo about DLedger (#4930)
1. fix the wrong typo about DLedger
2022-08-30 13:38:26 +08:00
TheR1sing3un 6a8b1aa96b [ISSUE#4917] Optimize the retry logic in appending a no-op request when controller change to leader (#4918) 2022-08-30 08:43:03 +08:00
mxsm a961d1b44a [ISSUE #4817] Add a command to clear broker data from controller for CLI (#4823) 2022-08-27 19:42:55 +08:00
mxsm 64c18fb0db [ISSUE #4889]Fix controller test:DLedgerControllerTest#testChangeControllerLeader (#4892) 2022-08-26 09:06:02 +08:00
mxsm 5578808b44 [ISSUE #4873]Optimize controller module test cases execution time (#4882) 2022-08-25 14:43:44 +08:00
mxsm 0909aa91a2 [ISSUE #4857] Fix broker can't auto register to controller again (#4862) 2022-08-25 10:03:57 +08:00
Zhanhui Li 3da7ea9c1b [Infra Improvement] Build And Run Unit Tests in Parallel (#4878)
* Support build with Bazel (#4865)

* Support build with Bazel, fixing tests to make them capable of running in concurrency and hermetic.

* Make test cases capable of running in parallel. (#4874)
2022-08-24 20:53:30 +08:00
RongtongJin bbbb96e129 Revert "Support build with Bazel (#4865)"
This reverts commit ec8a93d2f7.
2022-08-23 14:29:46 +08:00
Zhanhui Li ec8a93d2f7 Support build with Bazel (#4865)
* Support build with Bazel, fixing tests to make them capable of running in concurrency and hermetic.
2022-08-23 13:11:53 +08:00
mxsm d117742e3c [ISSUE #4847]Optimize DefaultBrokerHeartbeatManager#onBrokerHeartbeat mehtod code logic (#4848) 2022-08-20 09:54:04 +08:00
TheR1sing3un c5f80713be [ISSUE #4813] Add elect policy for controller (#4809)
* feat(controller): add elect policy

1. add epoch and maxOffset in heartbeat.
2. refactor elect logic, now we
elect a new master by elect policy(can expand).
3. add some unit tests

* refactor(controller): refactor some code and format some code

1. refactor some code and format some code

* fix typo in ReplicasInfoManager

1. fix typo in ReplicasInfoManager

* fix wrong method call in ReplicasManagerTest#before

1.fix wrong method call in ReplicasManagerTest#before

* fix wrong call in ReplicasManagerTest#before

1. fix wrong call in ReplicasManagerTest#before

* fix(controller): fix the bug about ReElectMaster

1. fix the bug about ReElectMaster
2. fix some typo

* style(controller): fix typo by checkstyle

1. fix typo by checkstyle

* test(broker): fix invalid usage of "any()" in DLedegerControllerTest#before

1. fix invalid usage of "any()" in DLedegerControllerTest#before

* fix(controller): fix some wrong usage in test

1. fix some wrong usage in test
2. refactor some field type to avoid NPE
2022-08-16 08:41:51 +08:00
mxsm 06ca14a508 [ISSUE #4791] Add elect master command for admin CLI (#4798) 2022-08-11 10:06:46 +08:00
mxsm ce274265db [ISSUE #4794] Fix deserialize ElectMasterResponseHeader attribute value of brokerMemberGroup is null (#4796) 2022-08-08 17:11:14 +08:00
rongtong 0b6563b58f Add getControllerConfig and updateControllerConfig command for admin CLI (#4793) 2022-08-07 15:28:51 +08:00
mxsm c506036cb6 [ISSUE #4745] Check controllerDLegerPeers and controllerDLegerSelfId attributes before create DLedgerServer (#4768) 2022-08-04 11:16:17 +08:00
mxsm c6b3a66ecf [ISSUE #4706] fix console printed log format is incorrect (#4716) 2022-08-03 09:19:03 +08:00
mxsm bcd4a92e41 [ISSUE #4750] Fix ControllerRequestProcessor#processRequest handle CONTROLLER_GET_SYNC_STATE_DATA return incorrect (#4759) 2022-08-02 08:46:41 +08:00
mxsmandAaron Ai b875b3309a [ISSUE #4709] fix method is on the same line as @Override annotation (#4717)
Co-authored-by: Aaron Ai <yangkun.ayk@gmail.com>
2022-08-01 20:42:34 +08:00
mxsm c489a70baa [ISSUE #4734]Fix DLedgerController startScheduling concurrency problem (#4735) 2022-07-30 20:54:06 +08:00
mxsm a58b2443a4 [ISSUE #4700]Optimize print information when the rocketmqHome variable not set (#4703) 2022-07-28 09:02:41 +08:00
RongtongJin ab4f7ddbcc Pass the CI after merge develop 2022-07-08 17:55:11 +08:00
RongtongJin 5550266765 1.Rename BrokerRegisterRequestHeader to RegisterBrokerToControllerRequestHeader
2.Make ChangeToMaster do all things even if it is already master
2022-06-29 10:49:16 +08:00
RongtongJin fd8dafd5f9 ReplicasInfoManager use controller config instead of enableElectUncleanMaster so that it can be modified at run time 2022-06-17 15:50:20 +08:00
rongtong d9273e70f6 Update the logic of confirmOffset and recover topicQueueTable to prevent message loss when broker role change (#4460)
* Update the logic of confirmOffset and recover topicQueueTable to prevent message loss

* Do not dispatch when reputFromOffset + size is greater than confirmOffset to prevent message loss

* Pass the UT

* Pass the UT
2022-06-15 15:53:10 +08:00