Commit Graph
8085 Commits
Author SHA1 Message Date
rongtong 9d411cf04a Make configPath unable to update at runtime (#6733)
* Make configPath unable to update at runtime

* Make configPath unable to update at runtime

* Add ASF header

* Add ASF header

* Pass the check style

* Polish the response code

* Polish the response code
2023-05-11 18:01:29 +08:00
Ji Juntao 5dc2e20efc [ISSUE #6728] Compute the confirmOffset without considering new connections (#6729)
* 1. When compute the confirmOffset, dismiss the ackOffset of new connections. 2. When compute the confirmOffset, use getConfirmOffsetDirectly() to avoid the endless calling.

* use the calculated slaveAckOffset

* optimize the logic.
2023-05-10 20:30:16 -07:00
schopenhauerz 6b6fb17224 [ISSUE #6722] Bugfix timer thread has error when timer not enable (#6723)
* bugfix broker boot succes but get fail ip addr

bug:
broker ip addr(IPV4) get fail  after broker start up;
fix:
add compare ,continue  when ip is start with '0.' ;
like :
The broker[broker-a, 0.0.1.1:10911] boot success. serializeType=JSON and name server is 127.0.0.1:9876;

* add timerstore nil condition when timer no enable

add timerstore nil condition when timer no enable

* close timer schedule thread when timer no enable

 close timer schedule thread when timer no enable

* format code

format code
2023-05-10 01:23:12 -07:00
mxsm f33ac2a3ec [ISSUE #6714] Replace the deprecated method DefaultMQPushConsumer#getDefaultMQPushConsumerImpl (#6715) 2023-05-09 18:59:18 -07:00
mxsm 09ad52b9e1 [ISSUE #6712] Remove useless method BrokerOuterAPI#pullMessageFromSpecificBroker (#6713) 2023-05-08 18:36:43 -07:00
xuziyang bcf40a9119 [ISSUE #6516] Remove redundant code from ThreadLocalIndex (#6517) 2023-05-08 17:03:16 +08:00
Zhouxiang Zhan 0a329ba627 [ISSUE #6699] Make NotificationProcessor use PopLongPollingService (#6700)
* Refector PopLongPollingService

* Use enum PollingResult to replace int value
* Move PopLongPollingService to upper level
* Move wakeUp and polling method into PopLongPollingService

* NotificationProcessor use PopLongPollingService

* Add BORN_TIME check

* add NotificationIT
2023-05-08 11:49:02 +08:00
SSpirits 34b20950c5 chore(metrics): bump opentelemetry version to 1.26.0 (#6705)
Signed-off-by: SSpirits <admin@lv5.moe>
2023-05-06 17:23:29 +08:00
Aaron Ai 42c5fd5fbd [ISSUE #6708] Use GitHub cache for CodeQL 2023-05-06 17:13:43 +08:00
rongtong 41e9b8cf06 [ISSUE #6703] Fix the incorrect of confirmOffset when recovering abnormally caused by message loss due to asynchronous flushing after restarting 2023-05-06 17:12:47 +08:00
Ji Juntao e73a9aa8a7 [ISSUE #6706] brokerPermission cannot stop messages flow in unwritable brokers 2023-05-06 16:49:55 +08:00
Oliver 6770f92819 [ISSUE #6693]Fix the description of the acl directory in the document is incorrect (#6694) 2023-05-06 15:59:44 +08:00
Zhouxiang Zhan 2da6e9b2d6 [ISSUE #6696] Refector proxy common and client module (#6697)
* Move classes in module proxy.common to common

* Move MQClientAPIExt to client module

* fix
2023-05-06 14:19:31 +08:00
maheshnikam d9223ffd78 Update AclUtils.java (#6689) 2023-05-05 17:38:17 +08:00
lk 57642bc630 [ISSUE #6691] Support reentrant pop orderly for broker (#6692) 2023-05-05 15:06:11 +08:00
mxsm 6f6032e9eb [ISSUE #6673]Issue template enhancements (#6674)
* [ISSUE #6673]Issue template enhancements

* optimize issue template
2023-05-04 18:53:41 +08:00
Ji Juntao 709537595c [ISSUE #6665] Optimize the process of truncateInvalidMsgs() (#6666)
* 1. Fix the bug that confirmOffset may be larger than ReputOffset in some cases. 2. Optimize the logic when truncate dirty files.

* Add more logs while expanding SyncStateSet.

* reset the confirmOffset to the truncated offset.

* optimize the log.

* move setConfirmOffset() process into commitLog.

* add the judge.
2023-05-04 11:55:04 +08:00
rongtong b410557e87 [ISSUE #6609] Fix the issue that consume queue building exceeds confirmOffset when node restarts to recover (#6618)
* Fix the issue that consume queue building exceeds confirmOffset when node restarts to recover
2023-05-04 09:39:51 +08:00
mxsm b4e6acca32 [ISSUE #6686] Remove ClientManageProcessor#heartBeat repeat judgment (#6687) 2023-05-04 09:33:30 +08:00
Ji Juntao 7903c70412 [ISSUE #6662] Optimize the process of HA's confirmOffset calculation (#6663)
* When compute confirmOffset, judge whether the slaves in syncStateSet all connect to the master.

* fix the brokerId to brokerControllerId.

* optimize the code: 1. Set brokerId when the replicasManager inited. 2. Rename the confusing name.

* set haService's brokerControllerId after registered.

* set the haService's brokerControllerId when the ReplicasManager start without brokerIdentity file.
2023-05-01 14:35:52 +08:00
wangfan bcbb25fddc [ISSUE #6660] Fix semaphoreAsyncSendSize init error (#6661) 2023-04-29 19:06:39 +08:00
Zhouxiang Zhan 23a8ed490f [ISSUE #6644] Add admin client future interface (#6646)
* [ISSUE #6644] Add admin client future interface

* add unit test

* Change exception to throwable

* Add interface for MqClientAdmin
2023-04-28 17:34:16 +08:00
TheR1sing3un dcf7ccdd9b [ISSUE# 6650]: Fix using the deprecated method MessgaeStore#checkInDiskByConsumeOffset (#6651)
* fix(tieredstorage): fix using deprecated method `MessageStore#checkInDiskByConsumeOffset`

1. fix using deprecated method `MessageStore#checkInDiskByConsumeOffset`

* test(tieredstorage): replace `checkInDiskeByConsumeOffset` with `checkInStoreByConsumeOffset`

1. replace `checkInDiskeByConsumeOffset` with `checkInStoreByConsumeOffset`
2023-04-27 17:16:39 +08:00
Aaron Ai b00c82cacc Rewrite the issue/pull request template of RocketMQ (#6645) 2023-04-26 13:37:20 +08:00
TheR1sing3un 7bb061158b [ISSUE #6648]: Fix the bug that not all message fetch requests are processed via TieredStorage when level is FORCE (#6649)
* fix(tieredstorage): fix the bug that not all message fetch request is processed via tieredStorage when enable FORCE

1. fix the bug that not all message fetch request is processed via
tieredStorage when enable FORCE

* style(tieredstorage): use rmq code style

1. use rmq code style

* feat(tieredstorage): add more comments for `TieredStorageLevel`

1. add more comments for `TieredStorageLevel`
2023-04-26 11:55:21 +08:00
rongtong e3b8178871 [ISSUE #6570] Fix the issue that expectLogicOffset is greater than currentLogicOffset in consumeQueue build when the message is illegal (#6641)
* Fix the issue that expectLogicOffset is greater than currentLogicOffset in consumeQueue build when the message is illegal

* Add new UT

* Fix bug that UT can not pass

* Polish the variable name

* Polish the comment

* Add more comments
2023-04-26 11:24:47 +08:00
haiyanghan fad3dece7b [ISSUE #6537] Fix bug MessageStoreConfig.haListenPort item config not… (#6538)
* [ISSUE #6537] Fix bug MessageStoreConfig.haListenPort item config not effective

* rerun

* [ISSUE #6537] fix bug, if user not config haListenPort, then safe set haListenPort value as listenPort +1

* rerun
2023-04-25 17:16:34 +08:00
lizhiminsand斜阳 652f5bbba9 [ISSUE #6627] Fix ConsumerLagCalculator NPE if group or topic is null (#6632)
Co-authored-by: 斜阳 <terrance.lzm@alibaba-inc.com>
2023-04-25 10:25:13 +08:00
rongtong 14ad16b0d5 [ISSUE #6634] Polish the HA logs to better troubleshoot issues (#6635) 2023-04-24 10:11:01 +08:00
Zhouxiang Zhan af6a95f4c5 [ISSUE #6627] Fix ConsumerLagCalculator#processAllGroup retry topic NPE (#6628) 2023-04-21 15:50:41 +08:00
hiyo ea8b9d9f7a [ISSUE #6594] skip verification for admin user (#6613) 2023-04-19 10:31:43 +08:00
rongtong 073da6b971 Fix the issue broker startup failed when version upgrade from 5.1.0 to latest develop because compactionThreadNum is 0 (#6611) 2023-04-19 09:54:52 +08:00
dependabot[bot] 8aad756550 build(deps): bump spring-core from 5.3.26 to 5.3.27 (#6604)
Bumps [spring-core](https://github.com/spring-projects/spring-framework) from 5.3.26 to 5.3.27.
- [Release notes](https://github.com/spring-projects/spring-framework/releases)
- [Commits](https://github.com/spring-projects/spring-framework/compare/v5.3.26...v5.3.27)

---
updated-dependencies:
- dependency-name: org.springframework:spring-core
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-04-19 09:53:46 +08:00
Ao Qiao f9f7147676 [ISSUE #6612] Prevent redundant validator in accessValidatorList (#6615)
* change map -> lambda

* f

* fix unit test

* remove getTopicConfig function

* Update MultiDispatchTest.java

* Update CompactionStore.java

* update

* update test

* update test

* Update BatchConsumeMessageTest.java

* Update BrokerController.java

* Update BrokerController.java

* check

* Update BrokerController.java

* Update BatchConsumeMessageTest.java

* prevent redundant validator

* fix

* ci

* ci

* Update AuthenticationPipeline.java

* Update RemotingProtocolServer.java

* Update AuthenticationPipeline.java

* Update RemotingProtocolServer.java
2023-04-18 23:30:50 +08:00
Robin HanandRobin Han b3868ab606 (fix): logback config path seperator and brokerLogDir default value m… (#6590)
* (fix): logback config path seperator and brokerLogDir default value missing

* (fix): replace / with file.seperator in proxy test logback config

---------

Co-authored-by: Robin Han <robin@Robindendiannao.lan>
2023-04-18 16:48:34 +08:00
Oliver ca006ca9ab [ISSUE #6591] Fix Starting nameserver and broker failed because the default java command in Darwin contained Spaces (#6592) 2023-04-18 14:07:01 +08:00
Ao Qiao 3fe81bfbac [ISSUE #6545] Remove getTopicConfigs method in interface MessageStore (#6531)
* change map -> lambda

* f

* fix unit test

* remove getTopicConfig function

* Update MultiDispatchTest.java

* Update CompactionStore.java

* update

* update test

* update test

* Update BatchConsumeMessageTest.java

* Update BrokerController.java

* Update BrokerController.java

* check

* Update BrokerController.java

* Update BatchConsumeMessageTest.java
2023-04-15 18:22:06 +08:00
Abhijeet Mishra d1b14b0ff9 [ISSUE #6525]Make ConsumeQueueInterface extends from FileQueueLifeCycle (#6534)
* [#6525] Make ConsumeQueueInterface extends from FileQueueLifeCycle

* [apache#6525] forced typecast is removed

* [#6525] remove all the forced convert
2023-04-15 18:21:03 +08:00
guyinyouandguyinyou d3a8fe0c5b [ISSUE #6587] fix getMax() in SparseConsumeQueue
Co-authored-by: guyinyou <guyinyou.gyy@alibaba-inc.com>
2023-04-14 11:26:11 +08:00
lyx d34a28bb31 [ISSUE #6513] fix(proxy): enhance ProxyContext (#6522)
* feat(proxy): improve proxy context

Signed-off-by: lyx <1419360299@qq.com>

* fix(proxy): rollback to fullname for compatibility

Signed-off-by: lyx2000 <1419360299@qq.com>

* fix(proxy): use simple_rpc_name add to ProxyContext action

Signed-off-by: lyx <1419360299@qq.com>

* fix(proxy): improve naming

Signed-off-by: lyx <1419360299@qq.com>

---------

Signed-off-by: lyx <1419360299@qq.com>
Signed-off-by: lyx2000 <1419360299@qq.com>
2023-04-13 19:59:06 +08:00
mxsm d9a7315ffe [ISSUE #6584] Fix AppendMessageCallback comments typo (#6585) 2023-04-13 10:37:26 +08:00
rongtong baad0a427f [ISSUE #6579] Prevent the properties of trace message from exceeding the maximum value of short (#6580)
* Prevent the properties of trace message from exceeding the maximum value of short

* Use reduce instead of foreach
2023-04-13 09:17:58 +08:00
yueyaandAaron Ai 938b5bb929 [ISSUE #6581]Add a description of the Apache RocketMQ E2E repository in README.md (#6582)
* Add a description of the Apache RocketMQ E2E repository in README.md

* Update README.md

Co-authored-by: Aaron Ai <yangkun.ayk@gmail.com>

---------

Co-authored-by: Aaron Ai <yangkun.ayk@gmail.com>
2023-04-12 18:14:59 +08:00
Aaron Ai f44a1c3fd5 Update the image of bazel-build to ubuntu-latest (#6569) 2023-04-11 17:17:10 +08:00
lk 7dc9942fe2 [ISSUE #6547] Some RemotingChannel calls need to be forwarded to the original Channel (#6548) 2023-04-11 10:33:44 +08:00
CoderBruisandhaiyang.luo cb53fa572e remove (#6564)
Co-authored-by: haiyang.luo <apple@haiyang.luo>
2023-04-10 18:05:50 +08:00
Aaron Ai 465bfcf802 Upgrade the image to the latest version (#6562) 2023-04-10 12:54:40 +08:00
Aaron Ai e55e5e204d Temporary removal of required maven-compile status check (#6561) 2023-04-10 11:53:47 +08:00
hardyfish 9574165fe3 [ISSUE #6299] Remove TimerFlushService#run duplicate code (#6300) 2023-04-06 10:19:04 +08:00
schopenhauerz a258a301d4 [ISSUE #6436] Fix broker boot succes but get wrong ip address (#6437) 2023-04-04 13:56:24 +08:00