opensource/rocketmq
3
0
Fork 0
mirror of https://github.com/apache/rocketmq.git synced 2026-09-01 15:47:01 +08:00
Code Issues Packages Projects Releases Wiki Activity

Delay plant log appender in client loggger (#1266)

Browse Source
This commit is contained in:
dinglei
2019-06-18 17:51:43 +08:00
committed by GitHub
parent bf2a7e5108
commit ea88c4b73f
1 changed files with 28 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
client/src/main/java/org/apache/rocketmq/client/log/ClientLogger.java
+28 -7
View File
@@ -25,6 +25,7 @@ import org.apache.rocketmq.logging.inner.Layout;
import org.apache.rocketmq.logging.inner.Level;
import org.apache.rocketmq.logging.inner.Logger;
import org.apache.rocketmq.logging.inner.LoggingBuilder;
import org.apache.rocketmq.logging.inner.LoggingEvent;
import org.apache.rocketmq.remoting.common.RemotingHelper;
public class ClientLogger {
@@ -43,7 +44,7 @@ public class ClientLogger {
private static final boolean CLIENT_USE_SLF4J;
private static Appender rocketmqClientAppender = null;
//private static Appender rocketmqClientAppender = null;
static {
CLIENT_USE_SLF4J = Boolean.parseBoolean(System.getProperty(CLIENT_LOG_USESLF4J, "false"));
@@ -57,7 +58,7 @@ public class ClientLogger {
}
}
private static synchronized void createClientAppender() {
private static synchronized Appender createClientAppender() {
String clientLogRoot = System.getProperty(CLIENT_LOG_ROOT, System.getProperty("user.home") + "/logs/rocketmqlogs");
String clientLogMaxIndex = System.getProperty(CLIENT_LOG_MAXINDEX, "10");
String clientLogFileName = System.getProperty(CLIENT_LOG_FILENAME, "rocketmq_client.log");
@@ -71,11 +72,12 @@ public class ClientLogger {
Layout layout = LoggingBuilder.newLayoutBuilder().withDefaultLayout().build();
rocketmqClientAppender = LoggingBuilder.newAppenderBuilder()
Appender rocketmqClientAppender = LoggingBuilder.newAppenderBuilder()
.withRollingFileAppender(logFileName, maxFileSize, maxFileIndex)
.withAsync(false, queueSize).withName(ROCKETMQ_CLIENT_APPENDER_NAME).withLayout(layout).build();
Logger.getRootLogger().addAppender(rocketmqClientAppender);
return rocketmqClientAppender;
}
private static InternalLogger createLogger(final String loggerName) {
@@ -85,11 +87,11 @@ public class ClientLogger {
InnerLoggerFactory.InnerLogger innerLogger = (InnerLoggerFactory.InnerLogger) logger;
Logger realLogger = innerLogger.getLogger();
if (rocketmqClientAppender == null) {
createClientAppender();
}
//if (rocketmqClientAppender == null) {
// createClientAppender();
//}
realLogger.addAppender(rocketmqClientAppender);
realLogger.addAppender(new AppenderProxy());
realLogger.setLevel(Level.toLevel(clientLogLevel));
realLogger.setAdditivity(additive);
return logger;
@@ -98,4 +100,23 @@ public class ClientLogger {
public static InternalLogger getLog() {
return CLIENT_LOGGER;
}
static class AppenderProxy extends Appender {
private Appender proxy;
@Override
protected void append(LoggingEvent event) {
if (null == proxy) {
proxy = ClientLogger.createClientAppender();
}
proxy.doAppend(event);
}
@Override
public void close() {
if (null != proxy) {
proxy.close();
}
}
}
}