[ISSUE #3949] change toString to toStringHelper

acl/src/main/java/org/apache/rocketmq/acl/common/AuthenticationHeader.java

@@ -17,6 +17,8 @@
 
 package org.apache.rocketmq.acl.common;
 
+import com.google.common.base.MoreObjects;
+
 public class AuthenticationHeader {
     private String remoteAddress;
     private String tenantId;
@@ -217,19 +219,18 @@ public class AuthenticationHeader {
     }
 
     @Override public String toString() {
-        final StringBuilder sb = new StringBuilder("MetadataHeader{");
-        sb.append("remoteAddress='").append(remoteAddress).append('\'');
-        sb.append(", tenantId='").append(tenantId).append('\'');
-        sb.append(", namespace='").append(namespace).append('\'');
-        sb.append(", authorization='").append(authorization).append('\'');
-        sb.append(", datetime='").append(datetime).append('\'');
-        sb.append(", sessionToken='").append(sessionToken).append('\'');
-        sb.append(", requestId='").append(requestId).append('\'');
-        sb.append(", language='").append(language).append('\'');
-        sb.append(", clientVersion='").append(clientVersion).append('\'');
-        sb.append(", protocol='").append(protocol).append('\'');
-        sb.append(", requestCode=").append(requestCode);
-        sb.append('}');
-        return sb.toString();
+        return MoreObjects.toStringHelper(this)
+            .add("remoteAddress", remoteAddress)
+            .add("tenantId", tenantId)
+            .add("namespace", namespace)
+            .add("authorization", authorization)
+            .add("datetime", datetime)
+            .add("sessionToken", sessionToken)
+            .add("requestId", requestId)
+            .add("language", language)
+            .add("clientVersion", clientVersion)
+            .add("protocol", protocol)
+            .add("requestCode", requestCode)
+            .toString();
     }
 }

acl/src/main/java/org/apache/rocketmq/acl/common/AuthorizationHeader.java

@@ -17,6 +17,7 @@
 
 package org.apache.rocketmq.acl.common;
 
+import com.google.common.base.MoreObjects;
 import java.util.Arrays;
 import org.apache.commons.codec.DecoderException;
 import org.apache.commons.codec.binary.Base64;
@@ -111,11 +112,11 @@ public class AuthorizationHeader {
     }
 
     @Override public String toString() {
-        return "AuthorizationHeader{" +
-            "method='" + method + '\'' +
-            ", accessKey='" + accessKey + '\'' +
-            ", signedHeaders=" + Arrays.toString(signedHeaders) +
-            ", signature='" + signature + '\'' +
-            '}';
+        return MoreObjects.toStringHelper(this)
+            .add("method", method)
+            .add("accessKey", accessKey)
+            .add("signedHeaders", signedHeaders)
+            .add("signature", signature)
+            .toString();
     }
 }

broker/src/main/java/org/apache/rocketmq/broker/client/ProducerChangeListener.java

@@ -16,6 +16,11 @@
  */
 package org.apache.rocketmq.broker.client;
 
+/**
+ * producer manager will call this listener when something happen
+ * <p>
+ * event type: {@link ProducerGroupEvent}
+ */
 public interface ProducerChangeListener {
 
     void handle(ProducerGroupEvent event, String group, ClientChannelInfo clientChannelInfo);

common/src/main/java/org/apache/rocketmq/common/thread/ThreadPoolWrapper.java

@@ -17,6 +17,7 @@
 
 package org.apache.rocketmq.common.thread;
 
+import com.google.common.base.MoreObjects;
 import com.google.common.base.Objects;
 import java.util.List;
 import java.util.concurrent.ThreadPoolExecutor;
@@ -110,15 +111,10 @@ public class ThreadPoolWrapper {
     }
 
     @Override public String toString() {
-        final StringBuilder sb = new StringBuilder("ThreadPoolWrapper{");
-        sb.append("name='")
-            .append(name)
-            .append('\'');
-        sb.append(", threadPoolExecutor=")
-            .append(threadPoolExecutor);
-        sb.append(", statusPrinters=")
-            .append(statusPrinters);
-        sb.append('}');
-        return sb.toString();
+        return MoreObjects.toStringHelper(this)
+            .add("name", name)
+            .add("threadPoolExecutor", threadPoolExecutor)
+            .add("statusPrinters", statusPrinters)
+            .toString();
     }
 }

proxy/src/main/java/org/apache/rocketmq/proxy/service/route/MessageQueueView.java

@@ -16,6 +16,7 @@
  */
 package org.apache.rocketmq.proxy.service.route;
 
+import com.google.common.base.MoreObjects;
 import org.apache.rocketmq.common.protocol.route.TopicRouteData;
 
 public class MessageQueueView {
@@ -52,12 +53,11 @@ public class MessageQueueView {
         return writeSelector;
     }
 
-    @Override
-    public String toString() {
-        return "MessageQueueView{" +
-            "readSelector=" + readSelector +
-            ", writeSelector=" + writeSelector +
-            ", topicRouteWrapper=" + topicRouteWrapper +
-            '}';
+    @Override public String toString() {
+        return MoreObjects.toStringHelper(this)
+            .add("readSelector", readSelector)
+            .add("writeSelector", writeSelector)
+            .add("topicRouteWrapper", topicRouteWrapper)
+            .toString();
     }
 }