opensource/rocketmq
3
0
Fork 0
mirror of https://github.com/apache/rocketmq.git synced 2026-09-21 13:49:50 +08:00
Code Issues Packages Projects Releases Wiki Activity

Unnecessary boxing of primitives (#3596)

Browse Source 
Co-authored-by: zh378814 <wb-zh378814@alibaba-inc.com>
This commit is contained in:
zhaohai
2021-12-07 12:35:43 +08:00
committed by GitHub
co-authored by zh378814
parent 83accb6f12
commit a779d69862
5 changed files with 9 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
acl/src/main/java/org/apache/rocketmq/acl/common/AclUtils.java
+1 -1
View File
@@ -163,7 +163,7 @@ public class AclUtils {
}
public static boolean isScope(String num) {
return isScope(Integer.valueOf(num.trim()));
return isScope(Integer.parseInt(num.trim()));
}
public static boolean isScope(int num) {
acl/src/main/java/org/apache/rocketmq/acl/plain/RemoteAddressStrategyFactory.java
+2 -2
View File
@@ -187,8 +187,8 @@ public class RemoteAddressStrategyFactory {
}
String[] valueArray = StringUtils.split(value, "-");
this.start = Integer.valueOf(valueArray[0]);
this.end = Integer.valueOf(valueArray[1]);
this.start = Integer.parseInt(valueArray[0]);
this.end = Integer.parseInt(valueArray[1]);
if (!(AclUtils.isScope(end) && AclUtils.isScope(start) && start <= end)) {
throw new AclException(String.format("RangeRemoteAddressStrategy netaddress examine scope Exception start is %s , end is %s", start, end));
}
broker/src/main/java/org/apache/rocketmq/broker/transaction/queue/TransactionalMessageServiceImpl.java
+2 -2
View File
@@ -393,7 +393,7 @@ public class TransactionalMessageServiceImpl implements TransactionalMessageServ
private Long getLong(String s) {
long v = -1;
try {
v = Long.valueOf(s);
v = Long.parseLong(s);
} catch (Exception e) {
log.error("GetLong error", e);
}
@@ -404,7 +404,7 @@ public class TransactionalMessageServiceImpl implements TransactionalMessageServ
private Integer getInt(String s) {
int v = -1;
try {
v = Integer.valueOf(s);
v = Integer.parseInt(s);
} catch (Exception e) {
log.error("GetInt error", e);
}
store/src/main/java/org/apache/rocketmq/store/dledger/DLedgerCommitLog.java
+1 -1
View File
@@ -94,7 +94,7 @@ public class DLedgerCommitLog extends CommitLog {
dLedgerConfig.setPreferredLeaderId(defaultMessageStore.getMessageStoreConfig().getPreferredLeaderId());
dLedgerConfig.setEnableBatchPush(defaultMessageStore.getMessageStoreConfig().isEnableBatchPush());
id = Integer.valueOf(dLedgerConfig.getSelfId().substring(1)) + 1;
id = Integer.parseInt(dLedgerConfig.getSelfId().substring(1)) + 1;
dLedgerServer = new DLedgerServer(dLedgerConfig);
dLedgerFileStore = (DLedgerMmapFileStore) dLedgerServer.getdLedgerStore();
DLedgerMmapFileStore.AppendHook appendHook = (entry, buffer, bodyOffset) -> {
tools/src/main/java/org/apache/rocketmq/tools/command/queue/QueryConsumeQueueCommand.java
+3 -3
View File
@@ -92,9 +92,9 @@ public class QueryConsumeQueueCommand implements SubCommand {
defaultMQAdminExt.start();
String topic = commandLine.getOptionValue("t").trim();
int queueId = Integer.valueOf(commandLine.getOptionValue("q").trim());
long index = Long.valueOf(commandLine.getOptionValue("i").trim());
int count = Integer.valueOf(commandLine.getOptionValue("c", "10").trim());
int queueId = Integer.parseInt(commandLine.getOptionValue("q").trim());
long index = Long.parseLong(commandLine.getOptionValue("i").trim());
int count = Integer.parseInt(commandLine.getOptionValue("c", "10").trim());
String broker = null;
if (commandLine.hasOption("b")) {
broker = commandLine.getOptionValue("b").trim();