opensource/rocketmq
3
0
Fork 0
mirror of https://github.com/apache/rocketmq.git synced 2026-09-24 16:04:00 +08:00
Code Issues Packages Projects Releases Wiki Activity

[ISSUE #1843] fix: broker panic when producer send to retry topic (#1844)

Browse Source 
producer send message to retry topic directly, broker will panic
because maxReconsumeTimes is null and convert to int.

add null check for maxReconsumeTimes

Closes #1843
This commit is contained in:
xujianhai666
2021-12-20 21:54:02 +08:00
committed by GitHub
parent e4394b6cbe
commit 86c1216957
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
broker/src/main/java/org/apache/rocketmq/broker/processor/SendMessageProcessor.java
+1 -1
View File
@@ -358,7 +358,7 @@ public class SendMessageProcessor extends AbstractSendMessageProcessor implement
}
int maxReconsumeTimes = subscriptionGroupConfig.getRetryMaxTimes();
if (request.getVersion() >= MQVersion.Version.V3_4_9.ordinal()) {
if (request.getVersion() >= MQVersion.Version.V3_4_9.ordinal() && requestHeader.getMaxReconsumeTimes() != null) {
maxReconsumeTimes = requestHeader.getMaxReconsumeTimes();
}
int reconsumeTimes = requestHeader.getReconsumeTimes() == null ? 0 : requestHeader.getReconsumeTimes();