opensource/rocketmq
3
0
Fork 0
mirror of https://github.com/apache/rocketmq.git synced 2026-08-28 20:09:14 +08:00
Code Issues Packages Projects Releases Wiki Activity

[ISSUE #9947] Fix TimerMessageStore.checkAndReviseMetrics throws BufferUnderflowException (#9948)

Browse Source
This commit is contained in:
gaoyf
2025-12-24 11:27:59 +08:00
committed by GitHub
parent 79e700312a
commit 541fdad0ff
2 changed files with 39 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
store/src/main/java/org/apache/rocketmq/store/timer/TimerMessageStore.java
+3
View File
@@ -1344,6 +1344,9 @@ public class TimerMessageStore {
bf.getInt();//size
bf.getLong();//prev pos
int magic = bf.getInt(); //magic
if (magic == TimerLog.BLANK_MAGIC_CODE) {
break;
}
long enqueueTime = bf.getLong();
long delayedTime = bf.getInt() + enqueueTime;
long offsetPy = bf.getLong();
store/src/test/java/org/apache/rocketmq/store/timer/TimerLogTest.java
+36
View File
@@ -97,6 +97,42 @@ public class TimerLogTest {
assertArrayEquals(expect, data);
}
@Test
public void testAppendBlankByteBuffer() throws Exception {
TimerLog timerLog = createTimerLog(null);
ByteBuffer byteBuffer = ByteBuffer.allocate(TimerLog.UNIT_SIZE);
byteBuffer.putInt(TimerLog.UNIT_SIZE);
byteBuffer.putLong(Long.MAX_VALUE);
byteBuffer.putInt(0);
byteBuffer.putLong(Long.MAX_VALUE);
byteBuffer.putInt(0);
byteBuffer.putLong(1000);
byteBuffer.putInt(10);
byteBuffer.putInt(123);
byteBuffer.putInt(0);
int maxAppend = 1024 / TimerLog.UNIT_SIZE + 1;
for (int i = 0; i < maxAppend; i++) {
timerLog.append(byteBuffer.array(), 0, TimerLog.UNIT_SIZE);
}
SelectMappedBufferResult sbr = timerLog.getWholeBuffer(0);
ByteBuffer bf = sbr.getByteBuffer();
for (int position = 0; position < sbr.getSize(); position += TimerLog.UNIT_SIZE) {
bf.position(position);
bf.getInt();
bf.getLong();
int magic = bf.getInt();
if (position / TimerLog.UNIT_SIZE == maxAppend - 1) {
assertEquals(TimerLog.BLANK_MAGIC_CODE, magic);
continue;
}
bf.getLong();
bf.getInt();
bf.getLong();
bf.getInt();
bf.getInt();
}
}
@After
public void shutdown() {
for (TimerLog timerLog : timerLogs) {