opensource/rocketmq
3
0
Fork 0
mirror of https://github.com/apache/rocketmq.git synced 2026-09-01 15:47:01 +08:00
Code Issues Packages Projects Releases Wiki Activity

Avoid NPE for handling client settings null in notifyClientTermination. (#9308)

Browse Source
This commit is contained in:
Jixiang Jin
2025-04-02 18:54:07 +08:00
committed by GitHub
parent 586a274839
commit 445b94514a
1 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
proxy/src/main/java/org/apache/rocketmq/proxy/grpc/v2/client/ClientActivity.java
+6
View File
@@ -138,6 +138,12 @@ public class ClientActivity extends AbstractMessingActivity {
String clientId = ctx.getClientID();
LanguageCode languageCode = LanguageCode.valueOf(ctx.getLanguage());
Settings clientSettings = grpcClientSettingsManager.removeAndGetClientSettings(ctx);
if (clientSettings == null) {
future.complete(NotifyClientTerminationResponse.newBuilder()
.setStatus(ResponseBuilder.getInstance().buildStatus(Code.UNRECOGNIZED_CLIENT_TYPE, "cannot find client settings for this client"))
.build());
return future;
}
switch (clientSettings.getClientType()) {
case PRODUCER: