opensource/rocketmq
3
0
Fork 0
mirror of https://github.com/apache/rocketmq.git synced 2026-08-29 04:13:00 +08:00
Code Issues Packages Projects Releases Wiki Activity

[ISSUE #7822] fix NettyRemotingClient can't connect to IPv6 address. (#7823)

Browse Source 
* #7822 fix NettyRemotingClient can't connect to IPv6 address.

* #7822 fix NettyRemotingClient can't connect to IPv6 address.
This commit is contained in:
kaikoo
2024-02-09 00:20:40 +08:00
committed by GitHub
parent 5e61354fdc
commit 3acc262ab4
2 changed files with 19 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
remoting/src/main/java/org/apache/rocketmq/remoting/netty/NettyRemotingClient.java
+3 -2
View File
@@ -351,9 +351,10 @@ public class NettyRemotingClient extends NettyRemotingAbstract implements Remoti
return bootstrap;
}
// Do not use RemotingUtil, it will directly resolve the domain
// Do not use RemotingHelper.string2SocketAddress(), it will directly resolve the domain
private String[] getHostAndPort(String address) {
return address.split(":");
int split = address.lastIndexOf(":");
return split < 0 ? new String[]{address} : new String[]{address.substring(0, split), address.substring(split + 1)};
}
@Override
remoting/src/test/java/org/apache/rocketmq/remoting/netty/NettyRemotingClientTest.java
+16
View File
@@ -16,9 +16,12 @@
*/
package org.apache.rocketmq.remoting.netty;
import io.netty.bootstrap.Bootstrap;
import io.netty.channel.Channel;
import io.netty.channel.ChannelFuture;
import io.netty.channel.local.LocalChannel;
import java.lang.reflect.Field;
import java.util.concurrent.CompletableFuture;
import java.util.concurrent.ExecutionException;
import java.util.concurrent.ExecutorService;
@@ -50,6 +53,7 @@ import static org.mockito.ArgumentMatchers.eq;
import static org.mockito.Mockito.doReturn;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.never;
import static org.mockito.Mockito.spy;
import static org.mockito.Mockito.times;
import static org.mockito.Mockito.verify;
@@ -290,4 +294,16 @@ public class NettyRemotingClientTest {
verify(rpcHookMock).doBeforeRequest(anyString(), eq(request));
verify(rpcHookMock, never()).doAfterResponse(anyString(), eq(request), any());
}
@Test
public void testIsAddressReachableFail() throws NoSuchFieldException, IllegalAccessException {
Bootstrap bootstrap = spy(Bootstrap.class);
Field field = NettyRemotingClient.class.getDeclaredField("bootstrap");
field.setAccessible(true);
field.set(remotingClient, bootstrap);
assertThat(remotingClient.isAddressReachable("0.0.0.0:8080")).isFalse();
verify(bootstrap).connect(eq("0.0.0.0"), eq(8080));
assertThat(remotingClient.isAddressReachable("[fe80::]:8080")).isFalse();
verify(bootstrap).connect(eq("[fe80::]"), eq(8080));
}
}