opensource/rocketmq
3
0
Fork 0
mirror of https://github.com/apache/rocketmq.git synced 2026-08-30 18:10:44 +08:00
Code Issues Packages Projects Releases Wiki Activity

[ISSUE #9821] Fix getBrokerConfig no response issue for empty parameters (#9822)

Browse Source 
* [ISSUE #9821] Fix getBrokerConfig no response issue for empty parameters

* Update

* Update test
This commit is contained in:
yx9o
2025-11-12 11:18:40 +08:00
committed by GitHub
parent e4170f561c
commit 12f8db1e23
2 changed files with 7 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tools/src/main/java/org/apache/rocketmq/tools/command/broker/GetBrokerConfigCommand.java
+6 -7
View File
@@ -25,6 +25,7 @@ import java.util.Properties;
import org.apache.commons.cli.CommandLine;
import org.apache.commons.cli.Option;
import org.apache.commons.cli.OptionGroup;
import org.apache.commons.cli.Options;
import org.apache.rocketmq.client.exception.MQBrokerException;
import org.apache.rocketmq.remoting.RPCHook;
@@ -50,13 +51,11 @@ public class GetBrokerConfigCommand implements SubCommand {
@Override
public Options buildCommandlineOptions(final Options options) {
Option opt = new Option("b", "brokerAddr", true, "get which broker");
opt.setRequired(false);
options.addOption(opt);
opt = new Option("c", "clusterName", true, "get which cluster");
opt.setRequired(false);
options.addOption(opt);
OptionGroup group = new OptionGroup();
group.addOption(new Option("b", "brokerAddr", true, "get which broker"));
group.addOption(new Option("c", "clusterName", true, "get which cluster"));
group.setRequired(true);
options.addOptionGroup(group);
return options;
}
tools/src/test/java/org/apache/rocketmq/tools/command/broker/GetBrokerConfigCommandTest.java
+1 -1
View File
@@ -48,7 +48,7 @@ public class GetBrokerConfigCommandTest extends ServerResponseMocker {
public void testExecute() throws SubCommandException {
GetBrokerConfigCommand cmd = new GetBrokerConfigCommand();
Options options = ServerUtil.buildCommandlineOptions(new Options());
String[] subargs = new String[] {"-b 127.0.0.1:" + listenPort(), "-c default-cluster"};
String[] subargs = new String[] {"-b 127.0.0.1:" + listenPort()};
final CommandLine commandLine =
ServerUtil.parseCmdLine("mqadmin " + cmd.commandName(), subargs,
cmd.buildCommandlineOptions(options), new DefaultParser());