Fix v1.60.0 release guard coverage

2026-10-16 15:34:08 +08:00 · 2026-06-08 03:03:07 +08:00
parent 1929b94beb
commit 959111bbce
3 changed files with 134 additions and 5 deletions
@@ -92,8 +92,7 @@ function macNotarizeOptions({
  }

  const appleId = env.APPLE_ID;
-  const appleIdPassword =
-    env.APPLE_APP_SPECIFIC_PASSWORD || env.APPLE_PASSWORD;
+  const appleIdPassword = env.APPLE_APP_SPECIFIC_PASSWORD || env.APPLE_PASSWORD;
  const teamId = env.APPLE_TEAM_ID;
  if (!appleId || !appleIdPassword || !teamId) {
    return undefined;
@@ -0,0 +1,130 @@
+import { describe, expect, it } from "vitest";
+
+import forgeConfig, {
+  ignorePackagerInput,
+  macNotarizeOptions,
+  macSignOptions,
+  macZipConfig,
+  squirrelConfig,
+  updateFeedLabel,
+  updateFeedUrl,
+  windowsSigningOptions,
+} from "../../forge.config.mjs";
+
+describe("Electron Forge config", () => {
+  it("keeps Forge official makers as the packaging fact source", () => {
+    expect(forgeConfig.outDir).toBe(
+      process.env.LIME_ELECTRON_FORGE_OUT_DIR || "release-electron",
+    );
+    expect(forgeConfig.makers.map((maker) => maker.name)).toEqual([
+      "dmg",
+      "zip",
+      "squirrel",
+    ]);
+    expect(forgeConfig.makers[0].platformsToMakeOn).toEqual(["darwin"]);
+    expect(forgeConfig.makers[1].platformsToMakeOn).toEqual(["darwin"]);
+    expect(forgeConfig.makers[2].platformsToMakeOn).toEqual(["win32"]);
+  });
+
+  it("builds macOS signing and notarization options only from GitHub Actions env", () => {
+    const env = {
+      APPLE_ID: "release@example.com",
+      APPLE_PASSWORD: "app-specific-password",
+      APPLE_SIGNING_IDENTITY: "Developer ID Application: Lime",
+      APPLE_TEAM_ID: "TEAM123456",
+      LIME_ELECTRON_SIGN: "1",
+      LIME_MACOS_KEYCHAIN: "/tmp/lime.keychain-db",
+    };
+
+    expect(macSignOptions({ env, platform: "darwin" })).toEqual({
+      hardenedRuntime: true,
+      entitlements: "lime-rs/entitlements.plist",
+      "entitlements-inherit": "lime-rs/entitlements.plist",
+      identity: "Developer ID Application: Lime",
+      keychain: "/tmp/lime.keychain-db",
+    });
+    expect(macNotarizeOptions({ env, platform: "darwin" })).toEqual({
+      appleId: "release@example.com",
+      appleIdPassword: "app-specific-password",
+      teamId: "TEAM123456",
+    });
+    expect(macSignOptions({ env, platform: "win32" })).toBeUndefined();
+    expect(
+      macNotarizeOptions({
+        env: { ...env, APPLE_PASSWORD: "" },
+        platform: "darwin",
+      }),
+    ).toBeUndefined();
+  });
+
+  it("builds updater feed URLs from explicit env or platform feed labels", () => {
+    expect(updateFeedLabel("darwin", "arm64")).toBe("darwin-arm64");
+    expect(updateFeedLabel("darwin", "x64")).toBe("darwin-x64");
+    expect(updateFeedLabel("win32", "x64")).toBe("win32-x64");
+    expect(
+      updateFeedUrl("darwin", "arm64", {
+        env: { LIME_UPDATES_BASE_URL: "https://updates.example/" },
+      }),
+    ).toBe("https://updates.example/lime/stable/darwin-arm64");
+    expect(
+      updateFeedUrl("win32", "x64", {
+        env: { LIME_ELECTRON_UPDATES_URL: "https://feed.example/win32-x64/" },
+      }),
+    ).toBe("https://feed.example/win32-x64");
+    expect(
+      macZipConfig("x64", {
+        env: { LIME_UPDATES_BASE_URL: "https://updates.example" },
+      }),
+    ).toEqual({
+      macUpdateManifestBaseUrl:
+        "https://updates.example/lime/stable/darwin-x64",
+    });
+  });
+
+  it("maps Windows GitHub Actions PFX env into Forge Squirrel signing config", () => {
+    const env = {
+      LIME_ELECTRON_SIGN: "1",
+      LIME_UPDATES_BASE_URL: "https://updates.example/",
+      LIME_WINDOWS_SIGNING_CERTIFICATE_FILE: " C:/certs/lime.pfx ",
+      LIME_WINDOWS_SIGNING_CERTIFICATE_PASSWORD: "secret",
+    };
+
+    expect(windowsSigningOptions({ env, platform: "win32" })).toEqual({
+      certificateFile: "C:/certs/lime.pfx",
+      certificatePassword: "secret",
+    });
+    expect(
+      squirrelConfig("x64", {
+        env,
+        packageVersion: "9.8.7",
+        platform: "win32",
+      }),
+    ).toEqual({
+      authors: "Lime",
+      certificateFile: "C:/certs/lime.pfx",
+      certificatePassword: "secret",
+      exe: "Lime.exe",
+      name: "lime",
+      noMsi: true,
+      remoteReleases: "https://updates.example/lime/stable/win32-x64",
+      setupExe: "Lime-9.8.7 Setup.exe",
+      setupIcon: "lime-rs/icons/icon.ico",
+    });
+    expect(windowsSigningOptions({ env, platform: "darwin" })).toEqual({});
+  });
+
+  it("keeps required packaged app inputs while ignoring repository-only sources", () => {
+    expect(ignorePackagerInput(`${process.cwd()}/package.json`)).toBe(false);
+    expect(ignorePackagerInput(`${process.cwd()}/dist/index.html`)).toBe(false);
+    expect(ignorePackagerInput(`${process.cwd()}/dist-electron/main`)).toBe(
+      false,
+    );
+    expect(
+      ignorePackagerInput(`${process.cwd()}/dist-electron/preload/index.js`),
+    ).toBe(false);
+    expect(ignorePackagerInput(`${process.cwd()}/src/App.tsx`)).toBe(true);
+    expect(
+      ignorePackagerInput(`${process.cwd()}/scripts/electron/smoke.mjs`),
+    ).toBe(true);
+  });
+});
@@ -373,8 +373,8 @@ function assertForgeConfig(forgeConfigPath = DEFAULT_FORGE_CONFIG_PATH) {
    '["darwin"]',
    '["win32"]',
    "macUpdateManifestBaseUrl",
-    'updateFeedUrl("darwin", arch)',
-    'updateFeedUrl("win32", arch)',
+    'updateFeedUrl("darwin", arch',
+    'updateFeedUrl("win32", arch',
    "RELEASE_OUTPUT_DIR",
    "LIME_ELECTRON_FORGE_OUT_DIR",
    "dist-electron/app-server.release.json",
@@ -413,7 +413,7 @@ function assertForgeConfig(forgeConfigPath = DEFAULT_FORGE_CONFIG_PATH) {
    "Setup.exe",
    "setupIcon",
    "lime-rs/icons/icon.ico",
-    "...windowsSigningOptions()",
+    "...windowsSigningOptions(options)",
  ]) {
    assertIncludes(forgeConfig, required, "Forge Windows Squirrel config");
  }