opensource/obs-studio
3
0
Fork 0
mirror of https://github.com/obsproject/obs-studio.git synced 2026-08-29 02:03:03 +08:00
Code Issues Packages Projects Releases Wiki Activity

libobs/util: Reject plugins linking Qt5 library for Linux

Browse Source 
Since obs-studio switched to Qt6, old plugins linking Qt5 should be
rejected. On Linux system, OBS and it's plugins link the system
libraries so that obs could be crashed by such plugins that links Qt5
when Qt5 functions are called.

Co-authored-by: Norihiro Kamae <norihiro@nagater.net>
This commit is contained in:
Kurt Kartaltepe
2022-09-03 07:31:01 -07:00
committed by Georges Basile Stavracas Neto
parent 8865f87f1b
commit 615728fa3b
1 changed files with 48 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
libobs/util/platform-nix.c
+48 -2
View File
@@ -14,6 +14,14 @@
* OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
*/
#include "obsconfig.h"
#if !defined(__APPLE__) && OBS_QT_VERSION == 6
#define _GNU_SOURCE
#include <link.h>
#include <stdlib.h>
#endif
#include <stdio.h>
#include <errno.h>
#include <sys/types.h>
@@ -28,8 +36,6 @@
#include <time.h>
#include <signal.h>
#include "obsconfig.h"
#if !defined(__APPLE__)
#include <sys/times.h>
#include <sys/wait.h>
@@ -96,10 +102,50 @@ void os_dlclose(void *module)
dlclose(module);
}
#if !defined(__APPLE__) && OBS_QT_VERSION == 6
int module_has_qt5_check(const char *path)
{
void *mod = os_dlopen(path);
if (mod == NULL) {
return 1;
}
struct link_map *list = NULL;
if (dlinfo(mod, RTLD_DI_LINKMAP, &list) == 0) {
for (struct link_map *ptr = list; ptr; ptr = ptr->l_next) {
if (strstr(ptr->l_name, "libQt5") != NULL) {
return 0;
}
}
}
return 1;
}
bool has_qt5_dependency(const char *path)
{
pid_t pid = fork();
if (pid == 0) {
_exit(module_has_qt5_check(path));
}
if (pid < 0) {
return false;
}
int status;
if (waitpid(pid, &status, 0) < 0) {
return false;
}
return WIFEXITED(status) && WEXITSTATUS(status) == 0;
}
#endif
void get_plugin_info(const char *path, bool *is_obs_plugin, bool *can_load)
{
*is_obs_plugin = true;
*can_load = true;
#if !defined(__APPLE__) && OBS_QT_VERSION == 6
*can_load = !has_qt5_dependency(path);
#endif
UNUSED_PARAMETER(path);
}