UI: Use class member initializers for settings UI

Instead of using constructor initializer list, use class member
initialization

obs/window-basic-settings.cpp

@@ -124,14 +124,7 @@ void OBSBasicSettings::HookWidget(QWidget *widget, const char *signal,
 OBSBasicSettings::OBSBasicSettings(QWidget *parent)
 	: QDialog          (parent),
 	  main             (qobject_cast<OBSBasic*>(parent)),
-	  ui               (new Ui::OBSBasicSettings),
-	  generalChanged   (false),
-	  outputsChanged   (false),
-	  audioChanged     (false),
-	  videoChanged     (false),
-	  pageIndex        (0),
-	  loading          (true),
-	  streamProperties (nullptr)
+	  ui               (new Ui::OBSBasicSettings)
 {
 	string path;
 

obs/window-basic-settings.hpp

@@ -37,14 +37,14 @@ private:
 	OBSBasic *main;
 
 	std::unique_ptr<Ui::OBSBasicSettings> ui;
-	bool generalChanged;
-	bool outputsChanged;
-	bool audioChanged;
-	bool videoChanged;
-	int  pageIndex;
-	bool loading;
+	bool generalChanged = false;
+	bool outputsChanged = false;
+	bool audioChanged = false;
+	bool videoChanged = false;
+	int  pageIndex = 0;
+	bool loading = true;
 
-	OBSPropertiesView *streamProperties;
+	OBSPropertiesView *streamProperties = nullptr;
 
 	void SaveCombo(QComboBox *widget, const char *section,
 			const char *value);