opensource/n8n
3
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2026-09-21 04:37:50 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(editor): Resolve "Workflow not found" error on evaluations tab (no-changelog) (#29593)

Browse Source
This commit is contained in:
Luca Mattiazzi
2026-05-04 09:05:10 +00:00
committed by GitHub
parent baf5bb8e91
commit cf8887f9ea
4 changed files with 24 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/frontend/editor-ui/src/features/ai/evaluation.ee/views/EvaluationsRootView.test.ts
+11 -11
View File
@@ -111,7 +111,7 @@ describe('EvaluationsRootView', () => {
usageStore.getLicenseInfo.mockResolvedValue(undefined);
evaluationStore.fetchTestRuns.mockResolvedValue([]);
renderComponent({ props: { name: mockWorkflow.id } });
renderComponent({ props: { workflowId: mockWorkflow.id } });
await flushPromises();
@@ -124,7 +124,7 @@ describe('EvaluationsRootView', () => {
const evaluationStore = mockedStore(useEvaluationStore);
evaluationStore.fetchTestRuns.mockResolvedValue(mockTestRuns);
renderComponent({ props: { name: mockWorkflow.id } });
renderComponent({ props: { workflowId: mockWorkflow.id } });
await waitFor(() =>
expect(evaluationStore.fetchTestRuns).toHaveBeenCalledWith(mockWorkflow.id),
@@ -135,7 +135,7 @@ describe('EvaluationsRootView', () => {
const evaluationStore = mockedStore(useEvaluationStore);
evaluationStore.testRunsById = { foo: mock<TestRunRecord>({ workflowId: mockWorkflow.id }) };
const { container } = renderComponent({ props: { name: mockWorkflow.id } });
const { container } = renderComponent({ props: { workflowId: mockWorkflow.id } });
// Check that setupContent is not present
await waitFor(() => expect(container.querySelector('.setupContent')).toBeFalsy());
@@ -151,7 +151,7 @@ describe('EvaluationsRootView', () => {
evaluationStore.fetchTestRuns.mockResolvedValue([]);
evaluationStore.testRunsById = {};
const { container } = renderComponent({ props: { name: mockWorkflow.id } });
const { container } = renderComponent({ props: { workflowId: mockWorkflow.id } });
await flushPromises();
await waitFor(() => expect(container.querySelector('.setupContent')).toBeTruthy());
@@ -169,7 +169,7 @@ describe('EvaluationsRootView', () => {
evaluationStore.testRunsById = {};
sourceControlStore.preferences = mock<SourceControlPreferences>({ branchReadOnly: true });
const { container } = renderComponent({ props: { name: mockWorkflow.id } });
const { container } = renderComponent({ props: { workflowId: mockWorkflow.id } });
await flushPromises();
await waitFor(() => {
@@ -193,7 +193,7 @@ describe('EvaluationsRootView', () => {
// Mock no evaluation nodes in workflow
getNodeType.mockReturnValue(null);
renderComponent({ props: { name: mockWorkflow.id } });
renderComponent({ props: { workflowId: mockWorkflow.id } });
await waitFor(() => {
expect(useTelemetry().track).toHaveBeenCalledWith('User viewed tests tab', {
@@ -221,7 +221,7 @@ describe('EvaluationsRootView', () => {
usageStore.workflowsWithEvaluationsLimit = 10;
usageStore.workflowsWithEvaluationsCount = 1;
renderComponent({ props: { name: mockWorkflow.id } });
renderComponent({ props: { workflowId: mockWorkflow.id } });
await waitFor(() => {
expect(useTelemetry().track).toHaveBeenCalledWith('User viewed tests tab', {
@@ -264,7 +264,7 @@ describe('EvaluationsRootView', () => {
: null,
);
renderComponent({ props: { name: mockWorkflow.id } });
renderComponent({ props: { workflowId: mockWorkflow.id } });
await waitFor(() => {
expect(useTelemetry().track).toHaveBeenCalledWith('User viewed tests tab', {
@@ -316,7 +316,7 @@ describe('EvaluationsRootView', () => {
: null,
);
renderComponent({ props: { name: mockWorkflow.id } });
renderComponent({ props: { workflowId: mockWorkflow.id } });
await waitFor(() => {
expect(useTelemetry().track).toHaveBeenCalledWith('User viewed tests tab', {
@@ -368,7 +368,7 @@ describe('EvaluationsRootView', () => {
: null,
);
renderComponent({ props: { name: mockWorkflow.id } });
renderComponent({ props: { workflowId: mockWorkflow.id } });
await waitFor(() => {
expect(useTelemetry().track).toHaveBeenCalledWith('User viewed tests tab', {
@@ -396,7 +396,7 @@ describe('EvaluationsRootView', () => {
// Mock no evaluation nodes in workflow
getNodeType.mockReturnValue(null);
renderComponent({ props: { name: mockWorkflow.id } });
renderComponent({ props: { workflowId: mockWorkflow.id } });
await waitFor(() => {
expect(useTelemetry().track).toHaveBeenCalledWith('User viewed tests tab', {
packages/frontend/editor-ui/src/features/ai/evaluation.ee/views/EvaluationsRootView.vue
+7 -7
View File
@@ -14,7 +14,7 @@ import SetupWizard from '../components/SetupWizard/SetupWizard.vue';
import { N8nCallout, N8nLink, N8nText } from '@n8n/design-system';
const props = defineProps<{
name: string;
workflowId: string;
}>();
const usageStore = useUsageStore();
@@ -34,7 +34,7 @@ const isProtectedEnvironment = computed(() => {
const runs = computed(() => {
return Object.values(evaluationStore.testRunsById ?? {}).filter(
({ workflowId }) => workflowId === props.name,
({ workflowId }) => workflowId === props.workflowId,
);
});
@@ -47,13 +47,13 @@ const showWizard = computed(() => !hasRuns.value);
// Method to run a test - will be used by the SetupWizard component
async function runTest() {
try {
await evaluationStore.startTestRun(props.name);
await evaluationStore.startTestRun(props.workflowId);
} catch (error) {
toast.showError(error, locale.baseText('evaluation.listRuns.error.cantStartTestRun'));
return;
}
try {
await evaluationStore.fetchTestRuns(props.name);
await evaluationStore.fetchTestRuns(props.workflowId);
} catch (error) {
toast.showError(error, locale.baseText('evaluation.listRuns.error.cantFetchTestRuns'));
}
@@ -70,7 +70,7 @@ const evaluationsQuotaExceeded = computed(() => {
const { isReady } = useAsyncState(async () => {
try {
await usageStore.getLicenseInfo();
await evaluationStore.fetchTestRuns(props.name);
await evaluationStore.fetchTestRuns(props.workflowId);
} catch (error) {
toast.showError(error, locale.baseText('evaluation.listRuns.error.cantFetchTestRuns'));
}
@@ -82,7 +82,7 @@ watch(
if (ready) {
if (showWizard.value) {
telemetry.track('User viewed tests tab', {
workflow_id: props.name,
workflow_id: props.workflowId,
test_type: 'evaluation',
view: 'setup',
trigger_set_up: evaluationStore.evaluationTriggerExists,
@@ -92,7 +92,7 @@ watch(
});
} else {
telemetry.track('User viewed tests tab', {
workflow_id: props.name,
workflow_id: props.workflowId,
test_type: 'evaluation',
view: 'overview',
run_count: runs.value.length,
packages/frontend/editor-ui/src/features/ai/evaluation.ee/views/EvaluationsView.test.ts
+1 -1
View File
@@ -28,7 +28,7 @@ vi.mock('vue-router', () => {
});
const renderComponent = createComponentRenderer(EvaluationsView, {
props: { name: 'workflow-id' },
props: { workflowId: 'workflow-id' },
});
describe('EvaluationsView', () => {
packages/frontend/editor-ui/src/features/ai/evaluation.ee/views/EvaluationsView.vue
+5 -5
View File
@@ -9,7 +9,7 @@ import { useToast } from '@/app/composables/useToast';
import { N8nButton } from '@n8n/design-system';
const props = defineProps<{
name: string;
workflowId: string;
}>();
const locale = useI18n();
@@ -24,13 +24,13 @@ const runningTestRun = computed(() => runs.value.find((run) => run.status === 'r
async function runTest() {
try {
await evaluationStore.startTestRun(props.name);
await evaluationStore.startTestRun(props.workflowId);
} catch (error) {
toast.showError(error, locale.baseText('evaluation.listRuns.error.cantStartTestRun'));
}
try {
await evaluationStore.fetchTestRuns(props.name);
await evaluationStore.fetchTestRuns(props.workflowId);
} catch (error) {
toast.showError(error, locale.baseText('evaluation.listRuns.error.cantFetchTestRuns'));
}
@@ -54,7 +54,7 @@ async function stopTest() {
const runs = computed(() => {
const testRuns = Object.values(evaluationStore.testRunsById ?? {}).filter(
({ workflowId }) => workflowId === props.name,
({ workflowId }) => workflowId === props.workflowId,
);
return orderBy(testRuns, (record) => new Date(record.runAt), ['asc']).map((record, index) => ({
@@ -100,7 +100,7 @@ watch(runningTestRun, (run) => {
v-model:selected-metric="selectedMetric"
:class="$style.runs"
:runs="runs"
:workflow-id="props.name"
:workflow-id="props.workflowId"
/>
</div>
</div>