opensource/n8n
3
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2026-08-28 17:22:01 +08:00
Code Issues Packages Projects Releases Wiki Activity

refactor(API): De-Express variables create/update/delete paths (#37168)

Browse Source
This commit is contained in:
Dmitrii
2026-08-27 06:23:44 +00:00
committed by GitHub
parent aa2307d637
commit 98fbbf7079
2 changed files with 9 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/cli/src/errors/variable-validation.error.ts
+2 -2
View File
@@ -1,3 +1,3 @@
import { UnexpectedError } from 'n8n-workflow';
import { UserError } from 'n8n-workflow';
export class VariableValidationError extends UnexpectedError {}
export class VariableValidationError extends UserError {}
packages/cli/src/public-api/v1/handlers/variables/variables.handler.ts
+7 -8
View File
@@ -2,11 +2,6 @@ import { CreateVariableRequestDto, UpdateVariableRequestDto } from '@n8n/api-typ
import type { AuthenticatedRequest } from '@n8n/db';
import { Container } from '@n8n/di';
import { VariablesController } from '@/environments.ee/variables/variables.controller.ee';
import { VariablesService } from '@/environments.ee/variables/variables.service.ee';
import { BadRequestError } from '@/errors/response-errors/bad-request.error';
import type { VariablesRequest } from '@/requests';
import type { PublicAPIEndpoint } from '../../shared/handler.types';
import {
apiKeyHasScopeWithGlobalScopeFallback,
@@ -15,6 +10,10 @@ import {
} from '../../shared/middlewares/global.middleware';
import { paginateArray } from '../../shared/services/pagination.service';
import { VariablesService } from '@/environments.ee/variables/variables.service.ee';
import { BadRequestError } from '@/errors/response-errors/bad-request.error';
import type { VariablesRequest } from '@/requests';
type VariablesHandlers = {
createVariable: PublicAPIEndpoint<AuthenticatedRequest>;
updateVariable: PublicAPIEndpoint<AuthenticatedRequest<{ id: string }>>;
@@ -31,7 +30,7 @@ const variablesHandlers: VariablesHandlers = {
if (payload.error) {
throw new BadRequestError(payload.error.errors[0]?.message ?? 'Invalid request body');
}
await Container.get(VariablesController).createVariable(req, res, payload.data);
await Container.get(VariablesService).create(req.user, payload.data);
return res.status(201).send();
},
@@ -44,7 +43,7 @@ const variablesHandlers: VariablesHandlers = {
if (payload.error) {
throw new BadRequestError(payload.error.errors[0]?.message ?? 'Invalid request body');
}
await Container.get(VariablesController).updateVariable(req, res, payload.data);
await Container.get(VariablesService).update(req.user, req.params.id, payload.data);
return res.status(204).send();
},
@@ -53,7 +52,7 @@ const variablesHandlers: VariablesHandlers = {
isLicensed('feat:variables'),
apiKeyHasScopeWithGlobalScopeFallback({ scope: 'variable:delete' }),
async (req, res) => {
await Container.get(VariablesController).deleteVariable(req);
await Container.get(VariablesService).deleteForUser(req.user, req.params.id);
return res.status(204).send();
},