opensource/n8n
3
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2026-09-24 23:22:38 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(editor): Allow running webhook workflow even when a node has error (#22239)

Browse Source 
Co-authored-by: Danny Martini <danny@n8n.io>
This commit is contained in:
Alex Grozav
2025-12-10 12:31:19 +02:00
committed by GitHub
co-authored by Danny Martini
parent 48b2b44967
commit 94137d08db
3 changed files with 38 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/frontend/editor-ui/src/app/composables/useRunWorkflow.test.ts
+2 -4
View File
@@ -219,7 +219,7 @@ describe('useRunWorkflow({ router })', () => {
expect(workflowsStore.executionWaitingForWebhook).toBe(false);
});
it('should prevent running a webhook-based workflow that has issues', async () => {
it('should not prevent running a webhook-based workflow that has issues', async () => {
const { runWorkflowApi } = useRunWorkflow({ router });
vi.mocked(workflowsStore).nodesIssuesExist = true;
vi.mocked(workflowsStore).runWorkflow.mockResolvedValue({
@@ -227,9 +227,7 @@ describe('useRunWorkflow({ router })', () => {
waitingForWebhook: true,
});
await expect(runWorkflowApi({} as IStartRunData)).rejects.toThrow(
'workflowRun.showError.resolveOutstandingIssues',
);
await expect(runWorkflowApi({} as IStartRunData)).resolves.not.toThrow();
vi.mocked(workflowsStore).nodesIssuesExist = false;
});
packages/frontend/editor-ui/src/app/composables/useRunWorkflow.ts
-5
View File
@@ -113,11 +113,6 @@ export function useRunWorkflow(useRunWorkflowOpts: {
workflowState.setActiveExecutionId(response.executionId);
}
if (response.waitingForWebhook === true && workflowsStore.nodesIssuesExist) {
workflowState.setActiveExecutionId(undefined);
throw new Error(i18n.baseText('workflowRun.showError.resolveOutstandingIssues'));
}
if (response.waitingForWebhook === true) {
workflowsStore.executionWaitingForWebhook = true;
}
packages/testing/playwright/tests/e2e/api/webhook.spec.ts
+36
View File
@@ -225,6 +225,42 @@ test.describe.skip('Webhook Trigger node', () => {
});
expect(successResponse.ok()).toBe(true);
});
test('CAT-1253-bug-cant-run-workflow-when-unconnected-nodes-have-errors', async ({ n8n }) => {
const webhookPath = nanoid();
// Add Webhook node
await n8n.canvas.addNode('Webhook');
await n8n.ndv.setupHelper.webhook({
httpMethod: 'GET',
path: webhookPath,
});
await n8n.ndv.close();
// Add No Operation node - it will connect automatically since Webhook node is in context
await n8n.canvas.nodeByName('Webhook').click();
await n8n.canvas.addNode('No Operation, do nothing', { closeNDV: true });
// Verify connection was created
await expect(n8n.canvas.nodeConnections()).toHaveCount(1);
// Add HTTP Request node (unconnected, which will have an error)
await n8n.canvas.deselectAll();
await n8n.canvas.addNode('HTTP Request', { closeNDV: true });
// Verify we now have 3 nodes but still only 1 connection
await expect(n8n.canvas.getCanvasNodes()).toHaveCount(3);
await expect(n8n.canvas.nodeConnections()).toHaveCount(1);
// Execute the workflow
await n8n.canvas.clickExecuteWorkflowButton();
// Assert that webhook is waiting for trigger
await expect(n8n.canvas.waitingForTriggerEvent()).toBeVisible();
// Assert that no error toast appeared
await expect(n8n.notifications.getErrorNotifications()).toHaveCount(0);
});
});
async function addEditFieldsNode(n8n: n8nPage): Promise<void> {