opensource/n8n
3
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2026-08-30 18:01:23 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(QuickBooks Node): Initialize headers object in quickBooksApiRequest (#34291)

Browse Source 
Co-authored-by: Prathamesh Hukkeri <prathamesh04@users.noreply.github.com>
This commit is contained in:
PRATHAMESH HUKKERI
2026-07-16 18:53:16 +05:30
committed by GitHub
parent cc0dec234b
commit 83dd194a89
2 changed files with 85 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/nodes-base/nodes/QuickBooks/GenericFunctions.ts
+1
View File
@@ -48,6 +48,7 @@ export async function quickBooksApiRequest(
qs,
body,
json: !isDownload,
headers: {},
};
if (!Object.keys(body).length) {
packages/nodes-base/nodes/QuickBooks/__tests__/GenericFunctions.test.ts
+84 -1
View File
@@ -1,6 +1,89 @@
import { mockDeep } from 'vitest-mock-extended';
import type { IExecuteFunctions } from 'n8n-workflow';
import { processLines } from '../GenericFunctions';
import { processLines, quickBooksApiRequest } from '../GenericFunctions';
describe('quickBooksApiRequest', () => {
const mockExecuteFunctions = mockDeep<IExecuteFunctions>();
beforeEach(() => {
vi.resetAllMocks();
mockExecuteFunctions.getNodeParameter.mockReturnValue('invoice');
mockExecuteFunctions.getCredentials.mockResolvedValue({
environment: 'production',
});
});
it('should initialize headers for send operation', async () => {
mockExecuteFunctions.getNodeParameter
.mockReturnValueOnce('invoice')
.mockReturnValueOnce('send');
await quickBooksApiRequest.call(mockExecuteFunctions, 'POST', '/test', {}, {});
expect(mockExecuteFunctions.helpers.requestOAuth2).toHaveBeenCalledWith(
'quickBooksOAuth2Api',
expect.objectContaining({
headers: expect.objectContaining({
'Content-Type': 'application/octet-stream',
}),
}),
);
});
it('should initialize headers for void operation', async () => {
mockExecuteFunctions.getNodeParameter
.mockReturnValueOnce('invoice')
.mockReturnValueOnce('void');
await quickBooksApiRequest.call(mockExecuteFunctions, 'POST', '/test', {}, {});
expect(mockExecuteFunctions.helpers.requestOAuth2).toHaveBeenCalledWith(
'quickBooksOAuth2Api',
expect.objectContaining({
headers: expect.objectContaining({
'Content-Type': 'application/json',
}),
}),
);
});
it('should initialize headers for delete operation', async () => {
mockExecuteFunctions.getNodeParameter
.mockReturnValueOnce('payment')
.mockReturnValueOnce('delete');
await quickBooksApiRequest.call(mockExecuteFunctions, 'POST', '/test', {}, {});
expect(mockExecuteFunctions.helpers.requestOAuth2).toHaveBeenCalledWith(
'quickBooksOAuth2Api',
expect.objectContaining({
headers: expect.objectContaining({
'Content-Type': 'application/json',
}),
}),
);
});
it('should initialize headers for download operation', async () => {
mockExecuteFunctions.getNodeParameter
.mockReturnValueOnce('invoice')
.mockReturnValueOnce('get')
.mockReturnValueOnce(true);
await quickBooksApiRequest.call(mockExecuteFunctions, 'GET', '/test', {}, {});
expect(mockExecuteFunctions.helpers.requestOAuth2).toHaveBeenCalledWith(
'quickBooksOAuth2Api',
expect.objectContaining({
headers: expect.objectContaining({
Accept: 'application/pdf',
}),
}),
);
});
});
describe('processLines', () => {
const mockExecuteFunctions: Partial<IExecuteFunctions> = {
getNodeParameter: vi.fn(),