Ben Schumacher a3e171f730 [MM-70224] Migrate property field reads to request context (#37636)
* Migrate property field reads to request context

Co-authored-by: Ben Schumacher <hanzei@users.noreply.github.com>

* Preserve nil property service request context behavior

Co-authored-by: Ben Schumacher <hanzei@users.noreply.github.com>

* Use explicit session attributes system context

Co-authored-by: Ben Schumacher <hanzei@users.noreply.github.com>

* Use non-nil property contexts for internal calls

Co-authored-by: Ben Schumacher <hanzei@users.noreply.github.com>

* Thread request context through content flagging lookups

Co-authored-by: Ben Schumacher <hanzei@users.noreply.github.com>

* Update content flagging helper tests for request context

Co-authored-by: Ben Schumacher <hanzei@users.noreply.github.com>

* Thread request context through content flagging values

Co-authored-by: Ben Schumacher <hanzei@users.noreply.github.com>

* Fix build: remove unused context imports left after request.CTX migration

Migrating PropertyFieldStore to request.CTX removed the last
context.Context usage from the store.go interface, leaving an unused
"context" import in store.go and in the generated retrylayer/timerlayer
files (regenerated via `make store-layers`, with layer_generators now
stripping the context import when it's unused). Also drop the same
now-unused import in localcachelayer/main_test.go.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

* Remove context import directly from store layer templates

Store no longer has any context.Context methods after the request.CTX
migration, so drop the hardcoded "context" import from the
retry/timer layer templates instead of stripping it at generation
time.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

* Remove deprecated store.WithMaster/sqlstore.WithMaster helpers

request.CTX is now used everywhere, so the deprecated
context.Context-based WithMaster helpers and their wrapper in
sqlstore have no remaining callers; inline the logic into
RequestContextWithMaster instead.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

* Fix TestDoSetupSessionAttributesProperties nil-context panic

Two subtests still constructed the pre-seed field state via
UpdatePropertyFields(nil, ...), which was the old system-caller
sentinel. isSystemCaller now requires an explicit SystemCallerContext
marker, so a bare nil rctx falls through into validateUpdate and
panics in RequestContextWithMaster. Use SystemCallerContext(th.Context)
like the rest of the suite already does.

* ci trigger

* ci trigger

---------

Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Ben Schumacher <hanzei@users.noreply.github.com>
Co-authored-by: Mattermost Build <build@mattermost.com>
Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
2026-08-24 10:35:12 +02:00
2018-05-30 10:23:25 -04:00
2026-04-01 13:03:36 +00:00

Mattermost logo

Mattermost is an open core, self-hosted collaboration platform that offers chat, workflow automation, voice calling, screen sharing, and AI integration. This repo is the primary source for core development on the Mattermost platform; it's written in Go and React, runs as a single Linux binary, and relies on PostgreSQL. A new compiled version is released under an MIT license every month on the 16th.

Deploy Mattermost on-premises, or try it for free in the cloud.

mattermost user interface

Learn more about the following use cases with Mattermost:

Other useful resources:

Table of contents

Install Mattermost

Other install guides:

Native mobile and desktop apps

In addition to the web interface, you can also download Mattermost clients for Android, iOS, Windows PC, macOS, and Linux.

Get Mattermost on Google Play Get Mattermost on the App Store Get Mattermost on Windows PC Get Mattermost on Mac OSX Get Mattermost on Linux

Get security bulletins

Receive notifications of critical security updates. The sophistication of online attackers is perpetually increasing. If you're deploying Mattermost it's highly recommended you subscribe to the Mattermost Security Bulletin mailing list for updates on critical security releases.

Subscribe here

Get involved

Learn more

License

See the LICENSE file for license rights and limitations.

Get the latest news

Contributing

Small Image

Please see CONTRIBUTING.md. Join the Mattermost Contributors server to join community discussions about contributions, development, and more.

S
Description
Mattermost is an open source platform for secure collaboration across the entire software development lifecycle..
Readme 2.3 GiB
Languages
TypeScript 48.2%
Go 41.4%
JavaScript 5.4%
SCSS 2.6%
HTML 2.1%
Other 0.2%