85e95437ab [MM-70822] Explain the blocked section switch while editing a channel permission rule (#38751)
* [MM-70822] Explain the blocked section switch while editing a channel permission rule

The Channel Settings modal refuses to switch sections while a tab reports
unsaved changes, and the Permissions Policy tab reports unsaved changes for as
long as its rule editor is open. The SaveChangesPanel that explains the refusal
only renders in that tab's list view, so clicking Info, Membership Policy or
Configuration while editing a rule did nothing at all: no section change, no
message, even though the items still looked clickable.

Route the modal's existing showTabSwitchError signal into the rule editor's
error slot so the refusal is explained where the user is looking, and mark that
slot role='alert' so it is announced rather than only seen.

Co-authored-by: mattermost-code <matty-code@mattermost.com>

* [MM-70822] Scroll the blocked section-switch warning into view

When the rule editor is taller than the modal, the alert that explains a
refused section switch sat below the fold. Scroll it into view when the
error appears so the message is actually visible.

Co-authored-by: mattermost-code <matty-code@mattermost.com>

* Align max-login-attempts Playwright locators with current login copy

The full Playwright suite failed on max_login_attempts.spec.ts: exact
matches for the old invalid-credentials banner and lockout sentence no
longer hold. Use the shared invalidCredentialsError locator and the
stable lock-message prefix.

Co-authored-by: mattermost-code <matty-code@mattermost.com>

* Pick future dates in the demo plugin date dialog e2e spec

Days 20 and 22 of the current month are in the past after mid-month, and
the plugin rejects those submissions. Advance to next month in that case.

Co-authored-by: mattermost-code <matty-code@mattermost.com>

* Retrigger CI for Enterprise docker image and E2E

Co-authored-by: mattermost-code <matty-code@mattermost.com>

* [MM-70822] Report the blocked section switch through the modal's floating footer

Per review, the rule editor now raises the same SaveChangesPanel the rest of
the Channel Settings modal uses, in its built-in error state, instead of a
bespoke inline message — matching the Team Settings membership policy editor.

The footer is position: fixed at the bottom of the modal, so it is visible
whatever the editor is scrolled to; the scroll-into-view workaround the inline
message needed goes away with it. Saving from the footer stays disabled (the
rule is committed from the editor's own button) and its Cancel leaves the
editor, so the two ways out of the block are the ones the message names.

Co-authored-by: mattermost-code <matty-code@mattermost.com>

* [MM-70822] Cover the blocked-switch footer's way out in the E2E spec

The footer's Cancel is now the exit the message points at, so assert it drops
the draft and returns to the rules list.

Co-authored-by: mattermost-code <matty-code@mattermost.com>

* Revert unrelated e2e test fixes

Restore demo_dialog_date.spec.ts and max_login_attempts.spec.ts to their
upstream state. These e2e changes are unrelated to the MM-70822 channel
permission-rule fix and were flagged for removal in review.

Address PR feedback: 0 answered, 1 resolved, 0 declined

* Retrigger CI after an unrelated Playwright flake on HEAD

Co-authored-by: mattermost-code <matty-code@mattermost.com>

---------

Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: mattermost-code <matty-code@mattermost.com>
Co-authored-by: Mattermost Build <build@mattermost.com>
2026-10-02 19:03:29 -04:00
2018-05-30 10:23:25 -04:00

Mattermost logo

Mattermost is an open core, self-hosted collaboration platform that offers chat, workflow automation, voice calling, screen sharing, and AI integration. This repo is the primary source for core development on the Mattermost platform; it's written in Go and React, runs as a single Linux binary, and relies on PostgreSQL. A new compiled version is released under an MIT license every month on the 16th.

Deploy Mattermost on-premises, or try it for free in the cloud.

mattermost user interface

Learn more about the following use cases with Mattermost:

Other useful resources:

Table of contents

Install Mattermost

Other install guides:

Native mobile and desktop apps

In addition to the web interface, you can also download Mattermost clients for Android, iOS, Windows PC, macOS, and Linux.

Get Mattermost on Google Play Get Mattermost on the App Store Get Mattermost on Windows PC Get Mattermost on Mac OSX Get Mattermost on Linux

Get security bulletins

Receive notifications of critical security updates. The sophistication of online attackers is perpetually increasing. If you're deploying Mattermost it's highly recommended you subscribe to the Mattermost Security Bulletin mailing list for updates on critical security releases.

Subscribe here

Get involved

Learn more

License

See the LICENSE file for license rights and limitations.

Get the latest news

Contributing

Small Image

Please see CONTRIBUTING.md. Join the Mattermost Contributors server to join community discussions about contributions, development, and more.

S
Description
Mattermost is an open source platform for secure collaboration across the entire software development lifecycle..
Readme
2.4 GiB
Languages
TypeScript 48.2%
Go 41.4%
JavaScript 5.4%
SCSS 2.6%
HTML 2.1%
Other 0.2%