Felipe Martin 4d8c25f040 [MM-68736] Reconcile partial GM membership in bulk import (#36542)
* [MM-68736] Reconcile partial GM membership in bulk import

importDirectChannel failed with "ChannelMember not found" when the
group channel hash already existed in Channels but one or more
participants were missing from ChannelMembers (concurrent import
workers, a prior import that crashed mid SaveMember loop, or a
pre-existing GM whose membership has drifted).

The function only used existingMembers to compare LastViewedAt and
still appended absent participants to UpdateMultipleMembers, whose
UPDATE-then-SELECT returns sql.ErrNoRows for the missing row.

Insert the missing ChannelMembers row via SaveMember (logging the
join event) before the UPDATE path. ErrConflict is treated as benign
so concurrent workers racing on the same MPIM hash do not fail each
other.

* [MM-68736] Add missing i18n key for new bulk import error

The save_member.error key was added in the importDirectChannel fix but
not registered in i18n/en.json.

* [MM-68736] Address review feedback

- Broaden the save_member.error translation to also cover DM imports,
  since importDirectChannel runs the same SaveMember reconciliation
  path for both 2-participant DMs and 3+-participant GMs.
- In the idempotent re-import test, assert that
  ChannelMemberHistory.GetMembershipChanges returns no rows after the
  second import. LogJoinEvent is only invoked when the missing-member
  branch runs, so an empty result proves SaveMember was not called
  for any already-present participant.
2026-05-25 12:17:08 +02:00

Mattermost logo

Mattermost is an open core, self-hosted collaboration platform that offers chat, workflow automation, voice calling, screen sharing, and AI integration. This repo is the primary source for core development on the Mattermost platform; it's written in Go and React, runs as a single Linux binary, and relies on PostgreSQL. A new compiled version is released under an MIT license every month on the 16th.

Deploy Mattermost on-premises, or try it for free in the cloud.

mattermost user interface

Learn more about the following use cases with Mattermost:

Other useful resources:

Table of contents

Install Mattermost

Other install guides:

Native mobile and desktop apps

In addition to the web interface, you can also download Mattermost clients for Android, iOS, Windows PC, macOS, and Linux.

Get Mattermost on Google Play Get Mattermost on the App Store Get Mattermost on Windows PC Get Mattermost on Mac OSX Get Mattermost on Linux

Get security bulletins

Receive notifications of critical security updates. The sophistication of online attackers is perpetually increasing. If you're deploying Mattermost it's highly recommended you subscribe to the Mattermost Security Bulletin mailing list for updates on critical security releases.

Subscribe here

Get involved

Learn more

License

See the LICENSE file for license rights and limitations.

Get the latest news

Contributing

Small Image

Please see CONTRIBUTING.md. Join the Mattermost Contributors server to join community discussions about contributions, development, and more.

S
Description
Mattermost is an open source platform for secure collaboration across the entire software development lifecycle..
Readme
2.3 GiB
Languages
TypeScript 48.2%
Go 41.4%
JavaScript 5.4%
SCSS 2.6%
HTML 2.1%
Other 0.2%