mirror of
https://github.com/mattermost/mattermost.git
synced 2026-10-16 15:18:10 +08:00
Allow data-testid on FeatureDiscovery panel button props
Compass ButtonProps does not declare data-testid; widen the local primary-action type so Cypress selectors keep working and tsc passes. Co-authored-by: Matthew Birtch <mattbirtch@gmail.com>
This commit is contained in:
co-authored by
Matthew Birtch
parent
24c06762db
commit
fb604ea02d
+8
-3
@@ -25,6 +25,11 @@ import type {ModalData} from 'types/actions';
|
||||
|
||||
import './feature_discovery.scss';
|
||||
|
||||
// Compass ButtonProps omits data-* keys that Cypress selectors still rely on.
|
||||
type PanelButtonProps = ButtonProps & {
|
||||
'data-testid'?: string;
|
||||
};
|
||||
|
||||
type Props = {
|
||||
featureName: string;
|
||||
minimumSKURequiredForFeature: LicenseSkus;
|
||||
@@ -107,7 +112,7 @@ export default class FeatureDiscovery extends React.PureComponent<Props, State>
|
||||
),
|
||||
});
|
||||
|
||||
renderContactSalesPrimaryAction = (size: ButtonProps['size'] = 'medium'): ButtonProps => ({
|
||||
renderContactSalesPrimaryAction = (size: ButtonProps['size'] = 'medium'): PanelButtonProps => ({
|
||||
emphasis: 'primary',
|
||||
size,
|
||||
'data-testid': 'featureDiscovery_primaryCallToAction',
|
||||
@@ -122,7 +127,7 @@ export default class FeatureDiscovery extends React.PureComponent<Props, State>
|
||||
),
|
||||
});
|
||||
|
||||
renderStartTrialPrimaryAction = (size: ButtonProps['size'] = 'medium'): ButtonProps => ({
|
||||
renderStartTrialPrimaryAction = (size: ButtonProps['size'] = 'medium'): PanelButtonProps => ({
|
||||
emphasis: 'primary',
|
||||
size,
|
||||
id: 'start_trial_btn',
|
||||
@@ -268,7 +273,7 @@ export default class FeatureDiscovery extends React.PureComponent<Props, State>
|
||||
const showHostStartTrialActions = !showPostTrialCta && !isCloud;
|
||||
|
||||
let panelActions: {
|
||||
primaryAction?: ButtonProps;
|
||||
primaryAction?: PanelButtonProps;
|
||||
secondaryAction?: ButtonAsChildProps;
|
||||
};
|
||||
if (showPostTrialCta) {
|
||||
|
||||
Reference in New Issue
Block a user