[MM-61513] Fix errcheck issues in channels/app/users/users_test.go fixes #29179 (#29188)

Co-authored-by: Ben Schumacher <ben.schumacher@mattermost.com>

server/.golangci.yml

@@ -153,7 +153,6 @@ issues:
         channels/app/user.go|\
         channels/app/user_test.go|\
         channels/app/users/helper_test.go|\
-        channels/app/users/users_test.go|\
         channels/app/web_broadcast_hooks_test.go|\
         channels/app/webhook_test.go|\
         channels/jobs/batch_worker_test.go|\

server/channels/app/users/users_test.go

@@ -56,7 +56,8 @@ func TestFirstUserPromoted(t *testing.T) {
 
 	require.Equal(t, model.SystemUserRoleId, user2.Roles)
 
-	th.dbStore.User().PermanentDelete(th.Context, user.Id)
+	err = th.dbStore.User().PermanentDelete(th.Context, user.Id)
+	require.NoError(t, err)
 
 	b := &model.Bot{
 		UserId:   user2.Id,